Skip to content

docs: fix typos in MetricStore doc comments #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s3onghyun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: fix typos in MetricStore doc comments #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions storage/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ type MetricStore interface {
// implementation). Also, all internal goroutines are stopped. This
// method blocks until all of that is complete. If an error is
// encountered, it is returned (whereupon the MetricStorage is in an
// undefinded state). If nil is returned, the MetricStore cannot be
// undefined state). If nil is returned, the MetricStore cannot be
// "restarted" again, but it can still be used for read operations.
Shutdown() error
// Healthy returns nil if the MetricStore is currently working as
Expand Down Expand Up @@ -84,7 +84,7 @@ type MetricStore interface {
// sanitized to have the same job and other labels as those in the Labels
// fields. Also, if there is no instance label, an instance label with an empty
// value will be set. This implies that the MetricFamilies in the WriteRequest
// may be modified be the MetricStore during processing of the WriteRequest!
// may be modified by the MetricStore during processing of the WriteRequest!
//
// The Timestamp field marks the time the request was received from the
// network. It is not related to the TimestampMs field in the Metric proto
Expand Down