Skip to content

fix(om2): small corrections to ABNF #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krajorama merged 1 commit into from
Mar 25, 2026
Merged

fix(om2): small corrections to ABNF #2921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions docs/specs/om/open_metrics_spec_2_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ exposition = metricset HASH SP eof [ LF ]

metricset = *metricfamily

metricfamily = *metric-descriptor *metric
metricfamily = *metric-descriptor *sample

metric-descriptor = HASH SP type SP (metricname / metricname-utf8) SP metric-type LF
metric-descriptor =/ HASH SP help SP (metricname / metricname-utf8) SP escaped-string LF
Expand All @@ -462,9 +462,7 @@ metric-descriptor =/ HASH SP unit SP (metricname / metricname-utf8) SP *metricna
metric-type = counter / gauge / histogram / gaugehistogram / stateset
metric-type =/ info / summary / unknown

metric = metricname-and-labels SP sample

sample = value [SP timestamp] [SP start-timestamp] *exemplar LF
sample = metricname-and-labels SP value [SP timestamp] [SP start-timestamp] *exemplar LF

value = number / "{" composite-value "}"

Expand All @@ -488,10 +486,8 @@ number =/ [SIGN] ("inf" / "infinity")
number =/ "nan"

; Real floats
; Not 100% sure this captures all float corner cases
; Leading 0s explicitly okay
realnumber = [SIGN] 1*DIGIT
realnumber =/ [SIGN] 1*DIGIT ["." *DIGIT] [ "e" [SIGN] 1*DIGIT ]
realnumber = [SIGN] 1*DIGIT ["." *DIGIT] [ "e" [SIGN] 1*DIGIT ]
realnumber =/ [SIGN] *DIGIT "." 1*DIGIT [ "e" [SIGN] 1*DIGIT ]

; Integers
Expand Down Expand Up @@ -585,8 +581,8 @@ nh-positive-spans = %d112.111.115.105.116.105.118.101 "_" %d115.112.97.110.115 "
; Spans hold offset and length. The offset can start from any index, even
; negative, however subsequent spans can only advance the index, not decrease it.
nh-spans = nh-start-span *("," nh-span)
nh-start-span = integer ":" positive-integer
nh-span = non-negative-integer ":" positive-integer
nh-start-span = integer ":" non-negative-integer
nh-span = non-negative-integer ":" non-negative-integer

; negative_buckets:[1,2,3] and positive_buckets:[1,2,3]
nh-negative-buckets = %d110.101.103.97.116.105.118.101 "_" %d98.117.99.107.101.116.115 ":" "[" [nh-buckets] "]"
Expand Down
Loading