fix: preserve retry timeout errors - #592
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
When Options.Timeout expires during backoff, Do exits the retry loop with the previous request error. After a retryable response, that error is nil. PassthroughErrorHandler then returns success even though the deadline expired.
Save context.DeadlineExceeded before leaving the loop. The default error now wraps it, and custom handlers receive it. Six test cases cover response retries, transport failures and ordinary retry exhaustion. All four timeout cases fail before the fix.
go test -race -count=1 -json ./... passes all 45 tests and subtests on Go 1.26.0. go build ./... and go run . -short in examples/ both pass.
golangci-lint 2.12.2 reports two QF1008 findings in unchanged request_test.go. Untouched upstream reports the same two findings.