Skip to content

Conversation

@dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Jan 21, 2026

fixes #724 - update Go version from 1.21.1 to 1.24 to match go.mod requirement

Summary by CodeRabbit

  • Chores
    • Updated container base images to newer Go and Alpine versions for improved compatibility, security, and performance.
    • Configured the container to start the application automatically by defining a default startup command.
    • Bumped the displayed application version to 1.3.1 (updated banner/version shown to users).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Walkthrough

Bumped Docker base images and set an ENTRYPOINT in Dockerfile; updated the package version constant from 1.3.0 to 1.3.1 in internal/runner/banner.go. Lines changed: small, focused edits across build config and a banner/version constant.

Changes

Cohort / File(s) Summary
Docker Configuration
Dockerfile
Builder image updated from golang:1.21.1-alpinegolang:1.24-alpine; release image updated from alpine:3.18.4alpine:3.23; added ENTRYPOINT ["cloudlist"].
Banner / Version
internal/runner/banner.go, go.mod
Bumped exported/static version constant from 1.3.01.3.1. go.mod touched alongside version bump.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I nudged the Go and Alpine high,
A tiny hop — a newer sky.
Version bumped, the banner sings,
ENTRYPOINT set for brighter things. 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes an out-of-scope version bump from 1.3.0 to 1.3.1 in banner.go that is unrelated to the linked issue #724 about fixing Docker build failures. Remove the version bump in internal/runner/banner.go or link it to a separate issue for version management, as it is not required to fix the Docker build failure.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix Dockerfile Go version' clearly describes the main change: updating the Dockerfile's Go version, which directly addresses the primary objective of fixing Docker build failures.
Linked Issues check ✅ Passed The PR successfully addresses issue #724 by updating the Dockerfile Go version from 1.21.1 to 1.24 to match go.mod requirements and fix Docker build failures.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir dogancanbakir force-pushed the fix-dockerfile-go-version branch from b25b870 to e73952d Compare January 21, 2026 14:29
@Mzack9999 Mzack9999 merged commit a41f206 into dev Jan 22, 2026
9 checks passed
@Mzack9999 Mzack9999 deleted the fix-dockerfile-go-version branch January 22, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix docker build fail

3 participants