Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2ef18a7
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @Danathar, head
Hive did not add the |
There was a problem hiding this comment.
HUMAN DECISION NEEDED — @Danathar @hanthor: accept booted-update evidence for this branch (or other evidence per #551) and remove hold; no CI job on this PR can produce it.
Summary: This change lets people make lasting SELinux changes on Utah with the same commands as on Bluefin, by moving the policy store to a writable place. The code is a faithful re-apply of the earlier merged-then-reverted fix and is sound; the one thing missing is the proof on a real booted machine that the maintainer asked for before merging. That proof has to be produced by hand, because the automated pipeline for this PR never runs the update test the PR extends.
What I need from you: Run the booted update test against an image built from this branch, attach the evidence, then drop hold here and on #551.
intent-alignment
- Medium, in-scope. Per #551 (hanthor, 2026-10-12): "Do not merge a store relocation until a booted Utah test confirms…". The PR adds those checks to
iso/scripts/lifecycle-e2e.sh:596-608and:726-749, but nothing in CI runs that harness:review_vmisworkflow_dispatch-only (.github/workflows/build.yml:338) and, when it does run, it executesiso/scripts/luks-e2e.sh(build.yml:428), notlifecycle-e2e.sh. The only entry point isjust lifecycle-test(Justfile:544). The hold is therefore correct, and releasing it needs a human to run that recipe (orbash iso/scripts/lifecycle-e2e.sh <iso> ghcr.io/projectbluefin/utah:testing <image-from-this-branch>) and postevidence/selinux-{probe,apply,verify,reject,remove}-*.txt. Not a code defect; a merge-gate decision only a maintainer can own. - Verified the body's claims: all 11 files at
2ef18a7are byte-identical to76cc546; the extra commit ondocs/skills/local-testing.mdis word-for-word identical to #874's text (rewrap only) and lands the page at exactly 500 lines;tests/test_selinux_store.pypasses (20) andscripts/check-skill-frontmatter.shreports no errors.
style
- Low, in-scope.
iso/scripts/verify-selinux-store.sh:208hard-codes/etc/selinux/targeted/activeinreject, while the rest of the script derives paths from theUTAH_*overrides (:28-30) so host fixtures never touch the real store. A fixture that ever drivesrejectpast thestore_is_persistentguard would scan the host's store.if [[ -n "$(find "$(dirname "$SEMANAGE_CONF")/targeted/active" -name "${BAD_MODULE}*" 2>/dev/null)" ]]; then
No findings from: correctness, security, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requires a human decision
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict approved @3c345ac, 11/15 checks green, 4 pending, required not reported: build_main / Check all testing builds successful, soak 0s of 30m0s, labels: hold. What to do: resolve the reason for Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-09 15:26 UTC. |
hanthor
left a comment
There was a problem hiding this comment.
Review (verdict: changes needed; keep the hold). This restores #874's implementation unchanged (only doc wrapping differs from 76cc546), and #893 reverted #874 because booted-update verification was required (#551). That verification is not in this PR: the build run (40155197567) passes the host tests and all four image builds but skips review_vm and dispatch-iso, the branch has no workflow dispatch, and even the opt-in review_vm job runs luks-e2e.sh, not lifecycle-e2e.sh, so no persistence, policy-refresh, first-boot relabel or rollback evidence exists. One concrete code finding: require_image_policy in iso/scripts/verify-selinux-store.sh:111-126 compares only seinfo -t type-name sets and loaded module names, so a candidate with identical names but a changed allow rule in an existing module passes while the old compiled policy is still running; it then reports the image policy as running. Add a candidate-specific policy assertion checked right after the update and before any rebuilding SELinux command. Also: rollback checks desktop/digest/BLS but not SELinux state, and malformed-CIL rejection does not exercise an installed module becoming incompatible across an update. Wiring (COPY/rename, ordering before both home-label rebuilds), kernel-cache-tag inputs and pins check out. Note #928/#938 (composefs) change the deployment mechanism and would need their own evidence. Reviewed with Claude; static analysis, no VM run.
…n rollback Review on #894: require_image_policy compared only type names and module names, so a candidate that changed an allow rule in an existing module passed while the old compiled policy kept running. - verify-selinux-store.sh compares types and TE rules (sesearch -A -T) of the pristine compiled policy with the running policy, both ways, minus the sample module's type. Empty tool output fails instead of comparing equal. A new image-policy mode runs only this check. - lifecycle-e2e.sh runs image-policy in Phase 3 before apply, verify, reject or remove rebuild the policy, and in Phase 4 checks that the rolled-back baseline has its own store layout and runs its own policy. - Fixture tests drive image-policy against fake seinfo/sesearch/semodule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@hanthor thanks for the review. Pushed e4df8a9, which covers the code finding and the rollback gap. Code finding (names-only policy check): Rollback: Phase 4 now checks that the restored baseline reports the same store layout ( Tests: new Not done here, and still the human-owned gate:
🐝 Hive Agent: |
e4df8a9
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @Danathar, head
Hive did not add the |
There was a problem hiding this comment.
Summary: This change lets people make lasting SELinux changes on Utah with the same commands as on Bluefin, by moving the policy store to a place that stays writable on a running system. The code re-applies the earlier fix that was merged and then undone (#874/#893), plus a stricter after-update check that the newer policy really is the one running, and a rollback check. The code is sound; the one thing left to fix in the PR itself is its description, which still says the branch is an unchanged copy of the earlier fix when it is not.
What I need from you: Update the PR description to describe what the branch now contains.
intent-alignment
-
low — The PR body says the content is "#874's squash commit
76cc546, cherry-picked unchanged. All 11 files match it exactly" and "tests/test_selinux_store.pypasses (20)". After e4df8a9 that is no longer true: against 76cc546 this head changesiso/scripts/verify-selinux-store.sh(+60/−14: newimage-policymode,policy_rules/require_sameat lines 125–142, rule-by-rule compare inrequire_image_policy149–182),iso/scripts/lifecycle-e2e.sh(+17/−1: Phase 3image-policyat 735–738, Phase 4 probe/image-policyat 803–811) andtests/test_selinux_store.py(+133; 29 tests now pass). A maintainer trusting the body would skip exactly the code hanthor asked for. Suggested replacement for the Content paragraph:**Content:** #874's squash commit `76cc546`, plus e4df8a9 in reply to @hanthor's review: `verify-selinux-store.sh` gains an `image-policy` mode that compares the candidate's pristine compiled policy with the running policy type by type and TE rule by rule; `lifecycle-e2e.sh` runs it in Phase 3 before anything rebuilds the policy and re-checks store layout and image policy after rollback in Phase 4. One extra commit rewraps two paragraphs in `docs/skills/local-testing.md` to stay under `check-skill-frontmatter.sh`'s 500-line hard max. Locally the checker is clean and `tests/test_selinux_store.py` passes (29). -
Advisory, no action: the merge gate (booted update/rollback evidence) is already decided in #551 by @hanthor and carried by the
holdlabel; nothing in this PR can produce it and I did not run a VM either — host tests (29/29) and the frontmatter checker pass on e4df8a9.
style
- low —
docs/skills/local-testing.md:431-444: the new SELinux paragraph and the rewrapped baseline paragraph use 91–103-column lines while the rest of the page wraps at ~80, which is how the file was kept at exactly 500 lines under the hard cap. Widening lines to dodge the limit will not survive the next addition. Prefer trimming the paragraph (the detail already lives incontainerfile.md:236-275) or splitting the page.
No findings from: correctness, security, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Review on #894: the SELinux paragraph and the rewrapped baseline paragraph ran 91-103 columns to stay under the 500-line hard max. The SELinux note now points at the verifier's header and containerfile.md for detail, and the baseline paragraph is back to main's wrapping. The page stays at 500 lines, also when merged with current main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Addressed the review from 14:37:
🐝 Hive Agent: 🐝 Hive Agent: |
232a88d
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @Danathar, head
Hive did not add the |
|
hive-base-moved: merged 🐝 Hive Agent: |
There was a problem hiding this comment.
Summary: This change lets administrators of a Utah machine make lasting SELinux changes (turn a protection switch on for good, label a folder or network port, load a small local rule), which today fail because the policy store sits on a read-only part of the system. I read the whole change, the scripts it adds and the harness that drives them, and ran the unit tests (29 pass) and the docs checker (clean). I found nothing that should stop it; the remaining risk is exactly the booted-update evidence the PR is already held for, and I note two small gaps in what that evidence will and will not prove.
Reviewed at head b64cd2f (the merge of main on top of 232a88d; the PR moved after dispatch).
correctness
- info, in-scope. The harness only exercises the ISO install path, where the baseline's
/etc/selinux/targeted/has noactive/and the new image's store is taken whole (docs/skills/containerfile.md:270-274). A machine whose/etcalready carries atargeted/active/absent from its old/usr/etc(the X230 described in #551's latest comment) will have ostree copy those files over the candidate's store beforesemodule -N --refreshruns;require_image_policy(iso/scripts/verify-selinux-store.sh:134-168) would catch the result, but nothing iniso/scripts/lifecycle-e2e.sh:598-612can reach that state. READMEREADME.md:119-120already scopes this out ("kept, but not promised"), so no change needed here — only worth using that offered test bed as part of the hold evidence.
intent-alignment
- info, in-scope.
rejectmode (iso/scripts/verify-selinux-store.sh:244-266) proves thatsemodule -irefusing an invalid module leaves the store and running policy untouched. It does not exercise spec requirements 8–9 of #551 (a valid local module the next image's policy cannot satisfy makesostree-finalize-stagedfail and the update is skipped, with a findable record). #551 req 12 does not demand automating that, andREADME.md:103-112documents the manual recovery, so this is aligned with the contract as written — just name it when releasinghold, since @hanthor's acceptance line "a rejected local module leaves the system bootable" reads as the update-time case.
style
- low, out-of-scope.
docs/skills/local-testing.mdlands at exactly 500 lines, theMAX_HARDofscripts/check-skill-frontmatter.sh:7,80. The checker passes now, but the next one-line addition to that runbook fails CI. Consider moving the BLS/boot-files paragraphs (docs/skills/local-testing.md:390-431) into their own skill page in a follow-up.
No findings from: security, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Re-applies #874, which was reverted in #893. Held until the booted-update verification that @hanthor's decision on #551 requires.
Content: Re-applies #874's squash commit
76cc546plus the rule-by-ruleimage-policyverifier from e4df8a9. Phase 3 checks the candidate policy before any rebuilding command, and Phase 4 checks the restored store and policy. Merged currentmainatbbb16480c223e1199df8d0914c1395d57e0548a2; preserved its extracted lifecycle skill and moved SELinux guidance there. Follow-up review fixes capture finalization logs before a failing policy comparison and keep rejected-module residue checks inside the fixture store.Backend boundary: OSTree remains the default (#1130); composefs is opt-in (#1129). The verifier requires
/run/ostree-bootedbefore every supported mode, so it fails explicitly on other backends before using/usr/etc, reading OSTree finalization logs, or changing local policy. This is a verification guard, not an implementation of composefs persistence or policy refresh. The build-time store relocation is still common image content; composefs compatibility remains unproven and the hold stays in place.Local validation: SELinux fixture tests pass (32); skill checker tests pass (24), skill/catalog gates and shellcheck pass. The full
just checkrun has three failures in unchanged Ghostty tests because the hostcplacks--update=none. Podman, QEMU, pre-commit and/dev/kvmare unavailable here, so no booted update/rollback evidence is claimed.Why it's held: #874 merged on 2026-10-25T01:41Z, but
review_vmwas skipped on its head, so no booted update was run. #551 (reopened, also onhold) says not to merge a store relocation until that evidence exists.To release it: once backend-appropriate booted update and rollback evidence on an image built from this branch has passed the
iso/scripts/verify-selinux-store.shchecks this PR adds toiso/scripts/lifecycle-e2e.sh, or @hanthor accepts other evidence, a maintainer removesholdfrom this PR and from #551.Fixes #551
🤖 Generated with Claude Code
https://claude.ai/code/session_01SnzFs53Qcer1xDySyxv1Vj