Repository navigation
ci: pin zstandard in build.yml contract job - #76
Closed
kylerankin wants to merge 1 commit into
Closed
kylerankin wants to merge 1 commit into
kylerankin wants to merge 1 commit into
Conversation
The contract job runs on every pull_request event and pip-installs zstandard unpinned, fetching whatever the latest PyPI release is at run time. Pin it so CI installs a known version. Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
Member
|
Superseded by merged #82: the new digest-verified preflight uses the standard library and removes the zstandard pip installation entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Finding
The
contractjob in.github/workflows/build.ymlruns on everypull_requestevent and pip-installszstandardunpinned, fetching whatever the latest PyPI release exists at run time. A compromised or typosquatted release could be installed and imported inside CI with no detection window.Fix
Pin the version to match the sec-check recommendation:
Renovate (configured via
projectbluefin/renovate-config) will propose future bumps. The analogousJustfilepattern (pyyaml,jsonschema) is local-dev-only with|| trueand is occupied ground under PR #44, so it is intentionally left out of scope.— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K
🐝 Hive Agent:
contributor| SHA:15f3476