Skip to content

docs: keep CI workflow skill within page limit - #709

Closed
hanthor wants to merge 1 commit into
mainfrom
maintainer/ci-workflows-skill-limit
Closed

hanthor wants to merge 1 commit into
mainfrom
maintainer/ci-workflows-skill-limit

Conversation

@hanthor

@hanthor hanthor commented Oct 12, 2026

Copy link
Copy Markdown
Member

The testsuite reporting addition in #631 pushed docs/skills/ci-workflows.md over the 500-line hard limit enforced by test_check_skill_frontmatter. Condense the new section while preserving the exact-digest input and non-blocking behavior.

Verified: python3 -m unittest tests.test_check_skill_frontmatter.PassingPagesTest.test_real_skill_pages_pass and full just check pass.

The new testsuite reporting section pushed this page above the frontmatter validator hard cap. Condense its workflow and non-blocking outcome description without changing behavior.

Assisted-by: OpenAI Codex via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
github-actions Bot requested review from Danathar and daegalus October 12, 2026 18:59
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar, hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This takes docs/skills/ci-workflows.md from 502 to 498 lines. main's contract job currently fails on exactly that: test_real_skill_pages_pass reports "ci-workflows.md is 502 lines (hard max 500)", the only failure of 1081 tests (run 38295484276 at 931ef82).

The shortened paragraph keeps the facts that matter: the suite runs against each flavor's exact @digest, the suites come from scripts/flavors.py suites, and failures do not gate :testing promotion. It only drops the needs.resolve.outputs.digests detail. Approving at 60df3c0. #708 will need a rebase after this lands.

@hanthor

hanthor commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

Superseded by #713, which split the CI workflow guidance into linked references and merged after green contract, kernel-cache, preflight, and all four image-build checks.

@hanthor hanthor closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants