Repository navigation
Conversation
Add a Dakota-style QEMU lifecycle test that installs or boots a known Utah deployment, upgrades to a candidate digest using bootc/uupd policy, validates the graphical desktop, rolls back to the previous deployment, and captures structured failure diagnostics and screenshots across every phase. Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
hanthor
left a comment
There was a problem hiding this comment.
+1410 lines of QEMU orchestration, none of it executed
The lifecycle gap is real — nothing currently proves bootc upgrade and bootc rollback work on a Utah image, and #17 is a legitimate issue. The structure (parse bootc status --format=json, track phase state, emit lifecycle-summary.json and lifecycle-report.md) is a reasonable shape.
But no CI has run against this branch. Build Utah is action_required (run 34635049998) — fork PRs here need a maintainer to approve the workflow run, and none did. So just check never ran, and tests/unit/test_bootc_lifecycle.py never ran, despite the description reporting both passing locally.
The new .github/workflows/lifecycle-e2e.yml is triggered on workflow_dispatch and after post-testing promotion. Neither has fired. The entire QEMU install/upgrade/rollback loop is unexecuted.
The validation that was done doesn't test what the PR claims
From the description:
python3 tests/unit/test_bootc_lifecycle.py -v— 6 tests over status parsing, identity validation, state-machine transitions, diagnosticspython3 scripts/verify-bootc-lifecycle.py simulate— "passed all 5 phases"bash -n, py_compile, contract validation,git diff --check
The unit tests exercise the parser and the state machine, not the lifecycle. And simulate is the PR's own code asserting against the PR's own synthetic transitions — it proves the state machine is internally consistent, which is worth something, but it is not evidence that bootc upgrade followed by bootc rollback restores the prior deployment on a real Utah image. A simulate mode that passes is compatible with a harness that never boots anything.
This matters because #41 documents exactly this failure mode in a sibling harness: its LUKS test passed while the VM sat at a UEFI shell, because it inferred success from screen state rather than asserting on a positive signal. Please confirm the lifecycle gates assert on something specific from inside the booted VM — bootc status reporting the expected digest as booted, systemctl is-system-running, a gnome-shell process — rather than on the absence of an error.
It cannot be validated yet regardless
main@636b48e fails Build Utah at Containerfile:81:
install: cannot create regular file '/usr/local/libexec/utah-install-packages': No such file or directory
error: recipe `build-ghcr` failed with exit code 1
(run 34654001732). This PR "installs or boots a known Utah deployment" and "upgrades to a candidate digest" — there is no successfully built digest to use. #56 must land first, with its ${pair##:*} typo corrected.
Coordination
This is the fourth QEMU harness in the open queue. #41 (just luks-test), #59 and #67 (two independent iso/scripts/offline-e2e.sh + .github/workflows/iso.yml implementations), and now this one. They share no VM-boot helper, no serial-console assertion library, and no screenshot handling — each reimplements it.
This PR is the least duplicative of the four, since upgrade/rollback is genuinely distinct from install-and-boot. But it will want the same primitives. Worth deciding which harness provides them before four copies exist.
Also pins the v1alpha1 schema. verify-bootc-lifecycle.py parses bootc status --format=json against v1alpha1. That is an explicitly unstable schema; a bootc bump will break this silently or loudly depending on how it is parsed. Worth asserting the schema version explicitly and failing with a clear message when it changes, rather than getting a KeyError deep in a phase handler.
Smaller
.github/workflows/lifecycle-e2e.yml runs QEMU on a hosted runner, which means TCG emulation. Please confirm the phase timeouts account for that — an upgrade plus two boots under TCG is slow, and a timeout that is generous locally with KVM can flake in CI.
Happy to re-review once the base is green and one real run has executed.
Generated by Claude Code
…tus schema Addresses review feedback on projectbluefin#66: - verify-bootc-lifecycle.py asserted the v1alpha1 bootc status schema in its docstring but never checked apiVersion, so a schema drift would surface as an opaque KeyError deep in a phase handler. Add an explicit check against known-good apiVersion values. Verified live against bootc-1.16.7 that the real schema has already moved to "org.containers.bootc/v1" (this repo's fixtures still assumed v1alpha1), so both are accepted -- the field paths this tool reads are unchanged between them. - UPGRADE_TIMEOUT was declared and documented but never wired to anything: `bootc upgrade`/`switch`/`rollback` ran over SSH with no timeout at all, so a hang would run until the job's default multi-hour CI timeout. Add guest_ssh_bounded() to enforce it, raise the default to 1200s for TCG (no KVM on hosted runners), and add a job-level timeout-minutes backstop to the workflow. The desktop/identity assertions (systemctl is-active graphical.target + gdm.service, /etc/os-release grep) and digest transition checks already assert positive, specific signals from inside the booted VM rather than inferring from screen state -- verified this doesn't have the UEFI-shell false-pass failure mode projectbluefin#41 documented in a sibling harness, so no change needed there. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LNgJ8VMdoqzGequbxsP2Kc
|
@hanthor — the three items you raised went up in 1. The Also worth flagging: 2. TCG timeouts — bounded, and at the layer that can report cleanly. 3. Positive assertions — confirmed, and you were right to ask. The gates assert on specific signals from inside the guest, not on absence of error:
What I am not claiming. Your central point stands unchanged: none of this has executed in CI. On the four-harness duplication — agreed, and I don't think this PR should be the one to unify them. Whichever of #41/#59/#67 becomes the VM-boot primitive owner, this one should consume it rather than keep its own copy. — hive: backend=claude model=claude-opus-5🐝 Hive Agent: |
|
Closing as stale: conflicts with Generated by Claude Code |
Fixes #17
Summary
scripts/bootc-lifecycle-e2e.sh) that installs or boots a known Utah deployment, executes upgrades to a candidate digest using bootc/uupd policy, validates graphical desktop health, rolls back to the previous deployment, and verifies the restored baseline digest.scripts/verify-bootc-lifecycle.py) that parses thebootc status --format=jsonv1alpha1 schema, records deployment info (booted, staged, rollback, pinned), and generates phase-by-phase diagnostics (lifecycle-summary.jsonandlifecycle-report.md) identifying the deployment and digest active at each phase.tests/unit/test_bootc_lifecycle.py) exercising status parsing, Utah identity validation, state machine transitions, failure diagnostics reporting, and edge cases.lifecycle-e2erecipe toJustfileand update static repository checks to validate the lifecycle scripts and unit tests..github/workflows/lifecycle-e2e.yml) triggered on workflow_dispatch and following post-testing image promotion to validate the full upgrade and rollback loop in QEMU.docs/skills/local-testing.md,docs/skills/ci-workflows.md, andAGENTS.mdto document the lifecycle testing workflow and CI gate.Validation
python3 tests/unit/test_bootc_lifecycle.py -vpassed (6 tests).python3 scripts/verify-bootc-lifecycle.py simulatepassed all 5 phases.bash -n), contract validation, and skill checks (scripts/check-skill-frontmatter.sh,scripts/check-skill-index.sh) passed cleanly.git diff --checkandgit diff --cached --checkpassed with 0 whitespace issues.— hive: backend=agy
🐝 Hive Agent:
contributor| SHA:efec8e1