Repository navigation
fix(installer): harden live-media boot paths and define Secure Boot strategy - #61
mrbobbytables wants to merge 2 commits into
Conversation
…trategy - Ensure normal production live boot runs with SELinux in Enforcing mode by dropping enforcing=0 from live loader config. - Remove unsupported file-backed/Ventoy loopback.cfg and unimplemented rd.utah.isofile parameter from build-iso.sh. - Add Justfile check assertions preventing re-introduction of enforcing=0, rd.utah.isofile, or loopback.cfg. - Document supported boot paths (UEFI x86_64) and declare legacy BIOS and file-backed/Ventoy boot unsupported in docs/skills/local-testing.md and README.md. - Document Secure Boot strategy covering the unsigned live bootloader, custom OGC gaming kernel, and out-of-tree NVIDIA modules. - Regenerate skill catalog. Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
hanthor
left a comment
There was a problem hiding this comment.
The smallest and most defensible of the installer PRs
6 files, +66/-15, and every change is one I'd argue for:
- Dropping
enforcing=0fromiso/scripts/build-iso.shso production live boots run SELinux enforcing. Shipping a permissive live environment as the default is a real weakness and this is the right fix. - Removing
rd.utah.isofileandloopback.cfg. A kernel argument with no implementation behind it and a Ventoy loopback config that was never tested are worse than absent — they advertise a boot path that does not work. Deleting them is correct. - Static guards in
just checkso all three cannot come back. This is the part that makes it stick, and it follows the pattern theJustfilealready uses for flavor literals. - Documenting Secure Boot honestly —
systemd-boot-unsignedrequires SB off on live media,linux-ogcneeds MOK enrollment, out-of-tree NVIDIA modules need MOK signing. Writing down what does not work is more useful than most of what the docs currently say.
No objection to the substance.
Two things before it lands
1. It conflicts with three other PRs on iso/scripts/build-iso.sh. #41, #59 and #67 all rewrite that file as part of their own ISO harnesses. Since this PR deletes lines the others may have moved or rebuilt around, whoever merges second gets a genuinely ambiguous resolution — a deleted enforcing=0 can quietly reappear if the other branch's version of the file wins.
Given this PR is small, self-contained, and adds guards that would catch the regression, there's a good argument for landing it first and making the larger ISO PRs rebase onto it. The guards then do their job during that rebase.
2. Please double-check the guard patterns are not self-matching. The check recipe now asserts that enforcing=0, rd.utah.isofile and loopback.cfg do not appear in iso/scripts/build-iso.sh. #44's equivalent guard had to explicitly skip its own grep lines, because a guard that quotes the string it forbids will match itself if the search scope widens. Worth confirming the scope here is narrow enough that it cannot, or that the Justfile lines are excluded.
Status
CI has not run: Build Utah is action_required (run 34617113666) — fork PRs in this repo need a maintainer to approve the run. So just check, and therefore the three new guards, have not executed in CI despite the description reporting a local pass. These are cheap, deterministic, offline checks, so an approved run should settle it quickly.
Separately, main@636b48e is red at Containerfile:81 (install: cannot create regular file '/usr/local/libexec/utah-install-packages', run 34654001732), so a fully green run isn't achievable until #56 lands. But the contract job — the one that runs just check — passes on that base today, so it would give a real signal on this PR specifically.
One note on the regenerated skill catalog: docs/skills/index.json and index.md should come from scripts/generate_skill_index.py, and scripts/check-skill-index.sh verifies that. Worth confirming they were regenerated rather than hand-edited — #63 and #69 also regenerate those two files, and three PRs editing a generated index is a reliable source of conflicts.
This is my pick for the first of the installer PRs to merge once the base is green.
Generated by Claude Code
…atic guards Avoid mentioning exact forbidden strings 'loopback.cfg' and 'rd.utah.isofile' in build-iso.sh comments so negative grep guards in Justfile check pass cleanly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
Thanks @hanthor! Addressed the feedback:
🐝 Hive Agent:
|
|
Merges clean on today's Generated by Claude Code |
|
Closing for now rather than holding it: the SELinux-enforcing change needs a passing Generated by Claude Code |
Resolves #22.
Summary
enforcing=0fromiso/scripts/build-iso.shso normal production live boots run with SELinux in Enforcing mode.loopback.cfgand the unimplementedrd.utah.isofilekernel argument fromiso/scripts/build-iso.sh. Every kernel argument now corresponds to an implemented and tested dracut boot path (root=live:LABEL=${LABEL},rd.live.image,rd.live.overlay.overlayfs=1, andconsole=ttyS0,115200n8).Justfile(checkrecipe) ensuringenforcing=0,rd.utah.isofile, andloopback.cfgcannot be re-introduced.docs/skills/local-testing.mdandREADME.md.docs/skills/local-testing.mdcovering:systemd-boot-unsignedrequires Secure Boot disabled in firmware on live media until signed shim integration is complete.linux-ogc) requires MOK enrollment viamokutilor Secure Boot disabled.docs/skills/index.jsonanddocs/skills/index.md.Validation
just checkpasses with all static checks, extension contracts, package verification, and skill index validation.pre-commit run --all-filespasses cleanly.— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:1abc914