Repository navigation
feat(pixmaps): use the accepted Utah wordmark in GDM - #531
Conversation
Co-authored-by: delphicmelody <216445466+delphicmelody@users.noreply.github.com>
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
HUMAN DECISION NEEDED — @KiKaraage confirm this 150x64 PNG is the sanctioned new Bluefin wordmark and that Utah should switch ahead of common (PR body: "try doing the logo switch early").
intent-alignment
- PR body says Utah's copy diverges from
common;docs/skills/desktop-contract.md:182still describes the file as "a copy ofcommon'sfedora-gdm-logo.png". After this PR that is no longer true — a maintainer should decide whether to carry a Utah-only asset or land it incommonfirst.
docs-currency
docs/skills/desktop-contract.md:180states the logo is "150x61"; new asset at head 7bd3220 is 150x64 (IHDR). Line 182 "copy ofcommon's" also stale. Update both.
No findings from: correctness, security, style. (PNG well-formed: IHDR/sRGB/pHYs/IDAT/IEND, no trailing data; satisfies tests/test_desktop_contract.py:503-505 cap of 256x128; contract CI job green.)
Confidence: 3/5 (needs attention) — 1 perspective requires a human decision
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
Thanks for this. Two things before it can merge:
- Maintainer decision:
commonstill ships the 150x61fedora-gdm-logo.png(unchanged since cc74c4e). This PR makes Utah's greeter logo diverge from Bluefin. Utah normally followscommonfor artwork, so please confirm this is the sanctioned new wordmark. Also say whether it should land inprojectbluefin/commonfirst, so that Utah's copy stays a copy. - Docs:
docs/skills/desktop-contract.md:286-288says the asset is "a 150x61 Bluefin wordmark ... a copy ofcommon'sfedora-gdm-logo.png", and:293repeats the 150x61 figure. Update both to the new 150x64 size, and drop the "copy of common" claim if Utah carries its own asset. Bump the skill'slast_updatedtoo.
The PNG itself is fine: it is well-formed, under the 256x128 test cap, and contract is green.
🤖 Generated with Claude Code
…drop copy-of-common reference
|
Pushed doc fixes per review feedback: updated |
There was a problem hiding this comment.
docs-currency
system_files/shared/etc/dconf/db/gdm.d/01-bluefin-gdm-logo:14-18still describes the asset as "150x61" and "a copy of Common's Bluefin-branded fedora-gdm-logo.png". This PR replaces the PNG (now 150x64, new artwork) and removed exactly that claim fromdocs/skills/desktop-contract.md:180-182, so the keyfile comment is now the only stale description of the shipped logo. Update it to match.
No findings from: correctness, security, intent-alignment, style.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Maintainer architectural decision on hanthor review item 1: The GDM wordmark will land directly in |
Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io>
There was a problem hiding this comment.
docs-currency
- low —
docs/skills/desktop-contract.md:187-188now states "Bluefin-LTS keeps the greeter logo small by using a 150x64 wordmark". The old text cited a concrete upstream file (common's 150x61fedora-gdm-logo.png); the new sentence attributes Utah's new 150x64 asset to Bluefin-LTS without evidence in this PR. Suggest either dropping the Bluefin-LTS attribution or citing where that image comes from.
Verified at d62f2b4: shipped PNG is a valid 150x64 PNG (within the 256x128 cap in tests/test_desktop_contract.py:504-505); keyfile active lines unchanged (01-bluefin-gdm-logo, comment-only edits).
No findings from: correctness, security, intent-alignment, style.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Merge current main without reverting the service documentation. Distinguish the accepted Utah 150x64 artwork from Common’s 150x61 asset instead of claiming they share dimensions. Assisted-by: GPT-6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hanthor
changed the title
hanthor
left a comment
hanthor
left a comment
There was a problem hiding this comment.
The maintainer accepted Utah’s proposed wordmark. At c810b49, the desktop contract and GDM keyfile describe Utah’s 150x64 asset accurately without claiming it is Common’s 150x61 asset or an upstream Bluefin-LTS size. Contract and image checks pass; the remaining kernel build must finish before merge. This resolves my earlier requested changes. Because I pushed the repaired head, repository last-push rules still require another maintainer’s approval.
Danathar
left a comment
Danathar
left a comment
There was a problem hiding this comment.
Approving at c810b49 (hanthor's approval doesn't count because he pushed the last commit). The PNG is 150x64, the dconf comment and desktop-contract.md follow, and castrojo accepted the wordmark on 10-06. tests.test_desktop_contract passes at this head. One ordering note: this branch is behind main, and main's contract job is currently red on the 510-line package-contract.md; #485 fixes that, so merging #485 first keeps this one green.
Just wanna try doing the logo switch early (especially since Utah currently have its own copy of the logo, rather than consuming directly from common repo)