Repository navigation
fix(configure-services): stop claiming Utah images are rechunked - #211
kylerankin wants to merge 4 commits into
Conversation
scripts/configure-services.sh says Utah rechunks with chunkah through projectbluefin/actions' reusable-build. It does not: the reusable workflow's testing-stream guard skips the rechunk (and SBOM) steps, and Utah publishes only the testing stream, so its images are never rechunked (projectbluefin#131). The rechunker-group-fix.service unit is still removed, but for the reason the next paragraph already gives -- it breaks the boot via a systemd job cycle -- not because of any rechunk claim. Correct the comment so it stops asserting a behavior the build does not perform; the real fix needs a reusable-workflow input (projectbluefin#131) and lives in projectbluefin/actions. Assisted-by: Pi (lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K) Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
There was a problem hiding this comment.
docs-currency
- The PR removes the false "Utah rechunks with chunkah" claim from
scripts/configure-services.sh:40-42, butdocs/skills/ci-workflows.md:39at head65067e2still states CI delegates "rechunking" toprojectbluefin/actions@v1— the same claim #131 says is false for Utah'stesting-only stream. If the goal is "stop claiming Utah images are rechunked," this doc line should be corrected in the same pass (severity: low).
No findings from: correctness, security, intent-alignment, style.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
ci-workflows.md:39 still listed rechunking as delegated to projectbluefin/actions@v1 -- the same false claim configure-services.sh projectbluefin#211 removes. Utah publishes only the testing stream, and the reusable workflow's testing-stream guard skips the rechunk step (projectbluefin#131), so its images are never rechunked. Correct the doc in the same pass. Addresses the low docs-currency finding in projectbluefin#211.
@(cat /tmp/c211.md)🐝 Hive Agent: |
There was a problem hiding this comment.
docs-currency
docs/skills/ci-workflows.md:38-39 still lists SBOMs (and vulnerability reporting) as delegated to projectbluefin/actions@v1, while the note this PR adds at lines 42-45 says the testing-stream guard skips "the rechunk (and SBOM) steps" — and per #131 Utah only ever builds the testing stream, so SBOMs are never produced either. The edit removed "rechunking" from that sentence but left "SBOMs", making the paragraph contradict the note directly beneath it.
style
docs/skills/ci-workflows.md:44 — "the same claim this PR removes from scripts/configure-services.sh" is self-referential; once merged there is no "this PR" for a reader. Prefer citing the commit or just stating the fact.
No findings from: correctness, security, intent-alignment.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
…mention The testing-stream guard in projectbluefin/actions@v1 skips both the rechunk and SBOM steps (projectbluefin#131), and Utah publishes only the testing stream, so SBOMs are never produced. Keeping "SBOMs" in the delegated list contradicted the note directly beneath it. Also replace the "this PR" reference, which goes stale once merged, with the standing fact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
docs-currency
packages/utah.toml:271still asserts the image "has to survive an OCI export and a rechunk on a runner". This PR's stated purpose is to stop claiming Utah images are rechunked (#131), and it fixesscripts/configure-services.sh:41anddocs/skills/ci-workflows.md:41-45, but this remaining claim of the same kind was left intact.
No findings from: correctness, security, intent-alignment, style.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
The CUDA size argument in packages/utah.toml still said the closure would have to survive an OCI export and a rechunk on a runner. Utah publishes only the testing stream, where the reusable workflow skips the rechunk step (projectbluefin#131), so no Utah image is ever rechunked. State the real cost -- building and pushing from a runner that already freed disk for the kernel build -- so the manifest matches the rest of the cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Addressed the remaining style nit: rephrased the self-referential "this PR removes" wording in the rechunk/SBOM note (ci-workflows.md) to state the fact directly, which reads correctly after merge. The SBOM/rechunk content findings from the earlier hive reviews were already corrected in the prior commit.🐝 Hive Agent: |
|
Closing as duplicate/superseded: the accurate documentation of Utah testing stream rechunking behavior and reusable-build workflow pin is implemented in #205. |
Problem
#131: Utah images are never rechunked. The reusable workflow in
projectbluefin/actionsskips the rechunk (and SBOM) steps wheneverinputs.stream_name == 'testing', and Utah publishes only thetestingstream, so every published image skips rechunking.
This change
The real fix needs a
rechunkinput on the reusable workflow and lives inprojectbluefin/actions. Until then,scripts/configure-services.shkeepsclaiming the image is rechunked through chunkah -- which is false. This corrects
that comment so it stops asserting a behavior the build does not perform. The
rechunker-group-fix.serviceunit is still removed, for the boot-cycle reasonthe next paragraph already gives, not for any rechunk claim.
The maintainer noted this Utah-side half was meant to ride the image-size PR
(#156), which merged without it, so it remains outstanding.
Not done here
which lives in
projectbluefin/actions-- out of scope for this repo.— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K
🐝 Hive Agent:
contributor| SHA:65067e2