Repository navigation
fix(ci): gate on dracut errors and enable Trivy RPM scanning - #157
mrbobbytables wants to merge 0 commit into
Conversation
…have (#184) kernel_cache built the kernel and then unconditionally pushed the cache to ghcr.io, which a pull request from a fork can never be allowed to do: Error: writing blob: initiating layer upload to /v2/projectbluefin/utah-kernel-cache/blobs/uploads/ in ghcr.io: denied: installation not allowed to Write organization package The build itself succeeded; the job failed at the final push, roughly 45 minutes in, discarding a correct result. Two fork PRs from different contributors hit this: #158 and #157. kernel_cache now exposes an `available` output and gates only the push behind CAN_PUBLISH, leaving the build unconditional so a fork PR still builds and validates the kernel. build_kernel requires kernel_cache.outputs.available so nothing downstream consumes a cache that was never published.
castrojo
left a comment
There was a problem hiding this comment.
Reviewed diff: gates on dracut errors, Trivy RPM scanning, and Hummingbird GPG signatures. Currently has merge conflicts and fork kernel_cache write failures. Needs rebase by author.
castrojo
left a comment
There was a problem hiding this comment.
Merged latest main into branch: resolved conflicts in iso/live/Containerfile, packages/hummingbird.repo, and tests/test_iso_ci.py, regenerated skill catalog, and pushed update. Awaiting independent review.
There was a problem hiding this comment.
Reviewed at head 972ab60 (the dispatched SHA 3e14a7e was superseded by one reconciliation commit that fixed a then-failing test assertion).
intent-alignment
- The PR body claims item 3 "enables
gpgcheck=1" inpackages/hummingbird.repowithgpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-hummingbird-release. The diff does not touch that file, andmainalready shipsgpgcheck=1withgpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release-2(packages/hummingbird.repo:16-17). This PR only adds a test asserting pre-existing state — no signature-verification behavior changed. - The body also claims the skill catalog was regenerated;
docs/skills/index.json/index.mdare unchanged in the diff (harmless, since the index is built from frontmatter only, but the claim is inaccurate).
docs-currency
- docs/skills/package-contract.md:102-103 (added by this PR) says signatures are verified "using Hummingbird's published release key (
file:///etc/pki/rpm-gpg/RPM-GPG-KEY-hummingbird-release)". That path does not exist; the actual key isfile:///etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release-2(Red Hat release key 2 — see packages/hummingbird.repo:10-17). The reconciliation commit fixed the same wrong path in tests/test_package_resolution.py but left the doc stale.
style
- iso/live/Containerfile:69-71 now runs
mkdir -p /var/roothomeand thenmkdir -m 0700 -p /var/roothome. The second call is redundant and-m 0700has no effect on an already-existing directory, so the PR body's "0700" claim doesn't actually hold (benign — the dir isrmdir'd after the build). - New
RepositoryPolicyTests.test_hummingbird_repository_enforces_gpg_signatures(tests/test_package_resolution.py:292-296) duplicates the stronger pre-existingtest_hummingbird_packages_are_signature_checked(same file, L276-284), which also verifies the key file and its COPY into the image.
No findings from: correctness, security.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
|
Two things here look like real defects rather than style. The Hive reviewer flagged both as well, but I reproduced them myself rather than taking that on faith. 1. The 0700 on In Dropping the earlier line should be enough. 2. The GPG key path in the docs does not exist.
Related: the PR says it enables gpgcheck for the Hummingbird repo, but Everything else in the dracut error gating and the Trivy RPM scanning reads fine to me. There is also a live merge conflict against current main, so this will want a rebase regardless. |
There was a problem hiding this comment.
docs-currency
- The PR body claims the skill catalog was regenerated, but
docs/skills/index.jsonis not in the diff. It carries per-skilllast_updatedstamps (e.g.desktop-contractat2026-09-18), now stale for the three skills this PR edits (desktop-contract.md,local-testing.md,package-contract.md). Regenerate/update the catalog to match.
style
tests/test_iso_ci.py:187(test_live_initramfs_gates_on_dracut_errors_and_prepares_roothome) restates the same Containerfile string assertions as the updatedtests/test_package_resolution.py:286(test_live_initramfs_build_fails_on_a_dracut_error): both checkmkdir -m 0700 -p /var/roothomeand thedracut\[E\]grep. The body notes a duplicate test was removed; this adds another overlapping pair — consider keeping the checks in one place.
Verified against head 3d9bdfe: the packages/hummingbird.repo gpgcheck/key claims in docs/skills/package-contract.md match the repo file (gpgcheck=1, RPM-GPG-KEY-redhat-release-2), the /etc/fedora-release relative symlink target in scripts/configure-branding.sh:74 is correct, and the dracut gate broadening plus sysloglvl=0 matches the intent of #132.
No findings from: correctness, security, intent-alignment.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
|
Re-checked after 3d9bdfe and 491ca0d (diffed against 972ab60, the head I reviewed). Both things I raised are fixed:
Local run at 491ca0d: I can't approve yet, for two reasons. The branch conflicts with main in |
hanthor
left a comment
There was a problem hiding this comment.
Requesting changes: PR is conflicting with no CI reported. Please rebase first, then address review findings.
491ca0d to
0fbaa6d
Compare
Summary
Addresses image and live ISO build errors identified in #132:
/rootis a symlink to/var/roothome, which does not exist during container build time, causingdracut-install -f /root /rootto fail. We create/var/roothome(0700) before runningdracut. In addition,sysloglvl=0is set to silence container/dev/logwarnings,--stdlog 4is passed, and dracut output is monitored withset -o pipefailto fail closed if anydracut[E]errors occur — dracut exits 0 even when it logs a failed install, which is how the broken initramfs shipped in the first place.os-releaseand lacks anetc/fedora-releasefallback. We write/usr/lib/fedora-releasewithFedora release ${FEDORA_MAJOR_VERSION}and symlink/etc/fedora-release, allowing Trivy to identify the OS family as Fedora and scan installed RPMs against upstream CVE data. We also add/usr/lib/fedora-releasetocontracts/bluefin-desktop.tomland verify it in tests.tests/test_desktop_contract.py,tests/test_package_resolution.py, andtests/test_iso_ci.py, updated relevant skills indocs/skills/, and regenerated the skill catalog.docs/skills/package-contract.mdnow documents the Hummingbird repository's existing signature verification against the key it actually uses,packages/RPM-GPG-KEY-redhat-release-2(Red Hat release key 2, key ID199e2f91fd431d51).Not in this PR: an earlier revision of this description claimed
gpgcheck=1was being enabled inpackages/hummingbird.repowith aRPM-GPG-KEY-hummingbird-releasekey. That was wrong on both counts — signature verification has been enforced onmainsince before this branch, against the Red Hat release key — and the claim, the wrong key path in the docs, and the duplicate test that restated the existingtest_hummingbird_packages_are_signature_checkedassertions have all been removed.Closes #132
— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:55a768e