Skip to content

fix(desktop): enable input-remapper.service for desktop input devices - #148

Merged
hanthor merged 1 commit into
projectbluefin:mainfrom
mrbobbytables:fix/input-remapper-service
Sep 22, 2026
Merged

hanthor merged 1 commit into
projectbluefin:mainfrom
mrbobbytables:fix/input-remapper-service

Conversation

@mrbobbytables

Copy link
Copy Markdown
Contributor

Problem

input-remapper is installed by Bluefin's package set, but its systemd service (input-remapper.service) was never enabled by any preset. Consequently, during boot udev autoload hooks fail with exit code 5 across all input devices, and launching the input-remapper-gtk GUI falls back to prompting for root credentials via polkit because it cannot communicate with a running daemon. See #99.

Solution

  • Enable input-remapper.service in scripts/configure-services.sh alongside the other desktop services.
  • Add enable input-remapper.service to system_files/shared/usr/lib/systemd/system-preset/85-utah-desktop.preset so bootc's first-boot preset application does not undo the enablement.
  • Track input-remapper.service in contracts/bluefin-desktop.toml under [services].enabled so the runtime desktop contract and in-image verifier assert it.
  • Update docs/skills/desktop-contract.md and regenerate the skill index (index.json / index.md).
  • Add DesktopUnitEnablementTests to tests/test_package_resolution.py to enforce agreement between build-time service enablements and preset directives.
  • Add test_shipped_contract_enables_input_remapper to tests/test_desktop_contract.py.

Closes #99.

— hive: backend=copilot model=gemini-3.8-flash

🐝 Hive Agent: contributor | SHA: fbbdbb0

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78

hanthor
hanthor previously approved these changes Sep 19, 2026

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Same shape as #125, which just merged, and complete in the same way: the unit is enabled in configure-services.sh, the matching enable is in 85-utah-desktop.preset so bootc's first-boot preset application does not undo it, and contracts/bluefin-desktop.toml lists it so the in-image verifier asserts it.

The DesktopUnitEnablementTests class is the part worth having beyond this one unit: holding the script and the preset in agreement is what stops the next unit being added to one and not the other, which is exactly how #98 and #99 happened. Keeping sshd out of it with the reason recorded is correct, since configure-services.sh rewrites the preset in place for the opt-in debug build.

This supersedes the input-remapper hunk in my #105; I will drop it there so the two do not race, as I did for bluetooth.

CI is green.


Generated by Claude Code

@hanthor

hanthor commented Sep 19, 2026

Copy link
Copy Markdown
Member

Approved above, but it cannot merge yet: #125 (bluetooth) and #137 (the fastfetch OCR gate) landed a few minutes ago and this now conflicts with main. GitHub's update-branch cannot resolve it automatically, and this branch is on a fork, so it needs you rather than me.

The conflicting files should all be mechanical:

My approval stands once it is green again, and I will merge it then.


Generated by Claude Code

@hanthor

hanthor commented Sep 19, 2026

Copy link
Copy Markdown
Member

Still blocked on one conflict, and it is smaller than it looks. I merged main into this head locally: contracts/bluefin-desktop.toml, scripts/configure-services.sh, 85-utah-desktop.preset, tests/test_desktop_contract.py and the skill index all auto-merge. The only conflict is docs/skills/desktop-contract.md.

#153 extended the [services] bullet in that file with the bootc-fetch-apply-updates masking policy, and this branch adds input-remapper.service to the same bullet. Keep both: main's masking sentences plus your added unit in the enabled list.

Push that and I will merge — this has been approved and green for a while and nothing else stands in its way.


Generated by Claude Code

@Danathar

Copy link
Copy Markdown
Contributor

Approved and only blocked on the conflict from this morning's merges (#125 landed bluetooth.service in the same places). Resolution when you merge main in: docs/skills/desktop-contract.md — the unit list should name both, bluetooth.service and input-remapper.service; then python3 scripts/generate_skill_index.py --write for index.json/index.md. 85-utah-desktop.preset, configure-services.sh and contracts/bluefin-desktop.toml auto-merge cleanly with both units present.

@mrbobbytables

Copy link
Copy Markdown
Contributor Author

Merged upstream/main in commit c2d9e79, resolving the conflict in docs/skills/desktop-contract.md by preserving both bluetooth.service and input-remapper.service, and regenerated the skill catalog.

🐝 Hive Agent: contributor | SHA: unknown

Danathar
Danathar previously approved these changes Sep 19, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at c2d9e79 after the merge with main (hanthor's approval was dismissed by the push). What I checked: both bluetooth.service (from #125 on main) and input-remapper.service (this PR) are present in 85-utah-desktop.preset and configure-services.sh, the desktop-contract doc lists both, and the net diff against main is only this PR's change plus its tests. All 14 checks green. Closes #99.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78

input-remapper is installed by Bluefin's package set, but its systemd unit was never enabled. Consequently, udev autoload hooks fail on all input devices at boot (exit code 5) and launching the input-remapper GUI prompts for root credentials via polkit because it cannot communicate with a running daemon.

Enable input-remapper.service in scripts/configure-services.sh alongside the other desktop units, add enable input-remapper.service to the desktop preset (85-utah-desktop.preset) so first-boot preset application does not undo the build-time enablement, and track input-remapper.service in the runtime desktop contract (contracts/bluefin-desktop.toml) and skill docs. Add DesktopUnitEnablementTests in tests/test_package_resolution.py to guard against units enabled without matching preset directives.

Closes projectbluefin#99.

Assisted-by: Gemini 3.8 Flash via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from correctness, security, intent-alignment, style, docs-currency.

— hive: agent=reviewer backend=copilot model=claude-fable-5

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased fork branch on origin/main, restored bootc service mask docs, regenerated skill catalog, and pushed to author fork. contract and build_main CI jobs have completed successfully. Awaiting completion of kernel_cache and approval from an independent maintainer to land.

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving at a5cde1c. My approval at c2d9e79 was dismissed when castrojo rebased this onto main. I re-diffed the PR's own patch at both SHAs: contracts/bluefin-desktop.toml, configure-services.sh, 85-utah-desktop.preset and both test files are unchanged apart from hunk context. The one difference is in docs/skills/desktop-contract.md: the rebase kept main's [services] bullet, so input-remapper.service is no longer named in that enumerated unit list (the prose at line 103 still mentions it). That is a doc omission, not a functional change, and nothing tests it, so I am not blocking on it; a one-word follow-up would restore it. python3 tests/run_suite.py at a5cde1c passes (288 tests, 1 skipped) and all CI checks are green.

@hanthor
hanthor merged commit 415ee13 into projectbluefin:main Sep 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

desktop: input-remapper.service never enabled, GUI falls back to password prompt

4 participants