Repository navigation
Conversation
Dakota ships open-iscsi and open-isns, so Utah installs iscsi-initiator-utils and isns-utils from the factory, with every unit off. 85-utah-desktop.preset already carries Dakota's 50-iscsi.preset. Fedora's package adds iscsi-starter.service and iscsi-onboot.service, and Hummingbird's 90-default.preset enables both, so the preset now disables them as well. The contract's disabled list asserts all nine units. clean-stage strips /var, so tmpfiles.d/utah-iscsi.conf recreates the node database directories with the RPMs' modes and policy labels. nicstat is now published by the pinned factory and installed. umotd is waived: uwelcome is Utah's terminal greeting, and bluefin-cli works through it (#1370). erofs-utils stays planned, blocked on libqpl (projectbluefin/utah-packages#1238). Closes #1360. Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Summary: This change adds tools for attaching network storage disks (iSCSI) and a network-statistics tool to Utah, keeps all of the storage services switched off by default as Dakota does, and formally drops a duplicate login-greeting tool. It matches the agreed decision. One small gap: the test list that checks "all of these services are off" leaves out one of the ten services the change switches off, so that service could be turned on later and nothing would catch it.
What I need from you: Add the one missing line shown in the inline comment.
intent-alignment
contracts/bluefin-desktop.toml:799: the contract lists 9 units, but85-utah-desktop.preset:28-40disables 10.isnsd.socket(line 35) is the one left out. The decision on #1360 says "The desktop contract asserts the full set is disabled". Fedora'sisns-utilsshipsisnsd.socketbesideisnsd.service, and GAP.md counts 2 system units for open-isns. Adding it is safe:scripts/verify-desktop-contract.py:115acceptsnot-found, so the check does not fail if the unit is absent. The fix is inline. Optionally add it to the unit tuple intest_iscsi_units_ship_disabledtoo, and change "all nine" to "all ten" indakota-services.md.
Not verified: I did not build the image. I took the Fedora unit list from my knowledge of the package spec, not from the RPM at the factory pin.
No findings from: correctness, security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
-- hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327
| "iscsid.socket", | ||
| "iscsiuio.service", | ||
| "iscsiuio.socket", | ||
| "isnsd.service", |
There was a problem hiding this comment.
isnsd.socket is disabled in 85-utah-desktop.preset:35 but is not asserted here. Per #1360 the contract should assert the full set. Absent units pass (verify-desktop-contract.py:115 accepts not-found), so adding it is safe.
| "isnsd.service", | |
| "isnsd.service", | |
| "isnsd.socket", |
|
@hanthor this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Follow-up to #1367, covering what is left of #1360.
iSCSI / iSNS. Dakota ships open-iscsi and open-isns. Utah now installs
iscsi-initiator-utilsandisns-utilsfrom the factory with every unit off.85-utah-desktop.presetalready carries Dakota's50-iscsi.preset. Fedora's package addsiscsi-starter.serviceandiscsi-onboot.service, and Hummingbird's90-default.presetenables both, so the preset now disables them too.disabledlist asserts all nine iSCSI/iSNS units./var, sotmpfiles.d/utah-iscsi.confrecreates/var/lib/iscsiand/var/lib/isnswith the RPMs' modes and policy labels.nicstat is now published by the pinned factory, so it is installed.
umotd is waived. uwelcome is Utah's terminal greeting, and bluefin-cli works through it (#1370).
erofs-utils stays planned, blocked on libqpl (projectbluefin/utah-packages#1238).
Counts and site data were regenerated on top of #1367: 57 base, 354 Utah additions, 9 unavailable.
Verified on this exact tree:
umask 022; just checkandjust check-reposboth passed.Decision: #1360 (comment)
Closes #1360. Part of #1236.
Assisted-by: Claude Opus via GitHub Copilot