Repository navigation
chore(deps): update projectbluefin/actions digest to 3ab4328 - #1349
mergeraptor[bot] wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Needs approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. ℹ️ Sentinel: informational, author is trusted (allow-listed bot), merge is not blocked. Head
No |
There was a problem hiding this comment.
This bump is one line short, and that is why contract is red.
tests/test_release_trigger.py:522-526 asserts that execute-release.yml's execute job uses the SHA stored in RETAG_NAMES_VERIFIED_AT (scripts/release-trigger.py:98). This PR moves the job to 60c9845 but leaves the constant at 75348af:
AssertionError: '60c9845049b89b668a5704ca472b165845a253d0' != '75348afb3a34c6006a3d3da51e51c9a3818b2616'
The guard is doing its job. Per the comment at release-trigger.py:95-97, someone has to re-check the job and step names before moving it. I did that check. In projectbluefin/actions .github/workflows/reusable-execute-release.yml, name: Promote release (line 185) and - name: Promote digests to target tags (line 239) are identical at 75348af and 60c9845. The only change to that file in the range is the testsuite e2e pin at line 177. So the fix is safe:
-RETAG_NAMES_VERIFIED_AT = "75348afb3a34c6006a3d3da51e51c9a3818b2616"
+RETAG_NAMES_VERIFIED_AT = "60c9845049b89b668a5704ca472b165845a253d0"scripts/release-trigger.py is not in this diff, so I could not attach this to the line. It needs a commit on the Renovate branch or a follow-up PR. Everything else in the bump looks correct. The upstream range is 2 fast-forward commits that only bump third-party SHA pins at patch level and fix the consumer-contract checker.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
-- hive: agent=reviewer-2 backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327
🐝 Possible duplicateThis PR changes exactly the same files as #1277, which was opened first:
Evidence — identical changed-file set (4 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
a2d1498 to
1a7f6da
Compare
There was a problem hiding this comment.
Summary: This automated update moves the project's build and release pipelines to a newer version of the shared workflow library they borrow from. The new version itself looks safe: it only bumps a few helper tools. But one safety check still records the old version, so the automated tests fail and the update cannot merge as it is.
What I need from you: Bump one constant on main (diff below); the bot's next run will carry it into this PR.
Re-review of head 1a7f6da (delta since a2d1498). The delta re-points the same five uses: pins to 2463703. The testsuite pin (570922f) and the wallpapers digest come in from main, not from this PR.
correctness
Previous finding - RETAG_NAMES_VERIFIED_AT not bumped: still present.
scripts/release-trigger.py:98still says75348afb…..github/workflows/execute-release.yml:127now pinsreusable-execute-release.yml@2463703f….tests/test_release_trigger.py:526compares the two values. Thecontractjob on this head (Validate manifestsstep) fails with:
AssertionError: '2463703fd33dc4f11924ea9a99d98b0cb1b88838' != '75348afb3a34c6006a3d3da51e51c9a3818b2616'
I checked the job and step names at 2463703: execute: is still name: Promote release (line 185), and the step is still Promote digests to target tags (line 239). These match RETAG_JOB/RETAG_STEP (scripts/release-trigger.py:99-100), so bumping the constant is safe. Apply this on main:
-RETAG_NAMES_VERIFIED_AT = "75348afb3a34c6006a3d3da51e51c9a3818b2616"
+RETAG_NAMES_VERIFIED_AT = "2463703fd33dc4f11924ea9a99d98b0cb1b88838"Lasting fix: have Renovate bump this constant in the same group as the projectbluefin/actions pin, so every digest PR does not hit this test.
Upstream 75348af..2463703 changes only pinned helper actions (taiki-e/install-action v2.90.6, oras-project/setup-oras v2.0.4) and the testsuite pin inside reusable-execute-release.yml. It adds no new permissions, secrets or triggers.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
-- hive: agent=reviewer backend=claude model=claude-opus-5-5 effort=medium claude=2.1.327
1a7f6da to
3b9bcac
Compare
This PR contains the following updates:
75348af→3ab4328Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.