Repository navigation
Conversation
…op containerd Install qemu-kvm, qemu-guest-agent, spice-vdagent, open-vm-tools, hyperv-daemons and toolbox (systemd-container was already in), all published by the factory. libvirt and virtiofsd are pending factory imports (utah-packages#1021, #1147) and go in [unavailable] so check-repos flags them once published. Dakota's presets are already carried: 80-libvirt.preset's disables live in 98-utah-enable-default.preset and its guest-agent enables follow from enable-by-default; the contract now asserts vmtoolsd and qemu-guest-agent enabled and libvirt's sockets off. `ujust setup-virtualization` and `manage-virtualization` run Dakota's files/just-overrides/devmode.py, shipped verbatim as /usr/libexec/dakota-devmode, and explain the missing libvirt until it lands. containerd and runc are excluded; podman runs on crun. Closes #1232 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Withdrawn: this PR is not back in your court after all. The failing checks ( |
Member
Author
|
Folded into the part-2 landing PR (fold/dakota-sq) with this change unchanged apart from rebase and conflict resolution. Closing here; review continues there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts Dakota's virtualization set (owner decision on #1232), as far as the factory publishes it today.
What changed
packages/utah.toml[parity]addsqemu-kvm,qemu-guest-agent,spice-vdagent,open-vm-tools,hyperv-daemonsandtoolbox.systemd-containerwas already in. The factory image publishes all six; Hummingbird's own repository carries none of them.libvirt-daemon-kvm,libvirt-daemon-config-network,libvirt-clientandvirtiofsdgo into[unavailable], sojust check-reposflags them once they publish.devmode.pydrives: the modularvirt*ddaemons, the default NAT network it binds to thelibvirtfirewalld zone, andvirsh.containerdis gone from[fedora].containerdandruncmove to[excluded]; runc only ever came in as containerd's dependency, and podman runs on crun, as on Dakota. Thedisable containerd.serviceline in the 98 preset is now dead and is gone too.80-*presets into98-utah-enable-default.preset.80-libvirt.preset's seven disables are already in 98.80-open-vm-tools.preset(vmtoolsd) and80-hyperv-daemons.preset(hypervfcopyd) follow fromenable *. Hummingbird's own 90 preset also enablesvmtoolsdandqemu-guest-agent.ConditionVirtualization.[services].enabledgainsvmtoolsd.serviceandqemu-guest-agent.service.[services].disabledgains libvirt's sockets. Absent units count as off, so this keeps holding once libvirt lands.[configuration].filesgains/usr/libexec/dakota-devmode.setup-virtualizationandmanage-virtualization(in60-custom.just) run Dakota'sfiles/just-overrides/devmode.py, shipped verbatim as/usr/libexec/dakota-devmode(the path Dakota'sjust-overrides.bstuses).system.just, which carries the same recipe names.tests/test_virtualization.pyis new, andtests/test_ujust_overrides.pyexercises both recipes with libvirt present and absent.desktop-contract/references/dakota-services.md.Verification
just checkpasses (1355 tests).dnf repoqueryagainst the pinned Hummingbird repositories finds none of the new names, so they come from the factory. The availability of the factory names relies on the earlier repodata check of the pinned factory image, which I didn't repeat.qemu-kvmadds real weight to the image. I didn't measure it.Stacked on #1293 (
feat/dakota-home-bindmount).Closes #1232