Skip to content

feat(virtualization): QEMU, toolbox and guest agents as on Dakota; drop containerd - #1298

Closed
hanthor wants to merge 1 commit into
feat/dakota-home-bindmountfrom
feat/dakota-virtualization
Closed

hanthor wants to merge 1 commit into
feat/dakota-home-bindmountfrom
feat/dakota-virtualization

Conversation

@hanthor

@hanthor hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member

Adopts Dakota's virtualization set (owner decision on #1232), as far as the factory publishes it today.

What changed

  • Installed: packages/utah.toml [parity] adds qemu-kvm, qemu-guest-agent, spice-vdagent, open-vm-tools, hyperv-daemons and toolbox. systemd-container was already in. The factory image publishes all six; Hummingbird's own repository carries none of them.
  • Pending in the factory:
  • Removed: containerd is gone from [fedora]. containerd and runc move to [excluded]; runc only ever came in as containerd's dependency, and podman runs on crun, as on Dakota. The disable containerd.service line in the 98 preset is now dead and is gone too.
  • Presets:
    • I didn't add new preset files, because feat(services): enable units by default, as GNOME OS and Dakota do #1284 already folded Dakota's 80-* presets into 98-utah-enable-default.preset.
    • 80-libvirt.preset's seven disables are already in 98.
    • 80-open-vm-tools.preset (vmtoolsd) and 80-hyperv-daemons.preset (hypervfcopyd) follow from enable *. Hummingbird's own 90 preset also enables vmtoolsd and qemu-guest-agent.
    • Each agent is gated on its hypervisor through udev or ConditionVirtualization.
  • Contract:
    • [services].enabled gains vmtoolsd.service and qemu-guest-agent.service.
    • [services].disabled gains libvirt's sockets. Absent units count as off, so this keeps holding once libvirt lands.
    • [configuration].files gains /usr/libexec/dakota-devmode.
  • ujust:
    • setup-virtualization and manage-virtualization (in 60-custom.just) run Dakota's files/just-overrides/devmode.py, shipped verbatim as /usr/libexec/dakota-devmode (the path Dakota's just-overrides.bst uses).
    • Until libvirt is installed, both recipes say so and exit 1, instead of letting devmode refuse over units it can't find.
    • parity(dakota): adopt Dakota's ujust recipe set #1231 brings in Dakota's system.just, which carries the same recipe names.
  • Tests: tests/test_virtualization.py is new, and tests/test_ujust_overrides.py exercises both recipes with libvirt present and absent.
  • Docs: desktop-contract/references/dakota-services.md.

Verification

  • just check passes (1355 tests).
  • dnf repoquery against the pinned Hummingbird repositories finds none of the new names, so they come from the factory. The availability of the factory names relies on the earlier repodata check of the pinned factory image, which I didn't repeat.
  • qemu-kvm adds real weight to the image. I didn't measure it.
  • Not booted.

Stacked on #1293 (feat/dakota-home-bindmount).

Closes #1232

…op containerd

Install qemu-kvm, qemu-guest-agent, spice-vdagent, open-vm-tools,
hyperv-daemons and toolbox (systemd-container was already in), all
published by the factory. libvirt and virtiofsd are pending factory
imports (utah-packages#1021, #1147) and go in [unavailable] so
check-repos flags them once published.

Dakota's presets are already carried: 80-libvirt.preset's disables live
in 98-utah-enable-default.preset and its guest-agent enables follow from
enable-by-default; the contract now asserts vmtoolsd and
qemu-guest-agent enabled and libvirt's sockets off.

`ujust setup-virtualization` and `manage-virtualization` run Dakota's
files/just-overrides/devmode.py, shipped verbatim as
/usr/libexec/dakota-devmode, and explain the missing libvirt until it
lands. containerd and runc are excluded; podman runs on crun.

Closes #1232

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Withdrawn: this PR is not back in your court after all. The failing checks (contract) are red on the base branch too; this change did not break them. There is nothing to fix here: the PR is back on the normal path, and the hive checks it again once the base branch is green.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Folded into the part-2 landing PR (fold/dakota-sq) with this change unchanged apart from rebase and conflict resolution. Closing here; review continues there.

@hanthor hanthor closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant