Repository navigation
Conversation
Align Utah's desktop defaults with projectbluefin/dakota (testing): - Default-enabled GNOME Shell extensions are now exactly Dakota's 11, in Dakota's order (elements/bluefin/shell-extensions/disable-ext-validator.bst). The audio-device hider/renamer, Tailscale QS, Copyous and the Syncthing toggle stay installed but opt-in; submodules are untouched. The contract pins the effective value via [gsettings.values] instead of asserting the five extra UUIDs, and a unit test keeps override, contract and shipped UUIDs in step. - Fix Tiling Shell's Quarters layout: three of its four tiles were the bottom-right quadrant. Copy layouts-json from Dakota's files/dconf/08-dakota-extension-defaults and pin the quadrants in the contract. - Preinstall BudsLink (backing the enabled BudsLink-Companion extension): add the preinstall entry (Dakota files/oci/bluefin-flatpak/preinstall.d/) and append it to common's system-flatpaks.Brewfile in configure-services.sh, as Dakota's elements/bluefin/common.bst does. - Apply Dakota's common.bst edits: drop common's system-update, discourse and documentation launchers (Control Center covers them; the Documentation launcher opened a PDF Utah does not ship) and ship /etc/profile.d/bluefin-shell-defaults.sh defaulting BLUEFIN_SHELL_ENABLE_MOTD=0. Docs: docs/skills/desktop-contract.md and its extension-schemas reference. Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar, hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hanthor this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (14 waiting): fixes are handed out before new work as soon as you have capacity. |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Changes requested, for one thing: this would turn utah's post-testing E2E red. The rest matches Dakota.
The problem: the testsuite treats Utah as part of the Bluefin family (tests/shared/image_family.py:4, where _BLUEFIN_FAMILY_NAMES includes "utah"), so @bluefin smoke scenarios run on Utah (the skip at tests/smoke/features/environment.py:626 applies only to non-Bluefin images). Utah's post-testing E2E runs smoke,common on every flavour. Two smoke features require the extensions this PR stops enabling:
tests/smoke/features/bluefin_new_extensions.feature: "Copyous clipboard manager is enabled…" (copyous@boerdereinar.dev) and "Syncthing Toggle Quick Settings control is enabled".tests/smoke/features/copyous_stress.feature(@bluefin), whose Background requires copyous to be enabled.
So with this merged, those scenarios fail on Utah. Either land a testsuite change first that retargets those scenarios (for example, treat Utah like Dakota for the extension set, which dakota_extensions.feature checks as installed only), or keep the extras enabled until it lands.
What matches Dakota: the 11-extension list and order (disable-ext-validator.bst), the Quarters layout (files/dconf/08-dakota-extension-defaults:11), the BudsLink Brewfile append and the launcher removals (common.bst), and the MOTD default.
Smaller:
- This doesn't address #1235 (power-status-color, Utah-only extensions). Saying so in the body would stop #1235 being ticked off by mistake.
- The BudsLink
.preinstalladdsCollectionID=org.flathub.Stable, which Dakota's file doesn't have. Fine if that's to match Utah's other preinstalls. - The
rm -fof the three launchers inconfigure-services.shpasses silently if Common renames them. A contract assertion that they're absent would catch that.
Release notes: five extensions are off by default for profiles that never changed their list, the BudsLink Flatpak is preinstalled, the System Update, Community and Documentation launchers are removed, and the MOTD is off.
|
Rechecked against real results, and correcting my review's examples. In utah's latest Post-Testing E2E (run 43771896520,
My review named "Copyous clipboard manager is enabled and stable…". That one is |
|
Owner decision (2026-11-16, delegated): Follow Dakota's 11 default extensions; the testsuite's Bluefin-classic extension scenarios get scoped away from Dakota-family images (projectbluefin/testsuite PR to follow). |
|
Testsuite side: projectbluefin/testsuite#1251 adds a Dakota family (
Before this merges, bump the testsuite pin in |
projectbluefin/testsuite#1251 scopes the Bluefin-classic default-extension scenarios away from Dakota-family images (utah, dakota) and runs Dakota's 11 default-extension checks on them instead, so this PR's switch to Dakota's default set no longer fails post-testing E2E. Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
c081f49 to
3f1cdeb
Compare
|
Addressed the review: projectbluefin/testsuite#1251 (merged) moves the Bluefin-classic default-extension scenarios (copyous, the audio hider/renamer, syncthing-toggle, tailscale-qs) behind |
Danathar
left a comment
There was a problem hiding this comment.
Resolved, thanks @hanthor. projectbluefin/testsuite#1251 (merged as ecd519d, which is also v1 now) adds utah to the Dakota family and tags the Bluefin-classic extension scenarios @bluefin_classic, which skip on Dakota-family images. That covers all seven I listed (copyous ×3, the audio hider and renamer, syncthing-toggle, tailscale-qs). This head pins post-testing-e2e.yml at ecd519d, which is exactly #1251 on top of the old 65afdeb. Dakota's 11 @dakota_family default-extension scenarios now run on Utah, and the dconf values they read are in this PR. Approving. Three of those (fuzzy search, BudsLink, tilingshell) haven't run on Utah before, so the first post-testing E2E is their first real run.
3f1cdeb
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @hanthor, head
Hive did not add the |
|
@Danathar approved head |
…amilies (projectbluefin#1251) Utah follows Dakota's 11 default-enabled GNOME Shell extensions (projectbluefin/utah#1252), but it is also a Bluefin-family image, so @bluefin smoke scenarios that require copyous, syncthing-toggle, the Quick Settings audio hider/renamer and tailscale-qs to be enabled ran on it and would fail once those defaults are dropped. Add is_dakota_family_image() (dakota, utah) and two smoke tags: @bluefin_classic skips on Dakota-family images, @dakota_family runs only on them. Tag bluefin_new_extensions.feature and copyous_stress.feature @bluefin_classic, and make the default-enabled half of dakota_extensions.feature @dakota_family so Utah asserts Dakota's set. The installed-only checks name Dakota-specific UUIDs and stay @dakota_only. Refs projectbluefin/utah#1252 Assisted-by: Claude Opus via GitHub Copilot Signed-off-by: James Reilly <jreilly1821@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Part 5/7 of the Dakota parity stack (epic #1236). Base:
feat/uupd-dakota; review and merge in order.Align Utah's desktop defaults with projectbluefin/dakota (testing):
Dakota's order (elements/bluefin/shell-extensions/disable-ext-validator.bst).
The audio-device hider/renamer, Tailscale QS, Copyous and the Syncthing
toggle stay installed but opt-in; submodules are untouched. The contract
pins the effective value via [gsettings.values] instead of asserting the
five extra UUIDs, and a unit test keeps override, contract and shipped
UUIDs in step.
bottom-right quadrant. Copy layouts-json from Dakota's
files/dconf/08-dakota-extension-defaults and pin the quadrants in the
contract.
add the preinstall entry (Dakota files/oci/bluefin-flatpak/preinstall.d/)
and append it to common's system-flatpaks.Brewfile in
configure-services.sh, as Dakota's elements/bluefin/common.bst does.
and documentation launchers (Control Center covers them; the
Documentation launcher opened a PDF Utah does not ship) and ship
/etc/profile.d/bluefin-shell-defaults.sh defaulting
BLUEFIN_SHELL_ENABLE_MOTD=0.
Docs: docs/skills/desktop-contract.md and its extension-schemas reference.
Verified:
just checkpasses at the stack tip (1,329 tests). An image build hasn't run yet.