Skip to content

feat(desktop): adopt Dakota's extension, Flatpak and launcher defaults - #1252

Closed
hanthor wants to merge 2 commits into
feat/uupd-dakotafrom
feat/dakota-desktop-defaults
Closed

hanthor wants to merge 2 commits into
feat/uupd-dakotafrom
feat/dakota-desktop-defaults

Conversation

@hanthor

@hanthor hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member

Part 5/7 of the Dakota parity stack (epic #1236). Base: feat/uupd-dakota; review and merge in order.

Align Utah's desktop defaults with projectbluefin/dakota (testing):

  • Default-enabled GNOME Shell extensions are now exactly Dakota's 11, in
    Dakota's order (elements/bluefin/shell-extensions/disable-ext-validator.bst).
    The audio-device hider/renamer, Tailscale QS, Copyous and the Syncthing
    toggle stay installed but opt-in; submodules are untouched. The contract
    pins the effective value via [gsettings.values] instead of asserting the
    five extra UUIDs, and a unit test keeps override, contract and shipped
    UUIDs in step.
  • Fix Tiling Shell's Quarters layout: three of its four tiles were the
    bottom-right quadrant. Copy layouts-json from Dakota's
    files/dconf/08-dakota-extension-defaults and pin the quadrants in the
    contract.
  • Preinstall BudsLink (backing the enabled BudsLink-Companion extension):
    add the preinstall entry (Dakota files/oci/bluefin-flatpak/preinstall.d/)
    and append it to common's system-flatpaks.Brewfile in
    configure-services.sh, as Dakota's elements/bluefin/common.bst does.
  • Apply Dakota's common.bst edits: drop common's system-update, discourse
    and documentation launchers (Control Center covers them; the
    Documentation launcher opened a PDF Utah does not ship) and ship
    /etc/profile.d/bluefin-shell-defaults.sh defaulting
    BLUEFIN_SHELL_ENABLE_MOTD=0.

Docs: docs/skills/desktop-contract.md and its extension-schemas reference.

Verified: just check passes at the stack tip (1,329 tests). An image build hasn't run yet.

Align Utah's desktop defaults with projectbluefin/dakota (testing):

- Default-enabled GNOME Shell extensions are now exactly Dakota's 11, in
  Dakota's order (elements/bluefin/shell-extensions/disable-ext-validator.bst).
  The audio-device hider/renamer, Tailscale QS, Copyous and the Syncthing
  toggle stay installed but opt-in; submodules are untouched. The contract
  pins the effective value via [gsettings.values] instead of asserting the
  five extra UUIDs, and a unit test keeps override, contract and shipped
  UUIDs in step.
- Fix Tiling Shell's Quarters layout: three of its four tiles were the
  bottom-right quadrant. Copy layouts-json from Dakota's
  files/dconf/08-dakota-extension-defaults and pin the quadrants in the
  contract.
- Preinstall BudsLink (backing the enabled BudsLink-Companion extension):
  add the preinstall entry (Dakota files/oci/bluefin-flatpak/preinstall.d/)
  and append it to common's system-flatpaks.Brewfile in
  configure-services.sh, as Dakota's elements/bluefin/common.bst does.
- Apply Dakota's common.bst edits: drop common's system-update, discourse
  and documentation launchers (Control Center covers them; the
  Documentation launcher opened a PDF Utah does not ship) and ship
  /etc/profile.d/bluefin-shell-defaults.sh defaulting
  BLUEFIN_SHELL_ENABLE_MOTD=0.

Docs: docs/skills/desktop-contract.md and its extension-schemas reference.

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danathar, hanthor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hanthor hanthor mentioned this pull request Nov 16, 2026
1 of 30 tasks
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

@hanthor this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • contract

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (14 waiting): fixes are handed out before new work as soon as you have capacity.

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Changes requested, for one thing: this would turn utah's post-testing E2E red. The rest matches Dakota.

The problem: the testsuite treats Utah as part of the Bluefin family (tests/shared/image_family.py:4, where _BLUEFIN_FAMILY_NAMES includes "utah"), so @bluefin smoke scenarios run on Utah (the skip at tests/smoke/features/environment.py:626 applies only to non-Bluefin images). Utah's post-testing E2E runs smoke,common on every flavour. Two smoke features require the extensions this PR stops enabling:

  • tests/smoke/features/bluefin_new_extensions.feature: "Copyous clipboard manager is enabled…" (copyous@boerdereinar.dev) and "Syncthing Toggle Quick Settings control is enabled".
  • tests/smoke/features/copyous_stress.feature (@bluefin), whose Background requires copyous to be enabled.

So with this merged, those scenarios fail on Utah. Either land a testsuite change first that retargets those scenarios (for example, treat Utah like Dakota for the extension set, which dakota_extensions.feature checks as installed only), or keep the extras enabled until it lands.

What matches Dakota: the 11-extension list and order (disable-ext-validator.bst), the Quarters layout (files/dconf/08-dakota-extension-defaults:11), the BudsLink Brewfile append and the launcher removals (common.bst), and the MOTD default.

Smaller:

  • This doesn't address #1235 (power-status-color, Utah-only extensions). Saying so in the body would stop #1235 being ticked off by mistake.
  • The BudsLink .preinstall adds CollectionID=org.flathub.Stable, which Dakota's file doesn't have. Fine if that's to match Utah's other preinstalls.
  • The rm -f of the three launchers in configure-services.sh passes silently if Common renames them. A contract assertion that they're absent would catch that.

Release notes: five extensions are off by default for profiles that never changed their list, the BudsLink Flatpak is preinstalled, the System Update, Community and Documentation launchers are removed, and the MOTD is off.

@Danathar

Copy link
Copy Markdown
Contributor

Rechecked against real results, and correcting my review's examples. In utah's latest Post-Testing E2E (run 43771896520, smoke-a/smoke-b results.json), these @bluefin scenarios ran and passed, and each requires an extension this PR stops enabling:

  • Quick Settings audio device hider is enabled
  • Quick Settings audio device renamer is enabled
  • Syncthing Toggle Quick Settings control is enabled
  • Tailscale Quick Settings control handles daemon state
  • Copyous survives burst clipboard churn…, …rapid enable disable lifecycle stress… and …database and history persistence… (copyous_stress.feature, whose Background requires copyous enabled)

My review named "Copyous clipboard manager is enabled and stable…". That one is @pending and was skipped, so it's not one of them. The conclusion stands: with this merged, those seven fail on Utah until the testsuite treats Utah's extension set like Dakota's.

@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Owner decision (2026-11-16, delegated): Follow Dakota's 11 default extensions; the testsuite's Bluefin-classic extension scenarios get scoped away from Dakota-family images (projectbluefin/testsuite PR to follow).

@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Testsuite side: projectbluefin/testsuite#1251 adds a Dakota family (dakota, utah) to the smoke suite.

  • @bluefin_classic now skips on Dakota-family images. It covers bluefin_new_extensions.feature and copyous_stress.feature, which include all seven scenarios from the review: copyous ×3, the Quick Settings hider and renamer, syncthing-toggle and tailscale-qs.
  • @dakota_family makes the 11 default-enabled scenarios in dakota_extensions.feature run on Utah. They cover Dakota's disable-ext-validator.bst set plus the BudsLink, custom-command-list and tilingshell dconf values. Utah main already satisfies them, so they hold both before and after this PR.
  • Every other @bluefin scenario keeps running on Utah.

Before this merges, bump the testsuite pin in .github/workflows/post-testing-e2e.yml (projectbluefin/testsuite/.github/workflows/e2e.yml@65afdeb…) to the testsuite#1251 merge commit, either in this PR or ahead of it.

projectbluefin/testsuite#1251 scopes the Bluefin-classic default-extension
scenarios away from Dakota-family images (utah, dakota) and runs Dakota's
11 default-extension checks on them instead, so this PR's switch to
Dakota's default set no longer fails post-testing E2E.

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hanthor
hanthor force-pushed the feat/dakota-desktop-defaults branch from c081f49 to 3f1cdeb Compare November 16, 2026 04:32
@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Addressed the review: projectbluefin/testsuite#1251 (merged) moves the Bluefin-classic default-extension scenarios (copyous, the audio hider/renamer, syncthing-toggle, tailscale-qs) behind @bluefin_classic, which skips Dakota-family images. It also runs Dakota's 11 default-extension checks on Utah through @dakota_family. This branch now pins the testsuite at that merge commit (ecd519d) in post-testing-e2e.yml and execute-release.yml.

@hanthor
hanthor requested a review from Danathar November 16, 2026 04:32

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved, thanks @hanthor. projectbluefin/testsuite#1251 (merged as ecd519d, which is also v1 now) adds utah to the Dakota family and tags the Bluefin-classic extension scenarios @bluefin_classic, which skip on Dakota-family images. That covers all seven I listed (copyous ×3, the audio hider and renamer, syncthing-toggle, tailscale-qs). This head pins post-testing-e2e.yml at ecd519d, which is exactly #1251 on top of the old 65afdeb. Dakota's 11 @dakota_family default-extension scenarios now run on Utah, and the dconf values they read are in this PR. Approving. Three of those (fuzzy search, BudsLink, tilingshell) haven't run on Utah before, so the first post-testing E2E is their first real run.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
3f1cdeb

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head 3f1cdeb1bb3d) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 2 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/execute-release.yml
    • .github/workflows/post-testing-e2e.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head 3f1cdeb1bb3d, which edits CI workflow / action files. That explicit owner approval releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. A new push re-arms the fence until the new head is approved again; the hive's own merge of the base branch, which leaves the diff unchanged, does not.

@hanthor

hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Folded into #1248, which carries this change unchanged in one rebased series so the stack lands in a single CI cycle. Closing here; review continues on #1248.

@hanthor hanthor closed this Nov 16, 2026
Danathar pushed a commit to kylerankin/testsuite that referenced this pull request Nov 16, 2026
…amilies (projectbluefin#1251)

Utah follows Dakota's 11 default-enabled GNOME Shell extensions
(projectbluefin/utah#1252), but it is also a Bluefin-family image, so
@bluefin smoke scenarios that require copyous, syncthing-toggle, the
Quick Settings audio hider/renamer and tailscale-qs to be enabled ran
on it and would fail once those defaults are dropped.

Add is_dakota_family_image() (dakota, utah) and two smoke tags:
@bluefin_classic skips on Dakota-family images, @dakota_family runs only
on them. Tag bluefin_new_extensions.feature and copyous_stress.feature
@bluefin_classic, and make the default-enabled half of
dakota_extensions.feature @dakota_family so Utah asserts Dakota's set.
The installed-only checks name Dakota-specific UUIDs and stay
@dakota_only.

Refs projectbluefin/utah#1252

Assisted-by: Claude Opus via GitHub Copilot

Signed-off-by: James Reilly <jreilly1821@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants