Repository navigation
Conversation
Copy Dakota's (projectbluefin/dakota, branch testing) small system defaults into Utah: - usr/share/wireplumber/wireplumber.conf.d/51-disable-pcsp.conf from files/wireplumber/ (elements/bluefin/wireplumber-pcsp.bst) hides the PC-speaker ALSA card so it cannot become the default sink after resume (projectbluefin/dakota#1248). - usr/lib/sysctl.d/60-kexec-disable.conf from elements/bluefin/kexec-disable.bst sets kernel.kexec_load_disabled = 1. Dakota's files/polkit/org.freedesktop.NetworkManager.rules is already shipped, with an identical rule, by Hummingbird's NetworkManager RPM at /usr/share/polkit-1/rules.d/, so Utah asserts it in the desktop contract instead of overlaying the package-owned file. Drop the suspend-then-hibernate logind override inherited from bluefin-lts's 40-services.sh. Dakota ships no logind or sleep override, and Utah's only swap is zram, so hibernate had no resume target. Lid and sleep actions now use systemd-logind's defaults (suspend). The desktop contract asserts all three files and their key settings; the desktop-contract skill documents them. Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danathar, hanthor The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Withdrawn: this PR is not back in your court after all. The failing checks ( |
Danathar
left a comment
There was a problem hiding this comment.
Stand-in review (the hive's reviewers are out of quota). Approving: small, faithful copies of Dakota's defaults, plus the sleep cleanup.
Checked:
60-kexec-disable.confand51-disable-pcsp.confmatch Dakota'skexec-disable.bstandfiles/wireplumber/51-disable-pcsp.conf.- The contract asserts all three files and their key contents. The polkit strings match Dakota's
files/polkit/org.freedesktop.NetworkManager.rules. - Dropping the
suspend-then-hibernatesed is right. Dakota ships no logind override, and zram-only swap can't hibernate anyway. Nothing else referencesHandleLid*/SleepOperation, and the testsuite has no lid or sleep scenario.
One thing to confirm: this relies on Hummingbird's NetworkManager RPM already shipping the wheel polkit rule at /usr/share/polkit-1/rules.d/org.freedesktop.NetworkManager.rules with that text, because there's no overlay. If it doesn't, the in-image contract check fails at build. Worth confirming with rpm -ql NetworkManager or one built image.
Release notes: closing the lid now suspends, kexec is disabled, and the PC-speaker card no longer becomes the default audio sink after resume.
|
Answering my own question from the review: the polkit rule is shipped. Fedora's |
Part 3/7 of the Dakota parity stack (epic #1236). Base:
feat/dakota-service-presets; review and merge in order.Copy Dakota's (projectbluefin/dakota, branch testing) small system
defaults into Utah:
files/wireplumber/ (elements/bluefin/wireplumber-pcsp.bst) hides the
PC-speaker ALSA card so it cannot become the default sink after resume
(Resume selects PC-speaker sink, causing silence and slow video dakota#1248).
elements/bluefin/kexec-disable.bst sets kernel.kexec_load_disabled = 1.
Dakota's files/polkit/org.freedesktop.NetworkManager.rules is already
shipped, with an identical rule, by Hummingbird's NetworkManager RPM at
/usr/share/polkit-1/rules.d/, so Utah asserts it in the desktop
contract instead of overlaying the package-owned file.
Drop the suspend-then-hibernate logind override inherited from
bluefin-lts's 40-services.sh. Dakota ships no logind or sleep override,
and Utah's only swap is zram, so hibernate had no resume target. Lid and
sleep actions now use systemd-logind's defaults (suspend).
The desktop contract asserts all three files and their key settings;
the desktop-contract skill documents them.
Verified:
just checkpasses at the stack tip (1,329 tests). An image build hasn't run yet.