Skip to content

chore(deps): update quay.io/hummingbird-community/bootc-os:latest docker digest to db1007f - #122

Closed
mergeraptor[bot] wants to merge 1 commit into
mainfrom
renovate/quay.io-hummingbird-community-bootc-os-latest
Closed

mergeraptor[bot] wants to merge 1 commit into
mainfrom
renovate/quay.io-hummingbird-community-bootc-os-latest

Conversation

@mergeraptor

@mergeraptor mergeraptor Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
quay.io/hummingbird-community/bootc-os final digest c5539f9 → db1007f
quay.io/hummingbird-community/bootc-os stage digest c5539f9 → db1007f

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging this. The failure is real and reproducible, and it is not a flake — this branch has now failed five consecutive digest bumps (Sep 9, Sep 10 x2, Sep 13, Sep 18). main/testing are healthy (testing built green at 07:40 today), so the base digest is the differentiator.

The new digest is not a routine rebuild — it rebases the base from Fedora 43 to Fedora 44. I ran both images side by side:

$ podman run --rm quay.io/hummingbird-community/bootc-os@sha256:c5539f9e... sh -c '...'   # OLD (pinned on main)
kernel rpm: 7.1.8-100.fc43
shim-x64:   15.8-3
/usr/lib/bootupd/updates/EFI/fedora: PRESENT
BOOT  fedora  hummingbird

$ podman run --rm quay.io/hummingbird-community/bootc-os@sha256:5c05afed... sh -c '...'   # NEW (this PR)
kernel rpm: 7.2.5-200.fc44
shim-x64:   16.1-5
/usr/lib/bootupd/updates/EFI/fedora: MISSING
(no bootupd updates dir)

That explains both failing jobs.

build_main / image — Containerfile:163. The log dies three seconds after Utah desktop contract passed: 38 Flatpaks, 8 enabled services with no further output, which is the signature of a silent test -d. The next commands in that RUN are:

shim_version="$(rpm -q --qf '%{VERSION}-%{RELEASE}' shim-x64)" && \
test -d /usr/lib/bootupd/updates/EFI/fedora && \

/usr/lib/bootupd/updates/EFI does not exist at all in the new base, so the test -d returns 1 and the RUN fails. Fedora 44's shim no longer stages its EFI payload under bootupd's update tree, and the shim-mirroring block (Containerfile:141-165) depends on exactly that layout. All three build attempts failed identically at this step, which rules out a transient.

kernel_cache. The pinned NVIDIA open driver does not compile against kernel 7.2.5:

./common/inc/nv-linux.h: error ... implicit declaration
  +++ |+#include <string.h>
make[4]: *** [.../scripts/Makefile.build:289: nvidia/os-interface.o] Error 1
Error: building at STEP "RUN ... utah-install-ogc-kernel && ... utah-install-nvidia ..."

That is the well-known NVIDIA-vs-newer-kernel-headers breakage, surfaced by the F43→F44 kernel jump.

Neither is this PR's fault, and neither is fixable inside it. A digest bump has no business carrying a shim/bootupd layout migration or an NVIDIA driver bump. What the F44 base actually needs is a separate change:

  1. Rework the shim mirroring at Containerfile:141-165 for the new EFI layout (or drop it if bootupd on F44 discovers the payload without help).
  2. Move the NVIDIA driver to a release that builds against kernel 7.2.x.

Leaving this open rather than closing it — Renovate owns the branch and will keep refreshing the digest. It should stay red until those two land, at which point it turns green on its own. If the base is expected to sit on F44 for a while, the Utah-side migration is the blocker to schedule; this PR is only the messenger.

@mergeraptor mergeraptor Bot changed the title chore(deps): update quay.io/hummingbird-community/bootc-os:latest docker digest to 5c05afe chore(deps): update quay.io/hummingbird-community/bootc-os:latest docker digest to db1007f Sep 18, 2026
@mergeraptor
mergeraptor Bot force-pushed the renovate/quay.io-hummingbird-community-bootc-os-latest branch from c5e940a to 5594d2d Compare September 18, 2026 18:21

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78

@hanthor

hanthor commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

This bump is correct in shape but cannot merge yet: the new base breaks the NVIDIA module build, and that is a real incompatibility rather than a flake.

The diff is right. Both ARG BASE_IMAGE= lines move together — Containerfile:1 and Containerfile.kernel:19 — which is the invariant just check asserts and the one that matters here: pinning the two halves separately is how the image and its kernel cache end up built from different bases. contract is green.

What fails. kernel_cache dies 22 minutes in, building the NVIDIA open module against the kernel the new base brings (7.2.5-200.fc44):

nvidia/os-interface.c: In function 'os_get_current_process_name':
nvidia/os-interface.c:764:5: error: implicit declaration of function 'strncpy'
    [-Wimplicit-function-declaration]
  764 |     strncpy(buf, current->comm, len - 1);
nvidia/os-interface.c:42:1: note: 'strncpy' is defined in header '<string.h>'
make[4]: *** [.../scripts/Makefile.build:289: nvidia/os-interface.o] Error 1

That is the kernel's header-dependency pruning catching up with the driver: os-interface.c never included a string header of its own and relied on one arriving transitively, which this kernel no longer provides. It is a hard compile error, not a warning promoted by our flags, so it will block every base bump from here until the driver side moves.

scripts/install-nvidia.sh:52 pins 595.84. So the options are, in order of preference:

  1. Bump driver_version to a release whose kernel-open tree compiles against 7.2 — and update the checksum beside it, since the .run is digest-pinned.
  2. If no such release exists yet, carry a one-line patch adding the include before the module build, the way utah-packages carries spec patches, with a comment naming the kernel that forced it.

Option 2 is the kind of thing that should be deleted the moment option 1 becomes available, so please leave the pointer in the comment if it comes to that.

build_main also failed at Build Image, ~20 minutes in, and I could not retrieve that step's output to attribute it. It may be a second consequence of the new base or may be unrelated; I would not assume either way until the kernel side is fixed and it re-runs.

I have opened #173 for the driver-versus-kernel break, since it outlives this PR. Once that lands, rebase this and I will merge it on a green run.


Generated by Claude Code

@hanthor

hanthor commented Sep 19, 2026

Copy link
Copy Markdown
Member

#182 carries this same digest together with the NVIDIA driver bump that makes it compile, so this PR should close as superseded once that lands.

For the record, the fix turned out to be upstream's rather than ours: the kernel finished its strscpy migration and removed strncpy, and NVIDIA followed in 595.99.02 — which is also what latest.txt designates, so the existing pin policy already pointed at the answer. Read from the vendor source at each tag:

driver os-interface.c:764
595.84 strncpy(buf, current->comm, len - 1);
595.99.02 if (strscpy(buf, current->comm, len) < 0) {

The bump had to travel with the driver change rather than land on its own: on the old base the old driver compiles fine, so the base bump is the only thing that can prove the driver fix works.


Generated by Claude Code

@hanthor

hanthor commented Sep 19, 2026

Copy link
Copy Markdown
Member

This bump cannot land on its own, and it is worth recording why before someone retries it or automerge picks it up.

The digest change here (c5539f9 → db1007f) is correct and wanted, but that base moves the kernel from 7.1.8-100.fc43 to 7.2.5-200.fc44, and three separate things in this repository assume the old one. Each was found by a different failure:

  1. NVIDIA 595.84 does not compile against kernel 7.2. Kernel 7.2 completed the strscpy migration and removed strncpy, so the module build fails with implicit declaration of function 'strncpy' in os-interface.c. Upstream fixed it in 595.99.02. That is what took out the original attempt at this bump.

  2. KERNEL_DEVEL_SHA256 in scripts/install-nvidia.sh is pinned to the old kernel. It guards an unsigned koji download and is documented as a constant because "the kernel cannot change without BASE_IMAGE changing" — which is exactly why it has to move when BASE_IMAGE does. Nothing would have failed immediately (the dnf path satisfies 7.2 and the koji fallback never runs), but it would have failed the first time the enabled repositories dropped the kernel, which is the one situation that fallback exists for.

  3. The shim mirroring step assumes a layout this base has moved on from. I listed both images' layers from the registry:

    old base  usr/lib/bootupd/updates/EFI/fedora/{shimx64,shim,mmx64,grubx64}.efi
              (no usr/lib/efi/shim at all)
    
    new base  usr/lib/efi/shim/16.1-5/EFI/fedora/{shimx64,shim,mmx64}.efi
              usr/lib/bootupd/updates/ holds only BIOS.json and EFI.json
    

    The new base already does the mirroring itself — /usr/lib/efi/shim/… is precisely the destination Utah's step copies into, and the source it copies from no longer exists. Nothing is missing; the step was asserting the old shape and failing on a job already done. Because it was four predicates chained with &&, it failed silently: the last log line was "Utah desktop contract passed", then exit 1, three attempts out of three.

All three are fixed on #182, which carries this same digest bump plus the NVIDIA driver bump, the re-recorded kernel-devel pin, and a scripts/mirror-shim.sh that handles both base layouts. So this PR is effectively superseded — merging it alone would reproduce the build_main and build_kernel failures currently visible on its own checks.

I would suggest closing this in favour of #182 once that is approved, or leaving it open purely as the renovate record; either way it should not be merged standalone.


Generated by Claude Code

@hivecommons-hive

Copy link
Copy Markdown
Contributor

This digest bump moves the base to a bootc-os image carrying kernel 7.2.5-200.fc44, and the pinned NVIDIA driver does not build against it:

nvidia/os-interface.c:764:5: error: implicit declaration of function 'strncpy' [-Wimplicit-function-declaration]
make[4]: *** [.../scripts/Makefile.build:289: nvidia/os-interface.o] Error 1

So kernel_cache and build_main / image (main, utah, testing, x86_64) are failing for a real reason, not a flake — the driver has to move with the kernel.

That is already in flight as #182 (fix(nvidia): bump the driver for kernel 7.2, and make the base bump ...). This bump should be sequenced behind #182 rather than fixed separately here.

— hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.78

castrojo pushed a commit that referenced this pull request Sep 21, 2026
…ctually build (#182)

* Bump the NVIDIA driver to the release that compiles against kernel 7.2

The base image pin has been frozen since Hummingbird moved to kernel 7.2.
Every attempt to advance it -- #122 is the current one -- fails kernel_cache
22 minutes in, building the NVIDIA open module:

    nvidia/os-interface.c: In function 'os_get_current_process_name':
    nvidia/os-interface.c:764:5: error: implicit declaration of function
        'strncpy' [-Wimplicit-function-declaration]
      764 |     strncpy(buf, current->comm, len - 1);
    make[4]: *** [.../7.2.5-200.fc44.x86_64/...: nvidia/os-interface.o] Error 1

A frozen base pin means no kernel security updates reach the flavored images,
so this is worth fixing properly rather than pinning around.

The cause is the kernel finishing its strscpy migration and removing strncpy,
and the fix is upstream's, not ours. Read from the vendor source at each tag:

    595.84      strncpy(buf, current->comm, len - 1);
    595.91.07   strscpy
    595.99.02   if (strscpy(buf, current->comm, len) < 0) {

So 595.99.02 carries the migration, and it is also what
https://download.nvidia.com/XFree86/Linux-x86_64/latest.txt designates today
-- which is the rule the pin comment already states. This is that policy
working, not a hand-picked version: read latest.txt, take the SHA-256 NVIDIA
publishes beside the installer.

The base bump rides along deliberately. On the current base the old driver
compiles fine, so a driver-only change proves nothing -- the two can only be
verified together, and kernel_cache on this PR is that verification. Both
ARG BASE_IMAGE= lines move together, as `just check` requires.

The cache tag rotates 1ce05c4b16fafe9c -> f1e31a1dee27ffaa, so the three
cached flavors compile the kernel once. That is the intended cost: the tag
moving is what proves the new base and driver were actually built, rather
than a stale cache being reused (#166, #171).

Closes #173.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M

* Make the shim mirroring say what it could not find, and pair the kernel-devel hash with its kernel

The base bump to a kernel-7.2 Hummingbird regressed build_main. It failed
deterministically, three attempts out of three, and printed nothing: the last
line of the log was "Utah desktop contract passed", then exit 1. The step was
four predicates chained with && at the tail of a long RUN --

  shim_version="$(rpm -q --qf '%{VERSION}-%{RELEASE}' shim-x64)" && \
  test -d /usr/lib/bootupd/updates/EFI/fedora && \
  install -d ... && cp -a ...

-- so nothing distinguished "shim-x64 is not in this base" from "shim-x64 is
installed but staged nothing", and those have different answers. The chain now
lives in scripts/mirror-shim.sh, which names the failing predicate, lists what
the bootupd tree actually contains when the payload is absent, and says that a
base which dropped shim-x64 needs it added to the package contract rather than
the step skipped. This does not yet fix the build; it makes the next run say
which of the two happened, which the previous three runs could not.

The second change is the review finding on the same bump. KERNEL_DEVEL_SHA256
guards an unsigned koji download and is documented as a constant precisely
because "the kernel cannot change without BASE_IMAGE changing" -- which is the
reason it must move when BASE_IMAGE does, and it did not. It stayed pinned to
7.1.8-100.fc43 while the base moved to 7.2.5-200.fc44. Nothing failed, because
the dnf path satisfied 7.2 and the fallback never ran; it would have failed the
first time the enabled repositories dropped the kernel, which is the single
situation the fallback exists for.

The hash is now the real one for kernel-devel-7.2.5-200.fc44.x86_64, taken from
koji, and it is recorded beside KERNEL_DEVEL_NEVR. A mismatch between the
recorded kernel and the booted one now fails immediately with both versions
named, instead of after fetching 60 MB to compare against a hash that cannot
match.

Tests drive the real code: mirror-shim.sh runs against a stub rpm and a fake
bootupd tree for all three outcomes, asserting the two failures do not share a
message; the NEVR guard is extracted and executed for both the matching and
mismatched kernel. 204 tests, OK.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M

* Handle the base image that already mirrors the shim payload itself

I did not need to wait for CI for this. Listing both base images layer by layer
from the registry answers it outright, and the answer is that the new base has
already done the work:

  old base sha256:c5539f9e...
    usr/lib/bootupd/updates/EFI/fedora/{shimx64,shim,mmx64,grubx64}.efi
    no usr/lib/efi/shim at all

  new base sha256:db1007fd...
    usr/lib/efi/shim/16.1-5/EFI/fedora/{shimx64,shim,mmx64}.efi, BOOTX64.CSV
    usr/lib/bootupd/updates/ holds only BIOS.json and EFI.json

So the destination Utah was copying into is exactly what the new base now
ships, and the source it was copying from no longer exists. The step was not
broken by a missing package or a broken transaction; it was asserting a layout
the base has moved on from, and failing on a job that was already done.

mirror-shim.sh now looks for the payload before doing anything else and exits 0
when it is already in place. It searches for the EFI/fedora/shimx64.efi file
rather than assuming a directory name, because the base names that directory
for the shim version with no dist tag and rpm need not report the same string.
Checking the filesystem first also means the base that ships the payload is the
base whose shim-x64 rpm query we no longer depend on.

The old layout still works: the copy path is unchanged and tested. The two real
failures -- no package and no payload anywhere -- still fail, still say which,
and still do not share a message.

Tests drive the real script against synthetic filesystems for both layouts,
including the case where rpm reports 16.1-5.fc44 while the base directory is
16.1-5. 206 tests, OK.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M

* Make the kernel NEVR overridable, so the hash override is not dead code

Review finding, and correct. I added a guard that exits when the booted kernel
differs from KERNEL_DEVEL_NEVR, to turn a 60 MB download ending in a checksum
mismatch into an immediate failure naming both versions. But
UTAH_KERNEL_DEVEL_SHA256 exists for exactly one situation -- validating a kernel
this file has not been re-recorded for -- and the guard runs before the hash
check, so it blocked precisely the case the override is for. Correct override or
not, that path exited 1. I turned an escape hatch into dead code while adding a
guard meant to make failures clearer.

KERNEL_DEVEL_NEVR now takes UTAH_KERNEL_DEVEL_NEVR the same way the hash takes
its override, and the guard message names both variables, so the way past it is
to set the pair deliberately rather than to edit the script. Overriding one
without the other still fails, which is the intended behaviour: the hash belongs
to a specific NEVR and the two only mean anything together.

Three tests: both constants accept an override, the guard message names them,
and the real guard extracted from the script reaches the download when both are
set to a kernel that is not the recorded one. The first fails against the
previous constant line.

209 tests pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@castrojo

Copy link
Copy Markdown
Contributor

Closing as superseded: this base image digest bump (db1007f) was already integrated into main along with necessary NVIDIA driver 7.2 adaptations and shim mirroring in #182.

@castrojo castrojo closed this Sep 21, 2026
@mergeraptor
mergeraptor Bot deleted the renovate/quay.io-hummingbird-community-bootc-os-latest branch September 21, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants