Repository navigation
fix(packages): ship glibc-all-langpacks so a chosen locale exists - #116
Merged
Merged
Conversation
Hummingbird's base installs only glibc-minimal-langpack, which provides C
and C.UTF-8. Any other locale a user selects -- Region & Language, localectl,
or a /etc/locale.conf that survived from a previous install -- names data
the image does not have, and every setlocale() warns on every command:
warning: setlocale: LC_NUMERIC: cannot change locale (en_SG.UTF-8)
That is #114, on an X230 whose locale.conf carried en_SG from before the
Utah test. The reporter also read /etc/profile.d/lang.sh correctly: its
C.UTF-8 fallback is real but is overwritten by the locale.conf re-export
that follows it, so the safety net does nothing. That is a bug in Fedora's
setup package and not one this repository can fix; what it can fix is the
missing data.
glibc-all-langpacks is in public-hummingbird-x86_64-rpms, so this is one
name in the install set with no factory work. Bluefin's Silverblue base
ships it, which is why the same locale.conf is quiet there.
Verified: the contract check validates, 96 tests pass. The install
transaction itself is CI's check-repos.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
castrojo
approved these changes
Sep 18, 2026
castrojo
left a comment
Contributor
There was a problem hiding this comment.
Reviewed against the repositories and an actual image build, not just the green checkmark.
Scope is one package plus its rationale: glibc-all-langpacks appended to [gnome] in packages/utah.toml. Hummingbird's base carries only glibc-minimal-langpack (C and C.UTF-8), so any LANG/LC_* a user picks in Region & Language names a locale that does not exist and every setlocale() warns (#114).
Verified independently:
- It resolves from an allowed repository. The
contractjob runs DNF with--disablerepo=* --enablerepo=utah-packages --enablerepo=public-hummingbird-x86_64-rpms, and resolvesglibc-all-langpacks-2.43-8.5.hum1frompublic-hummingbird-x86_64-rpms. No Fedora repo is enabled, so the "Fedora repositories are never enabled at runtime" invariant holds. - It is actually installed, not silently skipped. The main image job marks
glibc-all-langpacks-2.43-8.5.hum1.x86_64user-installed and reportsAll 75 contract packages are present.It goes throughinstall-packages.py's explicit[gnome]branch into the resolved contract and is asserted byverify-rpm-contract.py. - Cost is real but bounded: ~227 MiB installed. That is the price of Region & Language being a working control instead of a way to break the terminal.
packages/bluefin.toml, flavor config, and the Renovate-managed digests are untouched. All 14 checks SUCCESS.
Two notes for the record, neither blocking:
[gnome]is a slightly loose home for locale data — it is not a GNOME component. It is nonetheless the only installed desktop-runtime bucket that exists today, and inventing a[base]section would be a taxonomy decision beyond this fix. Correct call to use it.- The parity counts in
README.mdanddocs/skills/package-contract.mdare stale, but they were already stale before this PR (they say 61/12/4; reality at this head is 59 Bluefin / 16 Utah additions / 9 unavailable). That is pre-existing debt, so I am deliberately not expanding this PR's scope to fix it.
The /etc/profile.d/lang.sh clobbering story in the comment is narrative rather than load-bearing — the fix stands regardless of why the fallback fails, because installing the locale archive makes the selected locale exist.
Approving.
hanthor
pushed a commit
that referenced
this pull request
Sep 18, 2026
#116 (glibc-all-langpacks) and #129 (the [parity] section) landed after the baseline was generated, closing 25 of its 969 names. By the file's own rule they come out: 944 remain, 253 of them in Hummingbird's repository. The pinned count in tests/test_image_parity.py follows. The header keeps the Bluefin and Utah totals from the run that generated it and says so; the next image build's report is where the refreshed Utah count comes from. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
castrojo
pushed a commit
that referenced
this pull request
Sep 22, 2026
#116 (glibc-all-langpacks) and #129 (the [parity] section) landed after the baseline was generated, closing 25 of its 969 names. By the file's own rule they come out: 944 remain, 253 of them in Hummingbird's repository. The pinned count in tests/test_image_parity.py follows. The header keeps the Bluefin and Utah totals from the run that generated it and says so; the next image build's report is where the refreshed Utah count comes from. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
What's wrong
Hummingbird's base installs only
glibc-minimal-langpack, which providesCandC.UTF-8and nothing else. Any other locale a user selects — Region & Language,localectl, or a/etc/locale.confthat survived from a previous install — names data the image doesn't have, and everysetlocale()warns on every command:@KiKaraage's reading of
/etc/profile.d/lang.shis correct, and I confirmed it against the currentsetuppackage source: the reset block (lines 11–24) assignsC.UTF-8withoutexport, then thelocale.confloop (line 33)evals anexportof the original values over it. The safety net does nothing. That's a bug in Fedora'ssetuppackage — the fix there is trivial, but it's not this repository's to make.The fix
One line:
glibc-all-langpacksinpackages/utah.toml.public-hummingbird-x86_64-rpmsat 2.43-8.5.hum1, the same NVR as theglibc-minimal-langpackalready on the reporter's image, so the transaction adds a package without moving glibc.locale.confis quiet there. This is a parity gap the contract couldn't see, because the Bluefin package list doesn't name what its base image provides.glibc-langpack-enalone would fix the reporter's case (it carriesen_SG) and be ~200 MB smaller, but it would leave Region & Language a way to reproduce this bug in any other language. Matching Bluefin is the point.Verification
install-packages.py --checkvalidates; 96 tests pass.[gnome]is where it lives for now:[hardware](fix: ship device firmware and enable desktop hardware units #105) and a hypothetical[base]for "what Bluefin's base ships and Hummingbird's doesn't" would both fit better, but adding a section means wiringinstall-packages.pyandverify-rpm-contract.py, which fix: ship device firmware and enable desktop hardware units #105 already touches. Happy to move it once fix: ship device firmware and enable desktop hardware units #105 lands.check-reposcovers the first; @KiKaraage offered to retest on the X230 for the second, and this one is easy to confirm —locale -a | grep en_SGafter the update.🤖 Generated with Claude Code
https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
Generated by Claude Code