You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[quality] coverage-gap: both desktop contract gates (verify-desktop-contract.py, verify-gnome-extensions.py) have zero unit coverage #95
Two CI/build gates in scripts/ have no unit coverage at all:
scripts/verify-desktop-contract.py (179 lines) — runs in just check as --check (contract syntax) and from the Containerfile against the composed image (branding, os-release, image-info, Flatpak Brewfile parity, remote URL, enabled services).
scripts/verify-gnome-extensions.py (64 lines) — asserts all 9 bundled GNOME extensions exist and declare GNOME 51.
tests/ currently holds only test_iso_ci.py, test_live_kernel.py and test_package_resolution.py, which cover resolve-e2e-inputs.py, iso/scripts/live-kernel.py, install-packages.py and check-repo-availability.py. Neither verifier is referenced by any test.
These are fail-closed gates: if validate_contract stopped flagging a missing section, a relative path, a duplicate Flatpak ID or a relative Brewfile; or if parse_brewfile stopped matching flatpak "id" lines; or if unit_enabled started accepting static/masked; or if the GNOME check stopped noticing a missing metadata.json — every affected build would still report the contract as passing. Nothing today would catch that.
Recommendation
Add tests/test_desktop_contract.py (picked up by the existing python3 -m unittest discover -s tests -p "test_*.py") exercising:
validate_contract — valid contract, each missing section named, relative contract file, empty app list, duplicate Flatpak IDs, relative Brewfile; plus the shipped contracts/bluefin-desktop.toml validating clean.
Activity