Skip to content

[architect] install-source identity stated 3x with divergent names: packages/*.repo vs install-packages.py REPOS vs check-repo-availability.py REPOS #73

Closed

Description

@hivecommons-hive

Architecture Finding

Type: tech-debt / contract-duplication
Affected area: packages/hummingbird.repo, packages/utah-packages.repo, scripts/install-packages.py (REPOS, line 26), scripts/check-repo-availability.py (REPOS, lines 30-31)

The set of repositories Utah installs from — which repos, in which precedence order, at which URLs — is the image's install-source identity. It is currently stated three times:

  1. packages/hummingbird.repo + packages/utah-packages.repo — the actual yum repo configuration (IDs, baseurls, priorities).
  2. scripts/install-packages.py:26 — REPOS = ("utah-packages", "public-hummingbird-x86_64-rpms"), restating the repo IDs for --enablerepo flags.
  3. scripts/check-repo-availability.py:30-31 — REPOS = {"public-hummingbird": <url>, "utah-packages": <pages-url>}, restating the same two repos as a name→URL dict.

The copies have already diverged cosmetically: the checker keys Hummingbird as public-hummingbird, but the real repo ID is public-hummingbird-x86_64-rpms. The Justfile guards one direction textually (grep -q '"utah-packages"' scripts/install-packages.py, Justfile:63), which means the drift risk has bitten before — but the guard only covers one of the three statements.

Related: the TOML manifest reader section() is duplicated verbatim in check-repo-availability.py:35, install-packages.py:29, and verify-rpm-contract.py:31.

Impact

A repo rename, baseurl move, or added install source must be made in three places; miss one and the CI preflight (just check-repos) validates a different repository set than the image build installs from — the check passes while the build consumes something else.

Recommendation

Single-source the identity in packages/*.repo:

  • check-repo-availability.py derives its repo set by parsing packages/*.repo (section name = repo ID, baseurl = check URL). The factory repo's in-image file:///etc/utah-packages baseurl carries a ci-mirror: annotation naming the Pages URL the CI check queries instead.
  • install-packages.py derives its --enablerepo set from the same files (marker annotation), so a renamed repo cannot leave the installer enabling a nonexistent ID. Deferred: this half touches the Justfile:63 textual guard, and Justfile is occupied by open hold-gated PR refactor(flavors): make flavors.py the only flavor-to-image-name map #44; the install script region of Containerfile is occupied by [scanner] fix: create /usr/local/libexec parent dirs in script install step (Containerfile:81) #56. The PR attached to this issue implements only the checker half.
  • Longer term, extract the triplicated section() reader into one shared module (needs a Containerfile change to ship into the image — also deferred for the same occupancy reason).

Filed by architect agent (ACMM L5 — hold-gated mode)

🐝 Hive Agent: architect | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=architect backend=copilot model=kimi-k3 copilot=1.0.78

Activity

  1. added a commit that references this issue on Sep 19, 2026
    386cf18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/architectFiled or owned by the architect agent.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions