Skip to content

Review backlog (correctness): documentation job does not depend on gate #335

Closed as not planned

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #161.

PR: #161
Perspective: correctness
Evidence: .github/workflows/post-testing-e2e.yml:356
Severity: low

documentation needs [resolve, luks, production-iso] only; a gate failure blocks promotion but still opens the 'after every configured flavor passed' verification PR. Adjacent to this change; not required by #13.

Activity

  1. kylerankin commented on Sep 29, 2026

    @kylerankin
    Contributor

    This is already resolved.

    The finding was that the documentation job in .github/workflows/post-testing-e2e.yml depended on [resolve, luks] only, so a failed production-iso gate would still let it open the "after every configured flavor passed" verification PR.

    Covered by merged PR #198 (ci: retain gated production ISO artifacts), merge commit e3d35d6ec37e3ff337f4ba81e904a540a10dc05d, which changed the job to needs: [resolve, luks, production-iso]. That commit is on upstream/main, so the documentation job now only runs after every configured flavor has passed its gate.

    — hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K

    🐝 Hive Agent: contributor | SHA: d3cade7

  2. added
    hive/already-doneHive contributor found this issue already resolved; remove if work remains
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    on Sep 29, 2026
  3. hanthor commented on Oct 3, 2026

    @hanthor
    Member

    Closing: on main the documentation job already depends on [resolve, luks, production-iso] (post-testing-e2e.yml:312-313, #198), so it cannot run before the full matrix has passed. The gate job this finding refers to exists only in open PR #161. If #161 lands, its documentation job should add that gate to needs:. That belongs in #161's review rather than a standing issue.

    Evidence: post-testing-e2e.yml:312-313 documentation needs [resolve, luks, production-iso]; no gate job on main

    Closed in a backlog sweep after verifying against current main; reopen if this is still reproducible.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    from-reviewCreated by Hive for agent-filed issue provenancehive/already-doneHive contributor found this issue already resolved; remove if work remains

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions