Repository navigation
feat(long-tail): resolve paps output through prefixdevname (#505) - #897
hivecommons-hive[bot] merged 10 commits into
Conversation
…uefin#505) Summary: Resolve the last remaining long-tail projectbluefin#505 output, paps, by importing the current Fedora rawhide recipe, fixing a broken Source0 URL, and adding a verified SHA-512 source lock. paps converts text to PostScript/PDF and publishes the `paps` CLI plus the CUPS `texttopaps` filter. --- The dist-git import carried Source0 pointed at `github.com/dov/paps/archive/refs/tags/v%{name}/...`, which resolves to `/archive/vpaps/...` and 404s. Repoint Source0 at the upstream release asset `github.com/dov/paps/releases/download/v%{version}/paps-%{version}.tar.xz` (verified SHA-512, matches the Fedora lookaside). The legacy 0.6.8 build is kept on purpose: it is the sole producer of the CUPS `texttopaps` filter and the `paps.convs`/`29-paps.conf` CUPS integration, while the 0.8.1 meson build ships only the `paps` CLI and libpaps. - import: packages/paps from Fedora rawhide (commit 3de5ac3) - lock: config/upstream-sources.json (SHA-512 + Fedora lookaside fallback) - reconcile: remove paps from the projectbluefin#505 pending list; add to [resolved] - regenerate .packit.yaml packages block Closes projectbluefin#505. Hive-Run: python3 tools/import_rawhide.py paps --branch rawhide && just check && just test Hive-Plan: import recipe, fix broken Source0 URL, add source lock, reconcile backlog, regenerate packit config Hive-Spec: projectbluefin#505 — hive: backend=pi model=lemonade/ornith-1.5-35b-a3b-gguf-q6_k
194566f to
c2f2cdd
Compare
There was a problem hiding this comment.
Summary: This change adds the recipe for paps, a tool that turns plain text into printable PostScript, and fixes the download address Fedora's copy of the recipe gets wrong. The recipe itself checks out. Two things about the pull request's own description need fixing before merge: the description text was never filled in (it still shows a placeholder pointing at a temporary file), and it says it closes the whole package batch (#505) even though the batch still lacks the build and publishing proof that the batch asks for.
What I need from you: Replace the placeholder body with a real description and change Closes #505 to Refs #505.
Reviewed head e9ff7e649640622b7ca37eee6d5d3f9871f8f359.
intent-alignment
-
PR body is a literal placeholder and the closing keyword contradicts the batch skill (medium, in-scope). The PR body is the string
@/tmp/paps_pr_body.mdfollowed byCloses #505— the intended body file was never expanded, so the PR carries no disposition, build evidence, or remaining-output list.docs/skills/factory-build-backlog.md:146-148and:160-164require a partial batch PR to useRefs #<n>, neverCloses #<n>, until every named output has publication evidence; the batch's other entries (config/factory-build-backlog.toml:685perl-Unicode-Normalize,:686prefixdevname) have nopublished_run, and this entry (:688) is recipe-only. Merging as-is auto-closes #505 with none of its "Acceptance and proof" items recorded. Suggested body replacement:-@/tmp/paps_pr_body.md - -Closes #505 +Imports the Fedora rawhide `paps` recipe (dist-git 3de5ac33) with one change: Fedora's +`Source0` points at `github.com/dov/paps/archive/v%{name}/...`, which does not exist; +this uses the GitHub release asset `releases/download/v%{version}/paps-%{version}.tar.xz` +(SHA-512 matches Fedora's `sources`). The 0.6.8 tarball used for `texttopaps` is still +fetched from the Fedora lookaside via `packages/paps/sources`. + +Recipe-only record (`pr = 897`, no `published_run`); hosted build, NEVRA and runtime +evidence still outstanding for paps, perl-Unicode-Normalize and prefixdevname. + +Refs #505
style
- Title describes a range, not this change (low, in-scope). "resolve paps output through prefixdevname" copies the batch-issue naming pattern ("pam_passwdqc through prefixdevname") but the diff adds only
paps. Suggest:feat(long-tail): import paps recipe with working Source0 URL (#505).
Verified: Source0 in packages/paps/paps.spec:7 resolves (HTTP 302→200) and the SHA-512 in config/upstream-sources.json equals Fedora's sources entry; the spec is otherwise byte-identical to Fedora commit 3de5ac33; tools/source_pipeline.py:180-198 (bundled_sources) fetches the Source3 0.6.8 tarball from the lookaside using packages/paps/sources. All CI checks on this head pass.
No findings from: correctness, security, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@kylerankin this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
There was a problem hiding this comment.
Summary: Re-review of the paps packaging change after its latest update. The only change since the last review is a routine sync with the main branch (bookkeeping for an unrelated text library); nothing about paps itself changed. The one blocking problem from last time is still there: the description of this change is an unfilled placeholder, and it claims to finish a 16-package tracking issue when it delivers only one package. Fixing the description is enough.
What I need from you: Replace the PR body with a real description and change Closes #505 to Part of #505.
Reviewed delta e9ff7e6…b357d02 (merge of main, #894: slang moved to the imported list in config/factory-build-backlog.toml:220,257 and a reconciliation note in docs/skills/factory-build-backlog.md:1065-1068). The branch has since moved to cec6063, also a pure merge of main (#804 ibus recipes); neither merge touches packages/paps/.
intent-alignment — still present (in-scope)
PR body is literally @/tmp/paps_pr_body.md followed by Closes #505. Issue #505 ("resolve factory outputs pam_passwdqc through prefixdevname") lists 16 outputs with checkboxes; this diff adds only packages/paps/ and its config/factory-build-backlog.toml / config/upstream-sources.json / .packit.yaml entries. Merging as-is auto-closes the batch issue with 15 outputs unresolved. Suggested body:
-@/tmp/paps_pr_body.md
-
-Closes #505
+Import the paps recipe (Fedora `paps` 0.6.8 lineage with the carried patches), register it in
+`config/factory-build-backlog.toml`, `config/upstream-sources.json` and `.packit.yaml`, and add a
+tmt smoke test under `packages/paps/tests/basic/`.
+
+Part of #505 (resolves the `paps` output only; remaining outputs in that batch are unchanged).style — still present, advisory: title "resolve paps output through prefixdevname" mirrors the issue's range wording but the diff covers one package; feat(long-tail): import paps recipe (#505) would match the content.
No findings from: correctness, security, docs-currency.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @kylerankin holds the trusted tier in this hive's contributor registry. |
Import the Fedora rawhide
papsrecipe (0.6.8 lineage) and register it inconfig/factory-build-backlog.toml,config/upstream-sources.json, and.packit.yaml. Fedora'sSource0points at a non-existent path, so this uses the GitHub release asset instead (SHA-512 matches Fedora'ssources); thetexttopaps0.6.8 tarball is still fetched from the Fedora lookaside viapackages/paps/sources.Recipe-only record (
pr = 897); hosted build, NEVRA, and runtime evidence forpapsand the rest of that batch are still outstanding.Part of #505 (resolves the
papsoutput only; the batch's remaining outputs are unchanged).