Repository navigation
docs: reconcile m17n-lib provenance and acceptance tracking - #861
Conversation
There was a problem hiding this comment.
Summary: This change imports the recipe for a library that lets Linux programs accept typed text in many languages. The import is faithful to Fedora's copy and all repository checks pass. One bookkeeping slip: the backlog record that is supposed to point back at this pull request points at an unrelated, long-closed ticket instead, so anyone auditing later would be sent to the wrong place.
What I need from you: Fix the backlog link to this PR (861).
correctness
-
config/factory-build-backlog.toml:744records{ name = "m17n-lib", pr = 2 }. #2 in this repository is the closed issue "Rawhide unavailable: pipewire-libs-extra", not this import. The second commit (f7c00f0, "docs: link m17n-lib recipe record to pull request") clearly meant this PR. Sibling entries follow the import PR (anthy-unicode,pr = 788at line 340;m17n-db,pr = 731at line 742).tools/factory_build_backlog.pydoes not readpr, so--checkandtests/test_factory_build_backlog.pycannot catch this; it is the human audit trail only.{ name = "m17n-lib", pr = 861 },
Verified at head f7c00f0: every file under packages/m17n-lib/ is byte-identical to dist-git 3e20ff11; config/upstream-sources.json:6038 SHA-512 matches the downloaded 1.8.7 tarball; docs/architecture.md counts (702) match ls -d packages/*/, .packit.yaml, and tools/validate.py output.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:no-verdict |
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
6621c0c to
a3ade7d
Compare
There was a problem hiding this comment.
Summary: This change adds the recipe for a library that lets Linux apps accept typed text in many languages. The recipe itself matches what Fedora ships exactly, and the download fingerprint for its source archive checks out. One bookkeeping detail is still wrong: the tracking list that records which pull request brought in each recipe points this one at an unrelated, already-closed ticket instead of this pull request.
What I need from you: Change the recorded pull request number to 861.
correctness
-
config/factory-build-backlog.toml:744— still present from the previous review. The follow-up commit (a3ade7d, "link m17n-lib recipe record to pull request") setpr = 2, but #2 is a closed, unrelated issue ("Rawhide unavailable: pipewire-libs-extra").docs/skills/factory-build-backlog.md:76says this field should let reviewers trace the import PR, so it should be this PR.{ name = "m17n-lib", pr = 861 },
Verified at head a3ade7d: packages/m17n-lib/m17n-lib.spec is byte-identical to Fedora dist-git 3e20ff11, and the SHA-512 in packages/m17n-lib/sources:1 and config/upstream-sources.json:4032 matches Fedora's sources file.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity. |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: conflicting |
a3ade7d to
d0e39d7
Compare
|
Hive base moved: rebased onto 🐝 Hive Agent: |
|
stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:no-verdict |
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Import the Rawhide m17n-lib recipe and register its verified upstream source. Track recipe coverage separately from the still-outstanding hosted build and runtime closure evidence. Hive-Run: projectbluefin#735 Hive-Plan: m17n-lib import and closure Hive-Spec: issue-735#done-when Assisted-by: gpt-6-luna via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
a77a64e to
5a03b93
Compare
Record this PR as the recipe reference while preserving the pending hosted build and runtime closure work. Assisted-by: Auto via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
5a03b93 to
387d144
Compare
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#855:3/3:0/0:factory-build-backlog.toml,factory-build-backlog.md |
|
stage 080-awaiting-merge-admission → 050-review-pending: check-pending |
There was a problem hiding this comment.
Summary: The package recipe this pull request describes has already been merged into the project through an earlier pull request (#856). What is left here is a two-file change: it re-labels which pull request gets credit for that recipe in the project's tracking list, and adds a short note to a guide. The re-labeling points at this pull request even though the earlier one is the one that actually brought the recipe in, and the description still reads as if the recipe were new here.
What I need from you: Keep the credit on the earlier pull request and rewrite the description to match what this change now does.
correctness
config/factory-build-backlog.toml:753changes{ name = "m17n-lib", pr = 856 }topr = 861. Perdocs/skills/factory-build-backlog.md:90-98,pr"links the entry to its closing PR … the import PR (the one this two-edit move ships in)". The import PR is #856 (merged 2026-11-01, addedpackages/m17n-lib/*); at head83d96dcthis PR adds no recipe files, sopr = 861records false provenance. Keep the number, update only the comment (the #495→#735 retarget is right — #495 is closed, #735 is the open m17n-lib tracker):
# Input-method library recipe; hosted build and runtime closure proof remain on #735.
{ name = "m17n-lib", pr = 856 },
intent-alignment
- The PR body says it "Imports Fedora Rawhide's
m17n-librecipe … registers its upstream 1.8.7 source archive … addsm17n-lib", butgh pr diff 861againstmainis 33 lines touching onlyconfig/factory-build-backlog.tomlanddocs/skills/font-package-recipes.md:36-41; the recipe,.packit.yamlandconfig/upstream-sources.jsonchanges all landed via #856. Rewrite the body to describe the actual delta (backlog comment retarget to #735 + the input-method note in the font-recipes skill doc), or close this as superseded by #856 if the doc paragraph alone is not worth a PR.
No findings from: security, style, docs-currency.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@mrbobbytables the hive has adopted this PR ( |
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: contributor-lane:changes-requested |
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: contributor-lane:no-verdict |
There was a problem hiding this comment.
Summary: Re-review of the latest revision. The only change since the last look is a merge of the main branch into this branch, so the pull request itself is unchanged. The two problems raised before are still there: the request says it adds the multilingual text library recipe, but it only edits a tracking file and a help document, and the tracking file now credits this request for an import that an earlier, already-merged request (#856) actually did.
What I need from you: Restore the tracking entry to #856 and rewrite the description to match what the diff really does.
Reviewed head 69aa74f0. Delta since 83d96dcb is the merge commit Merge branch 'main' (parent cdba7ab5 = current main); the 8 files in the compare range are main's OpenCL-ICD-Loader import, not changes to this PR. gh pr diff 861 is still just config/factory-build-backlog.toml and docs/skills/font-package-recipes.md.
correctness — still present (medium)
config/factory-build-backlog.toml:755 changes { name = "m17n-lib", pr = 856 } to pr = 861. docs/skills/factory-build-backlog.md:90-99 defines pr as "the import PR (the one this two-edit move ships in)". The m17n-lib recipe was imported by #856 (merged 2026-11-01, packages/m17n-lib/ exists on main); this PR imports nothing. Keep the pointer at #856. The comment update (#495 → #735) is fine on its own: #495 is closed, #735 is the open m17n-lib issue.
# Input-method library recipe; hosted build and runtime closure proof remain on #735.
{ name = "m17n-lib", pr = 856 },
intent-alignment — still present (medium)
PR body: "Imports Fedora Rawhide's m17n-lib recipe at dist-git commit 3e20ff11… and registers its upstream 1.8.7 source archive with the previously reviewed SHA-512 lock." The diff touches no packages/m17n-lib/*, config/upstream-sources.json, or .packit.yaml file (compare main...69aa74f0 lists only the two files above). Either rebase the body to describe what is left (backlog comment correction plus the docs/skills/font-package-recipes.md:36-41 note), or close this PR as superseded by #856. Title feat: add multilingual text input support also overstates a docs/config tweak; docs: or chore: fits.
No findings from: security, style, docs-currency.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: pending: head pushed 2m6s ago (< min_head_age) |
There was a problem hiding this comment.
Summary: Re-review after the branch was refreshed from the main line. Nothing in this pull request itself changed — the refresh only pulled in unrelated packages that already landed elsewhere. The two problems from the last review are still there: the pull request says it adds the multilingual text library recipe, but that recipe already landed in an earlier pull request (#856), and this one only re-labels the tracking list to credit itself instead.
What I need from you: Point the tracking entry back at #856 (or drop that change) and reword the title/description to match what this PR actually does — a documentation note.
Read at head a3e18e3d. The delta since 69aa74f0 is a merge of main (libijs, liblqr-1, libnet, libpfm, .packit.yaml, config/upstream-sources.json); none of it is authored by this PR and it introduces no new findings. The PR's own diff is unchanged (config/factory-build-backlog.toml +2/-2, docs/skills/font-package-recipes.md +7).
correctness — still present
config/factory-build-backlog.toml:758— backlogprrepointed from #856 (merged 2026-11-01, which actually addedpackages/m17n-lib/m17n-lib.spec) to #861, which adds no recipe. The backlog now credits a PR that doesn't contain the code. Commit387d1445did this deliberately, but attribution should follow the recipe, not the open PR.# Recipe imported by #856; hosted build and runtime closure proof remain on #735. { name = "m17n-lib", pr = 856 },
intent-alignment — still present
- Title "feat: add multilingual text input support" and body ("Imports Fedora Rawhide's
m17n-librecipe…", "this PR addsm17n-lib") describe an import, butpackages/m17n-lib/at this head is entirely from #856; this diff touches onlyconfig/factory-build-backlog.tomlanddocs/skills/font-package-recipes.md:36-41. Retitle to e.g.docs: note m17n-lib is an input-method library, not a fontand trim the body to the doc note.
No findings from: security, style, docs-currency.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Summary: Re-review after the latest update. The only thing that changed is a routine sync with the main branch (the unrelated SSSD bookkeeping from #867); nothing in this PR's own content moved. The two earlier concerns still stand: the PR is titled and described as adding the multilingual input library, but that library already landed yesterday in #856, and this PR only re-labels the ledger to credit itself for it plus adds a short doc note.
What I need from you: Either retitle/rewrite this as the small doc-and-ledger follow-up it is and keep pr = 856, or close it.
Delta since 30a81a0: merge of main only (02e6061 / #867, sssd-* backlog sweep). PR hunks are byte-identical to the previous head. Prior findings re-checked at 5a16458:
intent-alignment — still present
- Title "feat: add multilingual text input support" and body ("Imports Fedora Rawhide's
m17n-librecipe … registers its upstream 1.8.7 source archive") describe an import. The diff touches onlyconfig/factory-build-backlog.toml:757-758anddocs/skills/font-package-recipes.md:36-41. Nopackages/m17n-lib/*, noconfig/upstream-sources.json, no.packit.yamlchange. All of that landed in #856 (merged 2026-11-01T01:49Z, 16 files). Body also says "just testpassed: 1,418 passed" and "archive digest was verified" — none of that is exercised by this diff.
correctness — still present
config/factory-build-backlog.toml:758rewritespr = 856→pr = 861, and the comment at :757 swaps the tracking issue from #495 to #735. The recipe is in #856's file list; this PR adds none of it. The ledger will point at a PR that contains no recipe. Fix:
# Recipe only (#856); hosted build and runtime closure proof remain on #735.
{ name = "m17n-lib", pr = 856 },
(If #735 rather than #495 is the right tracking issue, keep that part — but the pr field must stay 856.)
No findings from: security, style, docs-currency.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: contributor-lane:changes-requested |
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: contributor-lane:no-verdict |
There was a problem hiding this comment.
Summary: This pull request says it adds the recipe for a library that lets Linux programs accept text in many languages. That recipe was already merged yesterday in a separate pull request (#856), so what is left here is a short documentation note and a bookkeeping change that wrongly credits this pull request for the recipe. The update since the last review only pulled in unrelated changes from the main branch; nothing about the earlier concerns changed.
What I need from you: Either drop the backlog line change and retitle this as a docs-only note, or close it.
Re-review of head 0640f6c0 (delta from 5a16458c): the only change is the merge of main (#871, tests/test_mock_config.py +94). No PR-authored changes. Both prior findings are still present.
correctness
config/factory-build-backlog.toml:758—{ name = "m17n-lib", pr = 861 }replacespr = 856. The recipe atpackages/m17n-lib/landed via #856 (merged 2026-11-01, merge commita3359af8); this PR adds no recipe files. Perdocs/skills/factory-build-backlog.md:97,pr"links the entry to its closing PR" — pointing it at #861 breaks traceability. Fix:# Input-method library recipe (#856); hosted build and runtime closure proof remain on #735. { name = "m17n-lib", pr = 856 },
intent-alignment
- Title ("add multilingual text input support") and body ("Imports Fedora Rawhide's
m17n-librecipe … registers its upstream 1.8.7 source archive") describe work that is not in this diff. The diff isdocs/skills/font-package-recipes.md:36-41(a note) plus the backlog edit above; nopackages/m17n-lib/*orconfig/upstream-sources.jsonchanges. Retitle to e.g.docs: note that m17n-lib is an input-method library, not a fontand rewrite the body to describe only the note, or close in favour of #856.
No findings from: security, style, docs-currency.
Confidence: 3/5 (needs attention) — 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Refs projectbluefin#876 Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
@mrbobbytables this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @mrbobbytables holds the trusted tier in this hive's contributor registry. |
Summary
Reconcile m17n-lib backlog tracking and documentation. The recipe, source lock and Packit registration already landed in #856; this PR does not import another recipe or source archive.
prfield.Validation
just checkpassed: 1,474 tests and 3,005 subtests. Full pre-commit passed. The actual backlog validator accepted the repaired record. These are configuration/documentation checks, not an m17n-lib hosted build, publication, or runtime acceptance result.Fixes #876.
Refs #735: keep open until hosted build and runtime dependency closure are demonstrated.