Repository navigation
fix: restore factory validation baseline - #850
Conversation
Refresh architecture and backlog state from the current inventory. Add one inventory regeneration command, repair invalid imported YAML whitespace, and preserve workflow output values with grouped redirection. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:workflow-path |
1de0568
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @hanthor, head
Hive did not add the |
|
@hanthor this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Regenerate combined 680-recipe architecture and backlog state after #847 landed on main, and remove the prohibited historical DELTA session artifact carrying committed conflict markers. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:workflow-path |
There was a problem hiding this comment.
Summary: This pull request set out to fix a stale package count that was making the project's own test suite fail. That count has since been corrected on the main branch by another change, so what remains here is useful housekeeping: a one-step command to refresh generated files, matching guidance updates, removal of a leftover scratch file, and two small cleanups. The description still describes the original count fix, which no longer appears in the change — it should be reworded so reviewers know what they are merging.
What I need from you: @hanthor, update the title/body to match the current diff (suggested wording below).
Reviewed at head c9452ec (the PR moved on from 1de0568; merge-base with main is 2bc425c).
intent-alignment
- PR body describes a regeneration that is no longer in the diff (medium, in-scope). The body says it regenerates
docs/architecture.mdandreports/factory-build-backlog.jsonfrom a 679-recipe inventory (167/347/37; 159 pending). Against currentmainthe diff touches only.github/workflows/rebuild-rpms.yml,DELTA.md,Justfile,docs/contributing.md,docs/skills/factory-build-backlog.md,packages/powerstat/packit.yaml— neither generated file changes. Onmain2bc425c(after #847)tests/test_architecture_counts.pyalready passes (7 passed) andtools/factory_build_backlog.py --checkreports "consistent (166 entries, 158 pending)", so the numbers in the body are stale and #849's defect is already fixed upstream (and #849 itself says to close without a PR in that case). The rest of the diff —Justfile:41-46recipe, docs rewrites,DELTA.mddeletion (it carried committed conflict markers atDELTA.md:1and:127), the powerstat tab fix, theGITHUB_OUTPUTgrouping atrebuild-rpms.yml:429-433— is reasonable follow-on work but not what #849 asks for. Suggested body opening:and change-Restore the package factory's validation baseline without weakening any gate: - -- Regenerate architecture counts and backlog snapshot from the current 679-recipe inventory (167 backlog / 347 resolved / 37 wontfix; 159 pending). +The stale architecture counts from #849 were regenerated on main by #847. This PR adds the recovery tooling and guidance so the drift does not recur, plus small inherited cleanups: +
Fixes #849toCloses #849 (already fixed on main by #847)or drop it and close the issue by hand.
docs-currency
- Other skill docs still cite the raw generator commands (low, out-of-scope).
docs/skills/font-package-recipes.md:113-114anddocs/skills/repeated-mistakes.md:577,590,600still tell contributors to runrender_packit_config.py --write/render_architecture_counts.py --writedirectly whiledocs/contributing.mdanddocs/skills/factory-build-backlog.mdnow point atjust regenerate-inventory. The commands remain valid, so nothing is wrong today; worth a follow-up sweep.
No findings from: correctness, security, style.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
Place the inherited systemd user-unit preset macro in a post-install section rather than the build install script. Preserve the local boundary fix on future Rawhide imports. Assisted-by: GPT-6.1 via GitHub Copilot Signed-off-by: James Reilly <jreilly1821@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
stage 080-awaiting-merge-admission → 050-review-pending: contributor-lane:workflow-path |
Main now carries refreshed 681-recipe counts/backlog from #853. Drop the optional SC2129 style edit in rebuild-rpms.yml so this PR touches no pipeline paths and passes Canary immediately while landing just regenerate-inventory, the Rygel %post fix (#824), powerstat YAML fix, and prohibited DELTA.md cleanup. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
There was a problem hiding this comment.
Summary: This change adds a one-step "rebuild the generated inventory" command and the guidance to use it, and fixes a small packaging mistake in the rygel media server recipe. The code looks correct, but the pull request description still advertises two changes that are no longer in it (regenerated package counts and a workflow tidy-up) and says nothing about the rygel fix that is. Please bring the description in line with what the branch actually changes.
What I need from you: Update the PR description as suggested below.
Reviewed at head aa72fe12 (the PR moved past 25d65d3d while this review ran; the delta since the previous hive review at 1de05686 was read in full).
intent-alignment
-
PR body describes changes the diff no longer contains, and omits one it does (in-scope, still present from the previous review, now wider).
- "Regenerate architecture counts and backlog snapshot from the current 679-recipe inventory (167 backlog / 347 resolved / 37 wontfix; 159 pending)":
gh pr diff 850touches neitherdocs/architecture.mdnorreports/factory-build-backlog.json. Those files at head read 681 recipes (docs/architecture.md:133-144) andbacklog 165 / resolved 349 / wontfix 37 / pending 157(reports/factory-build-backlog.jsontotals/states), all inherited frommain(#847, #853), not produced by this PR. - "Group the rebuild workflow's three
GITHUB_OUTPUTwrites" and the "Grouped-output shell smoke" verification bullet: commitaa72fe12("drop non-CI workflow style edit") removed.github/workflows/rebuild-rpms.ymlfrom the diff. - The diff does add a
%postheader topackages/rygel/rygel.spec:79(from #851) and the matching paragraph indocs/skills/factory-build-backlog.md:1074-1080, which the body never mentions. That fix is outside #849's scope but is small, correct, and author-owned, so it is fine to keep — just say so.
Suggested replacement for the body's "Fix" and "Verification" sections:
## Fix Restore the package factory's validation baseline without weakening any gate: -- Regenerate architecture counts and backlog snapshot from the current 679-recipe inventory (167 backlog / 347 resolved / 37 wontfix; 159 pending). - Add `just regenerate-inventory` for Packit config, architecture counts and backlog state; keep `just check` read-only. - Update contributor and factory-backlog guidance to regenerate after combining current main and PR source changes, even when generated files auto-merge. - Remove invalid tab whitespace from imported Powerstat Packit YAML. -- Group the rebuild workflow's three `GITHUB_OUTPUT` writes without changing values, permissions, signing, sources or publication behavior. +- Delete the stale, conflict-marked `DELTA.md` scratch file. +- rygel: add the missing `%post` header so `%systemd_user_post` runs as an install scriptlet instead of inside `%install` (#851), and record that in the backlog skill. + +The architecture counts and backlog snapshot already match the 681-recipe inventory on `main` (#847, #853); this PR adds the command and guidance that keep them from drifting again. Fixes #849 ## Verification - `just check`: all configuration/runtime/backlog gates passed. - `pre-commit run --all-files`: passed after repairing the two inherited hook failures. - Ran `just regenerate-inventory` twice: `.packit.yaml`, `docs/architecture.md` and `reports/factory-build-backlog.json` remained byte-identical. -- Grouped-output shell smoke: resolved and empty cases both retain exactly `image`, `signer_ref`, and `seed` values.
- "Regenerate architecture counts and backlog snapshot from the current 679-recipe inventory (167 backlog / 347 resolved / 37 wontfix; 159 pending)":
No findings from: correctness, security, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Fix
Land the validation/recovery helpers and the Rygel scriptlet boundary fix cleanly against current
main(which now carries 681-recipe refreshed counts/backlog from #847 and #853):just regenerate-inventoryfor Packit config, architecture counts and backlog state; keepjust checkread-only.%postheader before%systemd_user_postinpackages/rygel/rygel.spec(from stacked fix(rygel): install user-unit post scriptlet #851, merged into this branch) so user-unit preset handling belongs to the installed RPM's post-install scriptlet rather than%install.packages/powerstat/packit.yaml.DELTA.mdsession artifact carrying committed conflict markers.Fixes #849
Fixes #824
Verification
just check: 1410 passed, 2871 subtests passed; all configuration/runtime/backlog gates passed.just regenerate-inventoryrun twice:.packit.yaml,docs/architecture.mdandreports/factory-build-backlog.jsonremained byte-identical.POSTINwas(none); repaired RygelPOSTINcontainsinstall-user-units rygel.service.No package build, publication or runtime availability is claimed. No protection, approval or check is bypassed.