Repository navigation
feat(dev-tools): add encrypted cloud files and package-signing keys - #838
Conversation
Record pull request projectbluefin#838 for the CryFS and distribution-gpg-keys recipe imports. Hive-Run: projectbluefin#485 Hive-Plan: issue-485-remaining-dev-tools Hive-Spec: issue-485#dev-tools-parity Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#819:6/8:0/0:.packit.yaml,factory-build-backlog.toml,upstream-sources.json,architecture.md,+4 |
There was a problem hiding this comment.
Summary: This change adds build recipes for an encrypted-cloud-storage tool, a set of Linux distribution signing keys, and three helper libraries the first tool needs. I checked the recipes against the Fedora originals they were copied from, confirmed the pinned sources and signatures match what upstream publishes, and ran the repository's own validators. Everything holds up; the only note is one helper recipe drops a small optional piece from the Fedora original for a reason that turns out not to apply, so it could simply be kept identical to Fedora.
Reviewed at head 7c17d43c. Verified: tools/validate.py (675 recipes), tools/factory_contract.py, tools/factory_build_backlog.py --check, targeted tests/test_generated_sources.py all pass; tag distribution-gpg-keys-1.123-1 resolves to the pinned commit 6f5f4883; all three cryfs patches git apply --check cleanly against the pinned 0.11.3 archive; the tracked cryptopp public key's SHA-512 equals the one Fedora's dist-git sources records, and both lookaside URLs the pipeline will hit (.sig, .gpg) return 200.
style (low, advisory)
packages/python-versioneer/python-versioneer.spec:26-32 drops Fedora's %pyproject_extras_subpkg -n python3-versioneer toml and the -x toml flag, with the comment that the extra "requires python3-toml, which is not available in the factory buildroot". That is not what the extra needs: versioneer 0.29's pyproject.toml declares toml = ["tomli; python_version < '3.11'"], so on the Python 3.15 buildroot this spec already targets (changelog 0.29-9) the extra resolves to nothing. The deviation buys nothing, drops the python3-versioneer+toml provide Fedora ships, and leaves a misleading comment. Suggest restoring the Fedora lines so the recipe stays byte-identical to its source:
--- a/packages/python-versioneer/python-versioneer.spec
+++ b/packages/python-versioneer/python-versioneer.spec
@@
%description -n python3-versioneer %_description
-# CryFS needs versioneer itself; its optional TOML extra requires python3-toml,
-# which is not available in the factory buildroot.
+%pyproject_extras_subpkg -n python3-versioneer toml
+
%prep
%autosetup -n versioneer-%{version}
%generate_buildrequires
-%pyproject_buildrequires
+%pyproject_buildrequires -x tomlNo findings from: correctness, security, intent-alignment, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Restored Fedora's toml extra subpackage and -x toml build-requires handling; this keeps the optional extra metadata without requiring python3-toml on supported Python versions. just check and just test pass: 1,407 passed, 2 skipped. 🐝 Hive Agent: |
|
CI note: Unit tests and all other validation jobs pass. The Canary check fails because this fork head has no successful maintainer-run Canary proof; its workflow explicitly requires a maintainer to run the fork Canary, which I cannot trigger as the contributor. 🐝 Hive Agent: |
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: conflicting |
|
@mrbobbytables the hive has adopted this PR ( |
20c40f9 to
ec0f19c
Compare
Record pull request projectbluefin#838 for the CryFS and distribution-gpg-keys recipe imports. Hive-Run: projectbluefin#485 Hive-Plan: issue-485-remaining-dev-tools Hive-Spec: issue-485#dev-tools-parity Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
Rebased onto current main to clear the merge conflict (resolved upstream-sources.json by union, regenerated factory-build backlog report and architecture counts with the repo tools). Original authorship preserved. The Canary check needs a maintainer to run the "Canary for a fork pull request" workflow for this head. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 |
|
stage 080-awaiting-merge-admission → 074-adopted-by-hive: base-branch-red:Factory build backlog |
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#652:3/5:0/0:.packit.yaml,factory-build-backlog.toml,upstream-sources.json,architecture.md,+2 |
Add recipes for CryFS, distribution-gpg-keys, and the packages CryFS needs to build. Hive-Run: projectbluefin#485 Hive-Plan: issue-485-remaining-dev-tools Hive-Spec: issue-485#dev-tools-parity Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Record pull request projectbluefin#838 for the CryFS and distribution-gpg-keys recipe imports. Hive-Run: projectbluefin#485 Hive-Plan: issue-485-remaining-dev-tools Hive-Spec: issue-485#dev-tools-parity Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
ec0f19c to
45483cd
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
@mrbobbytables this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
Refresh architecture and backlog state from the current inventory. Add one inventory regeneration command, repair invalid imported YAML whitespace, and preserve workflow output values with grouped redirection. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: required-check-failing:Canary |
Distinguish inventory-only recipe imports from source-generator changes that require maintainer-reviewed Canary proof. Preserve the privileged review boundary when a repair request names this expected failure. Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
The returned Canary failure is a maintainer-review prerequisite, not a package build failure: run 41220933599 skipped all build passes and failed in Pushed signed follow-up Blocked on maintainer review and dispatch, not an author-side code repair. After reviewing the final head, a maintainer must run Canary for a fork pull request ( 🐝 Hive Agent: |
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
Rechecked the returned head This is blocked on maintainer review/dispatch, not an author-side code defect. The existing source-generator change legitimately requires Canary. A maintainer must review this head and run No new commit or push was made: changing the head cannot supply the missing proof, and the relevant guidance was already corrected in the previous signed follow-up. The privileged gate and required generator support remain unchanged. 🐝 Hive Agent: |
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
Canary repair triage: the failing check on Maintainer action requested: review this exact head, manually copy the reviewed commit into an upstream branch, and run Canary with the repository publication permissions. The automatic Per the requester’s decision, this repair session stops here without adding a commit or pushing a new head: that would not supply the missing review and would invalidate any proof for this SHA. Recipe-scoped builds and runtime acceptance remain separate from the default pipeline Canary. 🐝 Hive Agent: |
Drop the style-only grouped GITHUB_OUTPUT edit carried in from the interim baseline branch; main intentionally kept the original workflow so recipe PRs do not touch pipeline paths. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
Follow-up |
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ive/issue-485-remaining
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@mrbobbytables this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
Assisted-by: Auto mode via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
hive-base-moved: merged projectbluefin/utah-packages main at 85df87e. Regenerated the architecture counts and backlog snapshot; just check and just test pass. 🐝 Hive Agent: |
|
Needs a decision, not a merge: check Head: verdict pending @602a184, 20/21 checks green, red: Canary, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Merge current main and regenerate derived inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Canary was run on this pull request at |
|
Needs a decision, not a merge: check Head: verdict pending @48880ec, 20/23 checks green, red: Canary, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
stage 080-awaiting-merge-admission → 072-returned-to-contributor: conflicting |
|
@mrbobbytables the hive has adopted this PR ( |
Preserve all five cryfs-family source locks and both generator/source-location proof requirements while removing obsolete committed counts. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Canary was run on this pull request at |
|
@mrbobbytables this PR has a new head without confirmed hive push evidence, so the hive has handed this PR back to you ( |
|
@mrbobbytables this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Needs a decision, not a merge: check Head: verdict pending @eef95fe, 29/33 checks green, red: Canary, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Summary: Bluefin’s software package builder is missing a tool for encrypted cloud files and a collection of keys used to verify software packages. This change adds recipes for both, along with the support packages needed to build the encrypted-file tool. It helps the builder offer a more complete set of developer tools.
What I need from you: Review the recipes; keep this batch open until hosted builds, publication, and runtime checks are complete.
Changes
Validation
just checkandjust testpassed (1,407 tests; 2 skipped in each run).Refs #485 — recipe imports are done; hosted builds, publication, dependency solving, and runtime proof remain.
🐝 Hive Agent:
contributor| SHA:22a88dcc— hive: backend=copilot model=claude-fable-5.1