Skip to content

feat: add missing desktop collection library - #760

Merged
Danathar merged 2 commits into
projectbluefin:mainfrom
thatguywob:hive/484-libgee
Oct 28, 2026
Merged

Danathar merged 2 commits into
projectbluefin:mainfrom
thatguywob:hive/484-libgee

Conversation

@thatguywob

@thatguywob thatguywob commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary: This adds the build recipe for Libgee, a library that gives desktop software common ways to store and organize data. Neither of the project's package repositories currently supplies it. This prepares the missing library for building; it does not yet establish that users can install it.


Refs #484 (partial: imports Libgee; the other four missing source families and build, publication, and runtime acceptance remain open).
Consumer tracking: projectbluefin/utah#391.

What changed

  • Import the unmodified Fedora Rawhide libgee recipe at commit 40477dc7c61bd836edce2aac2b1c4b6df5d14728, recording provenance with tools/import_rawhide.py.
  • Lock upstream https://download.gnome.org/sources/libgee/0.20/libgee-0.20.8.tar.xz. Downloaded bytes match the imported manifest's SHA-512: 9af883bb4b2c25c429271201e634d1851378631b913bab282fe432b2b76a44674111e65caa99269fd403454c87b5474f2567c554bddd0b3ea58ca6e138c311e1.
  • Register the recipe in Packit, regenerate architecture counts and the backlog report, and move libgee into the recipe-import closing records. The original 551-name audit partition is preserved.
  • Document why the recipe retains Vala regeneration, its compiler dependency, and make check. Correct the guide's remaining-output list.

Output disposition

Binary output Source recipe Evidence / remaining work
libgee packages/libgee/libgee.spec, version 0.20.8 Recipe and source lock added here. No built NEVRA, publication, solver transaction, or runtime result claimed.
libgee-devel Same source recipe Development subpackage declared by the imported recipe; no separate import.
imath, libmediaart, libwnck3, rygel Not imported here Remain pending for #484.
Other nine outputs in #484 Existing recipes Merged PR #747 records their publication evidence; no new publication or runtime claim here.

Repository snapshot evidence

Queried on 2026-10-28 at 03:33 UTC. Neither primary metadata set contains libgee (or the other four still-missing source-family names).

  • Factory: ghcr.io/projectbluefin/utah-packages@sha256:218c483f4c5258b865244dc55203f6614e09519f05eb213ddb36bc596024ec23.
  • Factory repomd SHA-256: a1be663dddefe2a391e04f09c58e13886544eb12b071d0483beb7c89ef40a8a8; compressed primary SHA-256: d49bc92998b7ec7cfad8d7f1b2e7508b61c2bf96f6db834389eb4e0f5b9d9ce4.
  • Hummingbird: https://packages.redhat.com/api/pulp-content/public-hummingbird/x86_64/; repomd SHA-256: 1e65e978ef506463967aa33deb54604167c44834d27d3da384bd1f290ed58f85; compressed primary SHA-256: 2f3ec264cd84e3113468065a391ac18a6697ea8138c9e66f97beae02b8eeb698.

This establishes a missing output, not runtime dependency closure.

Validation

  • just check: passed, including python3 tools/factory_build_backlog.py --check and 1,390 tests (2 skipped).
  • just test: 1,390 passed, 2 skipped.
  • pre-commit run --all-files: two pre-existing failures, both in files identical to upstream/main: a tab at packages/powerstat/packit.yaml:4 and actionlint/ShellCheck SC2129 at .github/workflows/rebuild-rpms.yml:367. All other hooks passed after the whitespace fixer.
  • Pre-commit on every changed file: passed.
  • Scoped hosted build attempted with gh workflow run canary.yml --repo thatguywob/utah-packages --ref hive/484-libgee -f 'lane_packages=["libgee"]' -f lane_backend=hermetic; Hive's command allowlist rejected workflow dispatch (surface_allowlist). No run was started and no gate was bypassed. A reviewed, scoped hosted build remains required, followed by publication and a representative library exercise against factory plus Hummingbird only.

— hive: backend=codex

Refs #484


🐝 Hive Agent: contributor | SHA: e735958f

Import the Fedora libgee recipe and lock its upstream 0.20.8 archive. Register the build and reconcile the recipe backlog without claiming publication or runtime closure.

Hive-Run: projectbluefin#484
Hive-Plan: issue-484/Implementation-3
Hive-Spec: projectbluefin#484#exact-scope-libgee
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds the build recipe for one missing desktop library and is sound as an import. But the description ends with a line that tells GitHub to close the whole tracking issue when it merges, even though the description itself says four of the issue's libraries are still missing and nothing has been built or published yet. Merging as-is would mark unfinished work as done.

What I need from you: Replace the trailing Closes #484 with Refs #484 (or delete it) before merge.


intent-alignment

  • PR body auto-closes #484 while describing partial work. The body opens with Refs #484 (partial: imports Libgee; the other four missing source families and build, publication, and runtime acceptance remain open) and the output table lists imath, libmediaart, libwnck3, rygel as "Remain pending for #484" — yet the body ends with Closes #484. #484 states "this batch closes only when every named output is resolved or explicitly blocked by a linked decision" and its acceptance items (hosted build run URLs, NEVRAs, Hummingbird+factory runtime resolution) are all unmet here, by the PR's own account. The guide this PR edits already warns about exactly this: docs/skills/factory-build-backlog.md:257-259 — "a trailing Closes still auto-closes the issue even when the summary describes partial progress." config/factory-build-backlog.toml:340-341 likewise records libgee as "Recipe import only; build, publication and runtime proof remain on #484", which cannot remain true if #484 is closed on merge. Fix: edit the PR description so the last reference reads Refs #484.

Verified for the record: packages/libgee/libgee.spec is byte-identical to Fedora rawhide 40477dc7 (the commit in .hummingbird-upstream.json:5); the locked tarball's SHA-512 in config/upstream-sources.json:6063 and packages/libgee/sources:1 matches a fresh download; the 633 counts in docs/architecture.md:81,133-138,143,163 match packages/ and upstream-sources.json at head.

No findings from: correctness, security, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

Require a live PR description readback after pushes and automation so generated closing footers cannot mark unfinished batches complete.

Refs projectbluefin#484

Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This adds the build recipe for Libgee, a helper library many desktop programs use to store lists and lookup tables. I checked that the recipe is a byte-for-byte copy of Fedora's, that the locked download matches its fingerprint, that the repository's own consistency checks still pass, and that the earlier complaint about the description auto-closing the tracking issue is fixed. Only two small tidy-ups remain, neither blocking.


Reviewed at head e4dd0bd. Verified: packages/libgee/{libgee.spec,sources,.packit.yaml,monitoring.toml,.gitignore} are identical to src.fedoraproject.org/rpms/libgee at 40477dc (current rawhide tip); libgee-0.20.8.tar.xz SHA-512 matches config/upstream-sources.json:6060-6064; ls -d packages/*/, .packit.yaml:packages, upstream-sources.json all count 633; tools/validate.py → 633 (628 rawhide, 5 upstream); tools/factory_build_backlog.py --check passes; tests/test_architecture_counts.py tests/test_factory_build_backlog.py 52 passed. PR body now uses Refs #484 only (prior review's Closes finding resolved).

style

  • low — config/factory-build-backlog.toml:341: the [resolved] header (line 338) says each entry records "package name and the commit that closed the gap", but the new record omits the PR. Two older entries (libshaderc:376, mtools:421) also omit it, so advisory only.
        { name = "libgee", pr = 760 },
    

intent-alignment

  • low — docs/skills/factory-build-backlog.md:258-261 adds general PR-description hygiene guidance ("Repeat the live-body readback after the push…") unrelated to Libgee and not mentioned in the PR body's "What changed". Harmless, but it is process text riding on a package import; consider a separate docs PR or a one-line mention in the body.

No findings from: correctness, security, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @e4dd0bd, 21/21 checks green, soak 30m0s elapsed. Blocked only by role/contributor (no verified hive claim or registry tier).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@Danathar
Danathar merged commit ebef94d into projectbluefin:main Oct 28, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants