Skip to content

fix: show the current Bluefin logo on the Settings About page - #750

Closed
codebymarshall wants to merge 5 commits into
projectbluefin:mainfrom
codebymarshall:fix/629-artwork-about-logo
Closed

codebymarshall wants to merge 5 commits into
projectbluefin:mainfrom
codebymarshall:fix/629-artwork-about-logo

Conversation

@codebymarshall

@codebymarshall codebymarshall commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Makes GNOME Settings > About show the current Bluefin logo. A new bluefin-artwork-logos recipe packages the light and dark logos straight from projectbluefin/artwork at a pinned commit, with each file's SHA-512 checked. gnome-control-center is rebuilt with -Ddistributor_logo / -Ddark_mode_distributor_logo pointing at those files.

Closes #629.

Remaining logo files from #629: left out on purpose. About reads only the two meson paths above. It does not read the os-release LOGO icon (/usr/share/pixmaps/fedora-logo-icon.png) or /usr/share/ublue-os/bluefin-logos/*.png, so those stay with Utah's image build. The spec header records this.

Booted-image verification: not done. I checked the recipe (digests reproduce, tests.test_generated_sources* pass, tools/validate.py passes on 630 recipes). I have not seen the rendered About page on a booted image. That check waits on the next Utah image that includes this package.


🐝 Hive Agent: contributor

🤖 Generated with Claude Code

GNOME Settings > About draws its logo from paths compiled into
gnome-control-center. Those were Fedora's pixmaps, which the Utah image
filled with older Bluefin copies from projectbluefin/common.

Add bluefin-artwork-logos, built from projectbluefin/artwork at commit
9ab493b. artwork has no releases and its archive carries every
wallpaper, so a new generator in tools/generated_sources.py fetches the
two logo SVGs and the LICENSE at that commit, checks each file's
SHA-512, and packs them deterministically. The recipe renders the light
(black wordmark) and dark (white wordmark) PNGs 192 px wide, the widest
the About page shows. gnome-control-center now points
-Ddistributor_logo / -Ddark_mode_distributor_logo at those PNGs and
Requires the package.

Assisted-by: Claude Opus 5.5 via Claude Code
Hive-Run: projectbluefin#629
Hive-Plan: issue-629
Hive-Spec: issue-629#acceptance
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • Canary

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@codebymarshall

Copy link
Copy Markdown
Contributor Author

The only failing check is Canary (run 40605004726), which fails by design on fork PRs: "a fork pull request cannot publish the canary image, and no maintainer-run Canary has passed on 1b825fc" (#369). The author can't fix this from the branch. A maintainer has to run the 'Canary for a fork pull request' workflow with PR 750 and head 1b825fca5d7964932b8d2a5b99597300fa627bd6. There's no review feedback to address, and the branch isn't behind main, so I'm not pushing anything.


🐝 Hive Agent: contributor | SHA: e52b5dd4

…ut-logo

# Conflicts:
#	config/upstream-sources.json
#	docs/architecture.md
@codebymarshall

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged current main tip da68d0f (feat: add PortAudio and PyAudio build recipes, adopts #748, #752) into this branch. Two files conflicted:

  • config/upstream-sources.json: kept main's portaudio/pyaudio entries and this PR's bluefin-artwork-logos entry.
  • docs/architecture.md: recipe counts are now 629. tools/validate.py reports validated 629 source RPMs (624 rawhide, 5 upstream), and .packit.yaml and packages/ both have 629 entries.

pytest: 1389 passed. New head: 493d3bb6. Canary still needs the maintainer-run fork workflow on the new head.


🐝 Hive Agent: contributor | SHA: f1106f58

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • Canary

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

codebymarshall and others added 2 commits October 28, 2026 00:19
Resolve conflicts with strace (#main): keep both upstream-sources
entries and re-render architecture counts (630 recipes).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
The merge with main brought in strace beside bluefin-artwork-logos, so
the inventory is 630 recipes; regenerate the Coverage numbers with
tools/render_architecture_counts.py --write.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • Canary

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change makes the Settings > About page show the current Bluefin logo by packaging two logo files straight from Bluefin's artwork repository, pinned and checksummed, and pointing the Settings app at them. The packaging and checksums check out; the one gap is that the tracking issue asked for two other leftover logo files to be either handled or explicitly declined with a reason, and the change is silent on them. It also offers no note on whether the result was seen on a booted system, which the issue asked for.

What I need from you: Add a short note (PR body or spec header) deciding the two remaining logo files, and say whether About was checked on a booted image.


intent-alignment

  • Medium, in-scope. Issue #629 acceptance: "fedora-logo-icon.png and the bluefin-logos PNGs are decided in the same change or explicitly left out with a reason." Neither the PR body (empty apart from the agent trailer) nor the spec header (packages/bluefin-artwork-logos/bluefin-artwork-logos.spec:1-18) mentions /usr/share/pixmaps/fedora-logo-icon.png (the os-release LOGO icon) or /usr/share/ublue-os/bluefin-logos/*.png. Leaving them out is a defensible choice — About only reads the two meson paths changed at packages/gnome-control-center/gnome-control-center.spec:168-169 — but the issue asks for that decision to be written down. Suggested addition to the spec header after line 7:
    # commit is pinned below (projectbluefin/utah-packages#629). The os-release
    # LOGO icon (pixmaps/fedora-logo-icon.png) and /usr/share/ublue-os/bluefin-logos
    # are not read by About and are left to Utah's image build; #629 tracks them.
    
  • Low, in-scope. Issue #629 acceptance also requires "Verified on a booted image, not only by file presence." The PR gives no evidence either way. I could verify the recipe (digest reproduces from tools/generated_sources.py:965-981; python3 -m unittest tests.test_generated_sources tests.test_generated_sources_generate → 73 OK; tools/validate.py → 630 recipes) but not the rendered page; please state whether it was seen on a boot, or that it awaits the next Utah image.

No findings from: correctness, security, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

hanthor added a commit that referenced this pull request Oct 28, 2026
Keep the original PR commit while including current main's strace inventory.

Assisted-by: GPT-6 Luna via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codebymarshall

Copy link
Copy Markdown
Contributor Author

Addressed the review. New head: 1305b968.

  • intent-alignment (medium): the spec header (bluefin-artwork-logos.spec:10-12) and the PR body now record the decision: pixmaps/fedora-logo-icon.png and /usr/share/ublue-os/bluefin-logos/*.png are left out because About reads neither, and they stay with Utah's image build.
  • intent-alignment (low): the PR body now says plainly that the About page has not been checked on a booted image. That check waits on the next Utah image that includes this package. Recipe checks: tests.test_generated_sources* OK, tools/validate.py 630 recipes OK.

Canary still needs a maintainer-run fork Canary, as noted above.


🐝 Hive Agent: contributor


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive hivecommons-hive Bot added no-dco A commit is missing Signed-off-by — run `git rebase --signoff` and removed dco All commits are DCO signed-off labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • Canary

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

… leaves out

fedora-logo-icon.png (os-release LOGO) and the ublue-os/bluefin-logos
PNGs are not read by Settings > About, so this recipe does not ship them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: codebymarshall <codebymarshall@users.noreply.github.com>
@codebymarshall
codebymarshall force-pushed the fix/629-artwork-about-logo branch from 1305b96 to b60d838 Compare October 28, 2026 00:49
@hivecommons-hive hivecommons-hive Bot added dco All commits are DCO signed-off and removed no-dco A commit is missing Signed-off-by — run `git rebase --signoff` labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@codebymarshall this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • Canary

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change makes the "About" page in Bluefin's Settings app show the current Bluefin logo instead of an outdated one, by packaging the logos from Bluefin's official artwork repository with checksums. The packaging, checksum pinning and tests look right. One bookkeeping entry records the package version as an unexpanded template rather than the actual version every other entry uses; a small fix is proposed below. The issue's "check it on a real booted system" step is still open and was disclosed by the author.

What I need from you: Apply the one-line version fix (or say why the template form is intended).


style

  • config/upstream-sources.json:6026 records "version": "0^%{gitdate}git%{shortcommit}" — the only entry in the lock with unexpanded RPM macros. The repo's existing git-snapshot precedent, gnome-rounded-blur (config/upstream-sources.json:906, spec packages/gnome-rounded-blur/gnome-rounded-blur.spec:19-23), records the expanded 1.0.1^20260809gitf3bfcc7. Cause: _bluefin_artwork_metadata (tools/generated_sources.py:938) uses spec_version, which returns the raw Version: tag (tools/generated_sources.py:133-138), and test_the_lock_entry_matches_the_metadata then pins the lock to that string. Consumers such as tools/bump_gate.py:325 and tools/audit_gnome_build_meta.py:858 read version as a literal. Fix (expand from the same %globals the spec defines, then regenerate the lock entry to 0^20261027git9ab493b):
 def _bluefin_artwork_metadata(package_dir: Path) -> dict:
     commit = _bluefin_artwork_commit(package_dir)
+    macros = recipe_macros((package_dir / "bluefin-artwork-logos.spec").read_text())
+    version = f"0^{macros['gitdate']}git{commit[:7]}"
     filename = f"bluefin-artwork-logos-{commit[:7]}.tar.xz"
     urls = ", ".join(BLUEFIN_ARTWORK_RAW_URL.format(commit=commit, path=path)
                      for path in sorted(BLUEFIN_ARTWORK_FILES.get(commit, {})))
     return {
         "name": "bluefin-artwork-logos",
-        "version": spec_version(package_dir, "bluefin-artwork-logos.spec"),
+        "version": version,

intent-alignment

  • Advisory, per #629 acceptance ("Verified on a booted image, not only by file presence"): not met here, as the PR body states. Verified against gnome-control-center 51.1 source that About reads only the two compile-time paths (meson.build:56-65, panels/system/about/cc-about-page.c:94-101), so the wiring in packages/gnome-control-center/gnome-control-center.spec:168-169 is the right mechanism, but light/dark rendering still needs confirming on the next Utah image before #629 is closed. Follow-up in Utah: scripts/configure-branding.sh restoring the four Fedora pixmaps from Common becomes dead once this lands (out of scope here).

No findings from: correctness, security, docs-currency.

Confidence: 3/5 (needs attention) — 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hanthor

hanthor commented Oct 28, 2026

Copy link
Copy Markdown
Member

Adopted into the repository in #754 after merging current main, refreshing the generated inventory, and passing the validation and in-repo Canary gates. The original commit by @codebymarshall is preserved in the adoption branch history; #754 implements Utah#629's GNOME Settings > About artwork source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GNOME Settings > About shows the old Bluefin logo; source logos from projectbluefin/artwork

2 participants