Skip to content

feat: add a library for text-based programs - #710

Closed
j1mc wants to merge 1 commit into
projectbluefin:mainfrom
j1mc:hive/507-long-tail-followup
Closed

j1mc wants to merge 1 commit into
projectbluefin:mainfrom
j1mc:hive/507-long-tail-followup

Conversation

@j1mc

@j1mc j1mc commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary: This adds the build recipe for a library used by text-based programs. The project can now prepare that library for its operating system, but it still needs a hosted build and a working installation test before users can rely on it.

What I need from you: Review the change and run the hosted package build for this commit.


Changes

  • Import the Fedora Rawhide slang source recipe at commit 354e9920fa876d53ab95bf82747481306976bb51, preserve its source tree and test patch, lock the upstream 2.3.3 release, and register the recipe in Packit.
  • Regenerate the package counts and backlog report. The slang entry stays in the long-tail area as already_recipe; it is not a runtime or publication claim. Move its catalog record after the hosted build and publication are verified.
  • Document the target-dependent Oniguruma option and the distinction between the slang library and slang-slsh interpreter in the backlog skill.

Refs #507 — partial source-family work only. The remaining outputs, publication and permitted-repository runtime checks stay open. Consumer tracking: projectbluefin/utah#263.

Evidence

  • Upstream archive: https://www.jedsoft.org/releases/slang/slang-2.3.3.tar.bz2. The downloaded SHA-512 f882f09e3fcd53427de0f233c9fc3ab15497f2323007be9a084696c8cf810ffe2726cd003149e757df26198b390b9f8c1ff411dc6473513457bd0f94722f8490 matches the imported sources file.
  • Factory metadata inspected 2026-10-27: ghcr.io/projectbluefin/utah-packages@sha256:710195827218db354cd1d0033d68db8b96efec97f1aaf3f45f8973479c6e7215, publishing run 40481255792, revision 142705c7428834e5bff92ffd7e917a7c8c461de5: no slang or slang-slsh binary. That snapshot includes rpcbind, simdutf, soundtouch, sso-mib-libs, and tslib; their publication does not prove installation or behavior. The other named outputs are not present in this snapshot. The independent reconciliation PR feat: mark the text-conversion and touchscreen libraries as published #709 covers catalog records for simdutf and tslib.
  • Hummingbird primary metadata fetched 2026-10-27 10:27 UTC contains no slang: repomd.xml SHA-256 f62ead89d03e5fea872b0a5ef00be106baf0f3dbba57fea3fda5ba210773f5d5; compressed primary SHA-256 f89827b80ed34948489dfc235d5baa77a7d8de5d807cd8b96cdac12f1a37cd1e.
  • The imported spec retains make check; it builds the library and the slang-slsh interpreter separately. Its Oniguruma build option depends on the target's Fedora macro, so build-time and runtime dependencies must be confirmed from the actual hosted build.

Validation

  • python3 tools/factory_build_backlog.py --check: passed.
  • just check: passed (1396 passed, 2 skipped).
  • just test: passed (1396 passed, 2 skipped).
  • pre-commit run --all-files: unavailable; pre-commit is not installed. git diff --check reports whitespace in the unchanged upstream recipe, patch and gating file; the repository's hooks intentionally exclude imported package files from whitespace rewriting.
  • Attempted gh workflow run canary.yml -R j1mc/utah-packages --ref hive/507-long-tail-followup -f 'lane_packages=["slang"]' -f lane_backend=hermetic; the hive command allowlist refused workflow dispatch before a run was created. No build NEVRA, published digest for this change, dependency solver result or payload exercise is claimed. A reviewed-fork hosted run and installation against only Hummingbird plus the factory remain necessary before resolving the catalog record or claiming runtime parity.

— hive: backend=pi model=openrouter/openai/gpt-6.1-terra

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recipe import looks correct to me; I checked it against Fedora rather than reading the diff alone.

  • packages/slang/slang.spec is byte-identical to src.fedoraproject.org/rpms/slang at 354e9920 (the commit recorded in packages/slang/.hummingbird-upstream.json); diff produced no output.
  • packages/slang/sources and config/upstream-sources.json:5191-5195 carry the same sha512 (f882f09e…f8490) that Fedora's sources file lists for slang-2.3.3.tar.bz2.
  • On this head: python3 tools/validate.py → validated 582 source RPMs (578 rawhide, 4 upstream), matching the docs/architecture.md counts you updated; python3 tools/factory_build_backlog.py --check → snapshot consistent (298 entries, 269 pending).
  • Live image (projectbluefin/utah-packages:latest, @sha256:7101958…) has no slang and nothing providing oniguruma, so the body's "no runtime or publication claim" framing is accurate.

Open question, not a defect (you already flag it at slang.spec:1-5): %if 0%{?fedora:1} turns on BuildRequires: oniguruma-devel. Whether the pinned buildroot defines %fedora, and whether oniguruma-devel resolves there, is only answerable from the hosted build — if it fails on that BuildRequires, %bcond_with oniguruma via a build-time --without is the smallest fix.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @2611957, 21/21 checks green, soak 30m0s elapsed. Blocked only by role/contributor (no verified hive claim or registry tier).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing labels Oct 27, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@j1mc this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity.

Import the Fedora recipe and lock its upstream release. Keep the backlog entry open until the hosted build and runtime checks establish availability.

Hive-Run: projectbluefin#507
Hive-Plan: long-tail source-family recipe
Hive-Spec: issue-507#implementation
Assisted-by: openrouter/openai/gpt-6.1-terra via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: j1mc <j1mc@users.noreply.github.com>
@j1mc
j1mc force-pushed the hive/507-long-tail-followup branch from 2611957 to 955aa3e Compare October 27, 2026 12:43
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change imports the build recipe for S-Lang, a small programming library used by text-mode programs, copied unchanged from Fedora. I checked that the copied files match Fedora exactly, that the download is pinned by checksum, that the regex library it needs at runtime is available in the base repository, and that the project's own consistency checks pass. The only thing I'd add is a backup download address, since the project's own notes ask for one on every import.


style

  • low — config/upstream-sources.json:5205-5210: the new slang entry has no fallback_urls. docs/skills/repeated-mistakes.md:558 ("Add the Fedora lookaside as fallback_urls, never as url") and docs/skills/factory-build-backlog.md:231-233 ask for the lookaside on imports so tools/source_pipeline.py can retry when jedsoft.org is down. The lookaside object for this SHA-512 exists today.

        {
          "name": "slang",
          "version": "2.3.3",
          "url": "https://www.jedsoft.org/releases/slang/slang-2.3.3.tar.bz2",
          "filename": "slang-2.3.3.tar.bz2",
          "sha512": "f882f09e3fcd53427de0f233c9fc3ab15497f2323007be9a084696c8cf810ffe2726cd003149e757df26198b390b9f8c1ff411dc6473513457bd0f94722f8490",
          "fallback_urls": [
            "https://src.fedoraproject.org/repo/pkgs/rpms/slang/slang-2.3.3.tar.bz2/sha512/f882f09e3fcd53427de0f233c9fc3ab15497f2323007be9a084696c8cf810ffe2726cd003149e757df26198b390b9f8c1ff411dc6473513457bd0f94722f8490/slang-2.3.3.tar.bz2"
          ]
        }
    

Verified at head 955aa3e: slang.spec, slang-sighuptest.patch, sources, gating.yaml, plans.fmf, ci.fmf are byte-identical to dist-git commit 354e992; config/buildroot-image pins fedora:44 so %{?fedora} is set and the Oniguruma branch (packages/slang/slang.spec:1-2,18) is taken — oniguruma/oniguruma-devel are present in current Hummingbird primary metadata, so the runtime libonig dependency resolves for the publish gate; tools/factory_build_backlog.py --check, tools/validate.py (584/580) and the packit/architecture renderers produce no drift.

No findings from: correctness, security, intent-alignment, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1

@hanthor

hanthor commented Oct 27, 2026

Copy link
Copy Markdown
Member

Adopted and merged via #719.

@hanthor hanthor closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants