Repository navigation
Conversation
There was a problem hiding this comment.
Recipe import looks correct to me; I checked it against Fedora rather than reading the diff alone.
packages/slang/slang.specis byte-identical tosrc.fedoraproject.org/rpms/slangat354e9920(the commit recorded inpackages/slang/.hummingbird-upstream.json);diffproduced no output.packages/slang/sourcesandconfig/upstream-sources.json:5191-5195carry the same sha512 (f882f09e…f8490) that Fedora'ssourcesfile lists forslang-2.3.3.tar.bz2.- On this head:
python3 tools/validate.py→validated 582 source RPMs (578 rawhide, 4 upstream), matching thedocs/architecture.mdcounts you updated;python3 tools/factory_build_backlog.py --check→snapshot consistent (298 entries, 269 pending). - Live image (
projectbluefin/utah-packages:latest,@sha256:7101958…) has noslangand nothing providingoniguruma, so the body's "no runtime or publication claim" framing is accurate.
Open question, not a defect (you already flag it at slang.spec:1-5): %if 0%{?fedora:1} turns on BuildRequires: oniguruma-devel. Whether the pinned buildroot defines %fedora, and whether oniguruma-devel resolves there, is only answerable from the hosted build — if it fails on that BuildRequires, %bcond_with oniguruma via a build-time --without is the smallest fix.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1
|
Ready for a human merge: verdict approved @2611957, 21/21 checks green, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
|
@j1mc this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity. |
Import the Fedora recipe and lock its upstream release. Keep the backlog entry open until the hosted build and runtime checks establish availability. Hive-Run: projectbluefin#507 Hive-Plan: long-tail source-family recipe Hive-Spec: issue-507#implementation Assisted-by: openrouter/openai/gpt-6.1-terra via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: j1mc <j1mc@users.noreply.github.com>
2611957 to
955aa3e
Compare
There was a problem hiding this comment.
Summary: This change imports the build recipe for S-Lang, a small programming library used by text-mode programs, copied unchanged from Fedora. I checked that the copied files match Fedora exactly, that the download is pinned by checksum, that the regex library it needs at runtime is available in the base repository, and that the project's own consistency checks pass. The only thing I'd add is a backup download address, since the project's own notes ask for one on every import.
style
-
low —
config/upstream-sources.json:5205-5210: the newslangentry has nofallback_urls.docs/skills/repeated-mistakes.md:558("Add the Fedora lookaside asfallback_urls, never asurl") anddocs/skills/factory-build-backlog.md:231-233ask for the lookaside on imports sotools/source_pipeline.pycan retry when jedsoft.org is down. The lookaside object for this SHA-512 exists today.{ "name": "slang", "version": "2.3.3", "url": "https://www.jedsoft.org/releases/slang/slang-2.3.3.tar.bz2", "filename": "slang-2.3.3.tar.bz2", "sha512": "f882f09e3fcd53427de0f233c9fc3ab15497f2323007be9a084696c8cf810ffe2726cd003149e757df26198b390b9f8c1ff411dc6473513457bd0f94722f8490", "fallback_urls": [ "https://src.fedoraproject.org/repo/pkgs/rpms/slang/slang-2.3.3.tar.bz2/sha512/f882f09e3fcd53427de0f233c9fc3ab15497f2323007be9a084696c8cf810ffe2726cd003149e757df26198b390b9f8c1ff411dc6473513457bd0f94722f8490/slang-2.3.3.tar.bz2" ] }
Verified at head 955aa3e: slang.spec, slang-sighuptest.patch, sources, gating.yaml, plans.fmf, ci.fmf are byte-identical to dist-git commit 354e992; config/buildroot-image pins fedora:44 so %{?fedora} is set and the Oniguruma branch (packages/slang/slang.spec:1-2,18) is taken — oniguruma/oniguruma-devel are present in current Hummingbird primary metadata, so the runtime libonig dependency resolves for the publish gate; tools/factory_build_backlog.py --check, tools/validate.py (584/580) and the packit/architecture renderers produce no drift.
No findings from: correctness, security, intent-alignment, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1
|
Adopted and merged via #719. |
Summary: This adds the build recipe for a library used by text-based programs. The project can now prepare that library for its operating system, but it still needs a hosted build and a working installation test before users can rely on it.
What I need from you: Review the change and run the hosted package build for this commit.
Changes
slangsource recipe at commit354e9920fa876d53ab95bf82747481306976bb51, preserve its source tree and test patch, lock the upstream 2.3.3 release, and register the recipe in Packit.slangentry stays in the long-tail area asalready_recipe; it is not a runtime or publication claim. Move its catalog record after the hosted build and publication are verified.slanglibrary andslang-slshinterpreter in the backlog skill.Refs #507 — partial source-family work only. The remaining outputs, publication and permitted-repository runtime checks stay open. Consumer tracking: projectbluefin/utah#263.
Evidence
f882f09e3fcd53427de0f233c9fc3ab15497f2323007be9a084696c8cf810ffe2726cd003149e757df26198b390b9f8c1ff411dc6473513457bd0f94722f8490matches the importedsourcesfile.ghcr.io/projectbluefin/utah-packages@sha256:710195827218db354cd1d0033d68db8b96efec97f1aaf3f45f8973479c6e7215, publishing run40481255792, revision142705c7428834e5bff92ffd7e917a7c8c461de5: noslangorslang-slshbinary. That snapshot includesrpcbind,simdutf,soundtouch,sso-mib-libs, andtslib; their publication does not prove installation or behavior. The other named outputs are not present in this snapshot. The independent reconciliation PR feat: mark the text-conversion and touchscreen libraries as published #709 covers catalog records forsimdutfandtslib.slang:repomd.xmlSHA-256f62ead89d03e5fea872b0a5ef00be106baf0f3dbba57fea3fda5ba210773f5d5; compressed primary SHA-256f89827b80ed34948489dfc235d5baa77a7d8de5d807cd8b96cdac12f1a37cd1e.make check; it builds the library and theslang-slshinterpreter separately. Its Oniguruma build option depends on the target's Fedora macro, so build-time and runtime dependencies must be confirmed from the actual hosted build.Validation
python3 tools/factory_build_backlog.py --check: passed.just check: passed (1396 passed, 2 skipped).just test: passed (1396 passed, 2 skipped).pre-commit run --all-files: unavailable;pre-commitis not installed.git diff --checkreports whitespace in the unchanged upstream recipe, patch and gating file; the repository's hooks intentionally exclude imported package files from whitespace rewriting.gh workflow run canary.yml -R j1mc/utah-packages --ref hive/507-long-tail-followup -f 'lane_packages=["slang"]' -f lane_backend=hermetic; the hive command allowlist refused workflow dispatch before a run was created. No build NEVRA, published digest for this change, dependency solver result or payload exercise is claimed. A reviewed-fork hosted run and installation against only Hummingbird plus the factory remain necessary before resolving the catalog record or claiming runtime parity.— hive: backend=pi model=openrouter/openai/gpt-6.1-terra