Repository navigation
feat: add five missing video codec libraries - #633
Conversation
Import SHA-512-locked upstream payloads with pinned Fedora, RPM Fusion and negativo17 recipes. Build x264 before FFmpeg and retain the VVC decoder test archive through the RPM Fusion source lookaside. Reconcile the recipe backlog without claiming runtime publication. Hive-Run: #476 Hive-Plan: codecs-media-source-imports Hive-Spec: issue-476#implementation-3 Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: arteeh <arteeh@users.noreply.github.com>
…codecs Reject provenance whose package field differs from its recipe directory so the master-branch remote guard cannot be satisfied by a mislabeled field. Record pr = 627 on the seven codec [resolved] backlog entries. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
🐝 Possible duplicateThis PR changes exactly the same files as #627, which was opened first:
Evidence — identical changed-file set (55 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
There was a problem hiding this comment.
HUMAN DECISION NEEDED — dispatch the seven-package Canary lane (hosted build proof) before merging; no CI run on this head has built any of the new codec recipes.
Summary: This change imports seven video/image codec recipes (x264, x265, vvdec, vvenc, svt-vp9, xavs2, libultrahdr) and tightens the rules that verify where recipes and test data come from. Two things need attention: the merge would automatically close the tracking issue even though that issue still has unfinished items and asks for build proof that does not exist yet, and none of the seven new recipes has actually been built by the hosted pipeline on this revision.
What I need from you: Change the PR body from "Closes #476" to "Refs #476", and run the codec Canary lane.
intent-alignment
- PR body says
Closes #476, but #476 names 12 outputs and states "this batch closes only when every named output is resolved or explicitly blocked by a linked decision";libxavsremains inconfig/factory-build-backlog.tomlareacodecs-media(stillpendinginreports/factory-build-backlog.json), and the issue's acceptance list (hosted run URLs, NEVRAs, Hummingbird+factory runtime proof) is unmet. The superseded #627 deliberately usedRefs #476for exactly this reason. Merging as-is auto-closes an open contract. Fix: replaceCloses #476withRefs #476(the[resolved]comment atconfig/factory-build-backlog.toml:474already says "publication and runtime proof remain separate").
correctness
- Both Canary runs on head
6e8b73f(40227663977, 40237340754) ran the default lane set only —libical,vulkan-headers,vulkan-loader,python-typing-inspection;LANE_PACKAGESwas empty in thechangesjob. None of the seven new specs has a hosted build.packages/x264/x264.specis the one most in need of it: it diverges from the RPM Fusion donor (Source0swapped to the VideoLAN commit archive atx264.spec:46,%setup -q -n %{name}-%{commit}at:103,%bcond bootstrap 1at:14flippinggpac/ffmpegoff and droppinglibavcodec-freeworld), so the donor's build history does not vouch for it.packages/vvdec/vvdec.spec:17also depends on the newrpmfusion-freelookaside path (tools/source_pipeline.py:115-118) for a 232 MBbitstreams.tar.xzthat%checkrequires — only unit-tested with a mocked fetch (tests/test_source_pipeline.py:450-472). Request: dispatch Canary withlane_packages='["libultrahdr","svt-vp9","x264","x265","vvdec","vvenc","xavs2"]'and record the run URL on #476.
No findings from: security, style, docs-currency.
Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
The Canary check on 82728d9 came from fork PR #627's run of the same commit, which cannot publish the canary image. A new commit on this in-repo branch gets its own Canary run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Summary: This change adds packaging recipes for seven video and image codec libraries (x264, x265, and friends) so the project can build them itself. The recipes and tooling look sound and all local checks pass, but the pull request is worded so that merging it would mark the whole tracking issue as finished, even though one library in that issue is still missing and none of the seven have been built yet. One small bookkeeping field also points at the older, abandoned copy of this pull request.
What I need from you: Change the closing keyword to a non-closing reference and point the backlog record at this PR.
intent-alignment
- (medium) PR body says
Fixes #476 (partial batch: libxavs still pending; hosted builds and runtime proof outstanding). Merging will auto-close #476, but #476's own boundary says "this batch closes only when every named output is resolved or explicitly blocked by a linked decision. Do not report blocked work as completed."libxavsis still pending inconfig/factory-build-backlog.toml:71, and the issue's acceptance list (hosted build run URLs, NEVRAs, runtime proof) is explicitly unmet per the PR body. Fix: replaceFixes #476withRefs #476/Part of #476so the issue stays open for the remaining work.
docs-currency
- (low)
config/factory-build-backlog.toml:475-481recordspr = 627on the seven new[resolved]entries. The section header (:472-473) says each entry names what closed the gap; #627 is the superseded original and will close unmerged, so the record will point at a PR that never landed. Fix:pr = 633.
correctness
- (info) No hosted build has exercised any of the seven new specs. The only Canary run on this branch (40237340754) is for commit
6e8b73f, not head6284327, and it built onlylibical,vulkan-headers,vulkan-loader. The two hive commits (82728d9,6284327) triggered no CI at all. Verified locally at head instead:python3 tools/validate.py→validated 559 source RPMs (5 master, 550 rawhide, 4 upstream);tools/factory_build_backlog.py --checkconsistent;pytest tests -q→ 1360 passed. Both new remote payloads resolve (pkgs.rpmfusion.org/.../vvdec/bitstreams.tar.xzHTTP 200, 232 MB; VideoLANx264-b35605ac….tar.bz2HTTP 200). Spec-level build proof remains outstanding as the PR body states.
No findings from: security, style.
Confidence: 3/5 (needs attention) — 1 medium finding; 2 perspectives requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Hive-Fix-Attempt: 2/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Needs a decision, not a merge: GitHub refused the merge: branch protection requires an approving review from someone with write access, and the Hive App cannot give it. A GitHub Approve review on this head (or an App bypass in the branch rules) lets the hive merge it; the hive retries once GitHub reports the PR unblocked, or within 30 minutes. Head: verdict approved @c4e45ea, 21/21 checks green, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
stage 080-awaiting-merge-admission → 070-fixing: conflicting |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> # Conflicts: # config/factory-build-backlog.toml # docs/architecture.md # reports/factory-build-backlog.json
|
Summary: This PR adds recipes for several missing video codec libraries (vvdec, vvenc, x264, x265, xavs2). It had fallen out of date with main, so I merged main in and fixed the shared registry files. Nothing about the packages themselves changed. Merged origin/main (a merge, not a rebase: the branch history already held several merge commits). Conflicts were in hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 |
|
Needs a decision, not a merge: GitHub refused the merge: branch protection requires an approving review from someone with write access, and the Hive App cannot give it. A GitHub Approve review on this head (or an App bypass in the branch rules) lets the hive merge it; the hive retries once GitHub reports the PR unblocked, or within 30 minutes. Head: verdict approved @596c310, 21/21 checks green, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
stage 080-awaiting-merge-admission → 070-fixing: conflicting |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: merged main into the branch to clear the merge conflict (generated counts and backlog report regenerated); CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 |
There was a problem hiding this comment.
Summary: This re-review covers only the latest change to the pull request that adds five video codec recipes: it merged the project's main branch into the branch. That merge itself is fine, but main has since moved again, so the automated checks on this pull request are red for reasons unrelated to the codec work. One more sync with main, plus regenerating two bookkeeping files, will make it green.
What I need from you: Merge main into the branch again and regenerate the recipe counts and backlog snapshot.
correctness
- (low, in-scope) CI red at merge ref is main drift, not this delta. Head
78d7475vs its merge-base44613caeis consistent: 682 package dirs, 682.packit.yaml:packages, 682config/upstream-sources.jsonentries (no duplicate names),docs/architecture.md:81,133,137-139,144,163say 682. But#823landed on main after this merge (imath, rygel → 684 recipes; backlog resolved 352/pending 154), sotests/test_architecture_counts.py:46,61,64,88,106fail with682 != 684andtools/factory_build_backlog.py --checkreportstotals drift: live {'backlog': 162, 'resolved': 352} vs snapshot {'backlog': 164, 'resolved': 350}(reports/factory-build-backlog.json:875-880). Fix: mergemainagain, runpython3 tools/factory_build_backlog.pyto regeneratereports/factory-build-backlog.json, and bump the counts indocs/architecture.mdto 684 /validated 684 source RPMs (5 master, 674 rawhide, 5 upstream).
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission → 070-fixing: required-check-failing:Unit tests |
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Main gained imath and rygel (#823), bringing the inventory to 684 packages. Regenerate docs/architecture.md counts via tools/render_architecture_counts.py --write and the backlog snapshot via tools/factory_build_backlog.py. Hive-Fix-Attempt: 5/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Needs a decision, not a merge: GitHub refused the merge: branch protection requires an approving review from someone with write access, and the Hive App cannot give it. A GitHub Approve review on this head (or an App bypass in the branch rules) lets the hive merge it; the hive retries once GitHub reports the PR unblocked, or within 30 minutes. Head: verdict approved @337fa03, 21/21 checks green, soak 0s of 30m0s. Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Refresh architecture and backlog state from the current inventory. Add one inventory regeneration command, repair invalid imported YAML whitespace, and preserve workflow output values with grouped redirection. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
Merge the verified factory validation baseline without flattening contributor history. Regenerate combined inventory, reject new direct test success fallbacks with the existing inherited-count ratchet, and propagate all built x265 TestBench failures. Remove the prohibited historical DELTA session artifact carrying committed conflict markers. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
stage 080-awaiting-merge-admission → 070-fixing: conflicting |
Merge current main (a590886) preserving all PR recipes and source locks, and regenerate combined inventory with just regenerate-inventory. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
Merged current |
8a98c78
|
Drop the style-only grouped GITHUB_OUTPUT edit carried in from the interim baseline branch; main intentionally kept the original workflow so recipe PRs do not touch pipeline paths. Assisted-by: GPT-6.1 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
|
Follow-up |
|
Depends on #821. That PR carries the RPM Fusion/negativo17 provenance policy, the
rpmfusion-freelookaside and the codec-tail import guidance, split out at maintainer request. This PR adds only five codec recipes: x264, x265, vvenc, vvdec and xavs2. libxavs is still pending. Validation (tools/validate.py) here stays red until #821 merges; it passes with #821 applied.Supersedes #627 (adopted after CI went red and the contributor was unavailable; original commits by @arteeh preserved).
Part of #476 (partial batch: libxavs still pending; hosted builds and runtime proof outstanding)
This branch is #627's head
6e8b73f85972as pushed by @arteeh (forkarteeh/utah-packages), unchanged. Last lane reason on the original:check-failure.Hive fix agent: rebase this branch on
main, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Refs #476 (closed by #746; this PR adds
docs/skills/multimedia-closure.md,packages/vvdec/.gitignore,packages/vvdec/.hummingbird-upstream.json,packages/vvdec/sources,packages/vvdec/vvdec-increase-test-timeout.patchand 31 more)