Repository navigation
Conversation
1a42a58 to
b1bc233
Compare
93ede55 to
9038d38
Compare
The factory builds 193 packages; a Utah image needs 345. The missing
152 are what a real dnf transaction against Hummingbird names, found by
composing the image and reading the resolver until it stopped
complaining: ffmpeg, bluez, SDL3, flatpak, appstream, gnome-keyring,
Xwayland and its five X11 helpers, hunspell and its dictionaries, gcr3,
openjph, setools, hidapi, desktop-file-utils, soxr, and the rest of the
runtime closure behind them.
Every recipe arrives in this repository's shape rather than dist-git's:
one spec, sources, changelog, patches, and the upstream provenance file.
The tmt plans, monitoring.toml, per-package .packit.yaml and .gitignore
that the scaffolding purge removed are stripped on the way in, so
nothing lands that the purge would only have to remove again.
Three recipes carried build-time defines in the old factory, which the
Packit inventory has no field for. They move into the spec, where they
work whichever builder runs:
mdadm ABRT off -- its only unresolved dependency was
libreport-filesystem, for a crash-reporter hook, in an
image that ships no crash reporter
v4l-utils Qt off -- qv4l2 and qvidcap need Qt6, and the build root
cannot resolve it while Hummingbird offers both libicu-77
and a qt6-qtbase that requires libicuuc.so.78
protobuf Java off -- the bindings need a JDK the build root does
not carry and nothing here consumes them
color-filesystem has no upstream archive at all: it creates four
directories and an rpm macro file, and dist-git records no sources for
it. Rather than invent a URL to satisfy the shape of a lock, an entry
may now declare `no_upstream_source`, which fetches and verifies
nothing. colord requires it, and colord is what gtk3 and the desktop
hang off.
webkit2gtk4.1 is deliberately absent. It is a second entry that builds
webkitgtk's recipe with a different define, and the inventory has no
alias field; webkitgtk itself is here.
Verified: `tools/validate.py` reports 345, the inventory reports every
recipe source-locked and Packit-configured, and all 42 tests pass. Not
verified: none of these has been built under Mock. The counts the
inventory tests assert are updated to match.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
PACKAGE_KEY did not accept "_", so a package whose name contains one parses as no package at all. package_names() drives both the rebuild matrix and the inventory's packit_configured check, which means such a package is silently never built and nothing reports it missing. No name in the current 193 has an underscore, so this has been latent. It surfaces the moment lm_sensors or volume_key is added. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9 Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
9038d38 to
3f579c1
Compare
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Approved by @castrojo for Hive auto-merge on green CI.
|
Hive auto-merge approval head changed since approval — re-queue required. |
GitHub caps a matrix at 256 jobs, and it does not fail when one would exceed that -- it expands to nothing. A stage holding more than 256 packages produces zero build jobs, silently, and every later stage then builds against an empty buildroot. This branch's cold stage 0 is 315 packages, so run 34171159421 spawned no rebuild0 jobs at all: 14 jobs at stage 1, 3 at stage 2, 1 each at 3 and 4, and none at 0. The stage-1 failures all read as missing dependencies -- vulkan-loader: No match for argument: vulkan-headers = 1.4.350.0 pipewire-libs-extra: No match for argument: pkgconfig(libfreeaptx) gdk-pixbuf2: glycin-2 found 2.1.0 but need >= 2.2.alpha.7 -- and all three name packages this factory builds at stage 0. They were not missing; they were never built. Hand each stage to build-stage.yml in chunks of 250 rather than in one piece, and fan the caller out over them. Stage 0 becomes two chunks (250 + 65); every other stage is unchanged at one. The flat stageN outputs stay, so the already-published skip logic and the empty-stage guards are untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
samba BuildRequires libtevent-devel >= 0.17.2 and python3-tevent >= 0.17.2. Fedora 44 ships 0.17.1, so those have to come from this factory's own libtevent 0.17.2 -- but libtevent sat at the same stage 1 as samba, and a stage cannot see its own output. samba failed with: No match for argument: libtevent-devel >= 0.17.2 Move samba to stage 2. libtalloc 2.5.0, its other version-floored dependency, is already at stage 0, so nothing else needs to move. The rest of that job's "missing dependency" errors were not ordering at all -- vulkan-headers, glycin, libfreeaptx and liblc3plus are all stage 0 packages that never built, because stage 0 exceeded GitHub's matrix cap and expanded to zero jobs. That is fixed separately. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Thirteen stage-0 jobs failed to resolve their buildroot, and none of them were
missing a package. Each hit the same shape: this factory rebuilds a library
with a new soname, Fedora's dependent still wants the old one, and the rebuilt
dependent -- which we also carry -- sits in the same stage, where a sibling job
cannot see it.
libheif 1.23.1 (so.2) vs Fedora glycin-loaders wanting libheif.so.1
-> pulseaudio, rest, sdl2-compat, tecla, wayland, wireplumber,
xdg-user-dirs-gtk (reached via graphviz -> gdk-pixbuf2 -> glycin)
abseil-cpp 20260526 vs Fedora webrtc-audio-processing wanting
libabsl_strings.so.2601
-> libepoxy, libglvnd, libayatana-ido, xdg-desktop-portal-gtk
pipewire 1.6.8 vs Fedora pipewire-jack-audio-connection-kit-devel
-> gstreamer1-plugins-good
Our glycin 2.2, webrtc-audio-processing 2.1 and pipewire 1.6.8 are all stage 0
and all build fine; they were simply invisible to their siblings. Move the
dependents to stage 1 so they see them.
nautilus-python goes to stage 2 rather than 1: it needs localsearch, which is
itself stage 1 -- Fedora's localsearch 3.11 wants libavformat.so.62, which our
ffmpeg 9.0.1 displaces.
Moving wayland to stage 1 is safe: the only versioned consumer is
wayland-protocols (>= 1.25.0), and Fedora 44 ships wayland-devel 1.25.0.
Also fix a lowercase month in dracut's changelog, which rpmbuild rejects
outright: "bad date in %changelog: Mon aug 10 2026". 10 Aug 2026 is a Monday,
so only the capitalisation was wrong.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Six stage-0 builds -- gcc, git, iputils, libvdpau, appstream and libtheora --
died with nothing useful in a tail:
Running transaction
Transaction failed: Rpm transaction failed.
dnf resolved the buildroot happily; rpm then refused to install it, and the
reason prints after the failure line rather than before it:
file /usr/bin/erb conflicts between attempted installs of
ruby4.0-default-gems-4.0.6-37.3.hum1 and ruby3.4-default-gems-3.4.10-31.7.hum1
Both sides are .hum1. The existing exclusions are per-repo -- fedora.excludepkgs
and updates.excludepkgs -- so they can express "prefer Hummingbird's copy over
Fedora's" but not "prefer one Hummingbird package over another". Hummingbird now
carries ruby3.4-default-gems and ruby4.0-default-gems, whose file lists collide.
Exclude the superseded ruby globally with --exclude, leaving 4.0 as the only
candidate in any repo. The per-repo lists are left alone: they still do the job
they were written for.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Both failed with a file that is sitting in the recipe directory:
error: Bad file: /work/staged/mdadm/9CE05640D703A136.asc: No such file
.gitignore carries `packages/*/*.asc`, meant for downloaded signatures. A
keyring a spec names as a SourceN is not a downloaded artefact -- it is part
of the recipe, read straight out of _sourcedir:
%gpgverify --keyring='%{SOURCE11}' --signature='%{SOURCE10}' --data=-
So the file existed locally, was never committed, and CI checked out without
it. git, wayland and zsh already carry theirs because someone force-added them
one at a time; mdadm and setxkbmap were simply missed, and nothing reported it.
Commit the three missing keyrings and narrow the ignore so the next one is not
lost the same way: keep ignoring downloaded .asc signatures, but never a file
named as a key ID or carrying "key"/"keyring" in its name.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Xwayland's meson.build asks for wayland-client >= 1.26; Fedora 44 ships 1.25.0, so only this factory's wayland 1.26.0 satisfies it: meson.build:189:4: ERROR: Dependency lookup for wayland-client with method 'pkg-config' failed: Invalid version, need 'wayland-client' ['>= 1.26...'] Both sat at stage 0, where a job cannot see its sibling's output, so Xwayland could never have found it. wayland has since moved to stage 1, so Xwayland goes to stage 2. The floor is declared in upstream's meson.build rather than the spec, which is why scanning BuildRequires does not find it -- the spec's wayland-devel carries no version at all. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
The openssh regress suite failed every parallel test job: Privilege separation user sshd does not exist FATAL: sshd_proxy broken make: *** [parallel_test.Makefile:3: t-exec-03] Error 2 The recipe carries openssh-server-systemd-sysusers.conf and creates the user from %pre at install time. A buildroot never installs the package it is building, so the user is absent exactly where the test suite expects it. Apply any sysusers config the recipe stages, before rpmbuild runs. This is generic -- any package shipping one gets the users it declares -- and it supplies what a real build root has rather than disabling the test that noticed the gap. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
%prep died with all three hunks rejected: 3 out of 3 hunks FAILED -- saving rejects to file src/nasm.inc.rej error: Bad exit status from /var/tmp/rpm-tmp.bC0pTE (%prep) The patch was not stale. xvidcore ships src/nasm.inc with CRLF line endings -- all 213 lines of it -- while the patch carried LF-only context, so no context line ever matched. Nothing about the change itself was wrong. Regenerated against the pristine 1.3.7 tarball, with CRLF preserved on both sides of the diff. Same three hunks, same 23 inserted lines, same GNUHEADER macro and the two call sites. Verified by applying it to an untouched src/nasm.inc and comparing the result against the intended file byte for byte. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Git normalised the CRLF context out of the regenerated xvidcore patch the moment it was committed -- the blob went in with zero carriage returns, so the fix would have failed in CI exactly as before, and the working tree would still have looked correct. Mark patches, diffs, keys and signatures as -text so git leaves them alone. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
flac failed %check with the suite naming the cause itself:
ERROR: iterator claims file is writable when tester thinks it should not
be; are you running as root?
80% tests passed, 2 tests failed out of 10
The test is right. It chmods a file read-only and asserts the write fails,
and root writes it regardless of the mode bits. tools/build-rpm.sh already
fixed this for a local build, in as many words:
# Match mock's build user. FLAC's read-only-file tests correctly fail when
# rpmbuild runs as root, which can write files regardless of their mode bits.
useradd --create-home --home-dir /builddir mockbuild
build_rpm() { runuser -u mockbuild -- rpmbuild "$@"; }
The CI lane never got the same treatment and kept building as root out of
/root/rpmbuild. So the two lanes disagreed about who runs the build, and a
package could pass locally and fail here for a reason belonging to neither
the recipe nor the code.
Create the same mockbuild user, move _topdir to /builddir/rpmbuild, and run
both rpmbuild invocations through runuser. Fedora builds this way; so should
both of ours.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
evolution-ews sat at stage 0 while evolution-data-server, which supplies every
pkgconfig module it asks for, is at stage 1:
No match for argument: pkgconfig(camel-1.2) >= 3.61.3
No match for argument: pkgconfig(evolution-data-server-1.2) >= 3.61.3
No match for argument: pkgconfig(evolution-mail-3.0) >= 3.61.3
Move it to stage 2. evolution-data-server itself builds fine.
tailscale vendors go-json-experiment/json, whose alias.go forwards to the
standard library encoding/json/v2 when the jsonv2 experiment is on. Hummingbird
ships Go 1.27, whose v2 API has moved past that vendored shim:
vendor/github.com/go-json-experiment/json/alias.go:618:21:
undefined: json.SkipFunc
vendor/github.com/go-json-experiment/json/alias.go:957:14:
undefined: json.DiscardUnknownMembers
GOEXPERIMENT=nojsonv2 takes the build tag out, so the module uses the
implementation tailscale ships and tests against.
libnice lost one test of forty-two, on the clock rather than on a failure:
42/42 libnice:test-new-trickle TIMEOUT 30.03s killed by signal 15 SIGTERM
Fail: 0 Timeout: 1
test-new-trickle negotiates ICE candidates against timers and wants more than
the 30s meson allows by default on a loaded builder. Raise the multiplier
rather than drop the test that ran out of time.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
The Packit SRPM pilot has failed on every run since the monorepo passed 256 packages, and it failed invisibly: discover goes green, reports "discovered 345 packages", and the srpm matrix beneath it produces no jobs at all. GitHub caps a matrix at 256 and expands a larger one to nothing rather than rejecting it. The discover step already guards against a matrix that runs nothing -- it asserts the list is non-empty -- but a non-empty list of 345 is exactly the case that guard cannot see. Split the per-package steps into a reusable packit-srpm-chunk.yml and fan the pilot out over chunks of 250, the same shape rebuild-rpms.yml uses. Per-package parallelism is unchanged; only the number of matrices grows. Chunking lives in packit_workflow.py rather than inline in YAML so it can be tested, and a test now asserts every chunk fits under the cap and that chunking loses no package. This is what the pilot was built to answer and has never reached: whether packit srpm works against these recipes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Packit stays, scoped to what it does well: turning a recipe into an SRPM and proving the spec is well formed, in three or four seconds a package. That is a cheap gate -- dracut sat behind a lowercase month in a %changelog date, which an SRPM step catches at once instead of after a build root has been installed and the package compiled. Packit is not replacing the binary lane, and the disttags say why. packit srpm yields flac-1.5.0-9.fc43; this factory ships gnome-shell-extension-gsconnect-72-3.hum1.bfin. Rebuilding against Hummingbird so sonames match the image is the entire reason the factory exists, and a Fedora-chroot SRPM does not answer it. Copr is the shape in which Packit could take the binary lane, and we are not pursuing it now: it would need a custom chroot carrying the Hummingbird repository plus the exclusion rules the lane already encodes. That is a migration of the build root, not a change of build driver. Written down so the option is not rediscovered from scratch. Also records two things that were true but undocumented -- Packit does no source acquisition here either, and .packit.yaml carries no jobs section, so the service does no work on a pull request -- notes the matrix cap that kept the pilot from ever running, and refreshes the counts from 193 to 345. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Both were solved on fix/repeatable-local-builds (#45) and lost in the port to the Packit shape. Bringing the recipes across rather than rediscovering them. libheif is the one blocking ten packages in the current run. Its ffmpegdec plugin links Fedora libav, and the moment the factory promises its own ffmpeg 9.x the Fedora copy is excluded by name -- so the accumulator libheif becomes uninstallable and takes every buildroot that reaches gdk-pixbuf2, glycin, graphviz or doxygen with it. That is exactly what opus, libthai, libvpx, mpg123, openjpeg, spandsp, libnice, libnma and libtalloc are failing on: package graphviz requires libgdk_pixbuf-2.0.so.0, but none of the providers can be installed ... glycin-loaders requires libheif.so.1 ... The draft answers it with a narrow %bcond ffmpeg 0: the aom and dav1d decoder plugins stay, which is what actually decodes AVIF and HEIC here, and only the ffmpeg HEVC path goes. Narrower than %bcond bootstrap, which would also drop rav1e, SvtEnc and sdl2. tailscale builds from the official static release payload rather than a vendored Go tree, so it no longer depends on the Hummingbird Go version merely to reproduce an upstream artifact. This supersedes the GOEXPERIMENT=nojsonv2 workaround added earlier today, which was treating a symptom: Go 1.27 has moved past the vendored go-json-experiment shim. The spec goes from 1192 lines to 71, the vendor tarball script and the 1.92.5 systray patch go with it, and the source lock points at tailscale_1.98.8_amd64.tgz. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Seven of the eight stage 0 failures were not package failures at all: Failed to FinalizeArtifact: Received non-retryable error: (403) Forbidden grub2, gtk2, iio-sensor-proxy, liblc3, xkbcomp, xmodmap and xrdb each built their RPMs and then lost them on upload. Every job uploads its debuginfo and debugsource alongside the RPMs, which no BuildRequires ever names and which are more than half the bytes -- #45 already skips them when seeding a local prior for exactly that reason. Exclude them from the artifact so the run stops spending its budget on payload nothing downstream reads. python-evdev is the one real failure. Its %generate_buildrequires runs %pyproject_buildrequires, and that macro has to execute before the dependencies it generates can be resolved -- so with nothing named statically the first pass has nothing to run it with: pyproject-rpm-macros is needed by python-evdev python3-devel is needed by python-evdev python3dist(packaging) is needed by python-evdev and the retry loop then reinstalls what is already installed, three times, and gives up. Name them, the same way python-typing-inspection asks for python3-packaging. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Sixteen of twenty-three stage 1 packages failed on one knot, and openjph tied it. This PR added openjph; libheif is the only recipe in the factory that build-requires it, and Hummingbird ships no libopenjph at all -- only Fedora does, at 0.25. Carrying openjph 0.31 therefore excluded Fedora libopenjph by name, which made Fedora libheif uninstallable, which made this factory own glycin-loaders uninstallable, which took gdk-pixbuf2 and everything behind it down: glycin-libs-2.2~beta from stages requires glycin-loaders = 2.2~beta glycin-loaders-2.2~beta from stages requires libheif.so.1 libheif-1.21.2-1.fc44 from fedora requires libopenjph.so.0.25 libopenjph-0.25.3-3.fc44 from fedora is filtered out by exclude filtering -- evolution-data-server, ffmpeg, flatpak, gdk-pixbuf2, gstreamer1-plugins-bad-free, gstreamer1-plugins-good, libtevent, localsearch, pulseaudio, rest, sdl2-compat, tecla, wayland, webkitgtk, wireplumber and xdg-user-dirs-gtk. Ordering cannot untie it within five stages. openjph, libheif, glycin, gdk-pixbuf2, then everything that reaches gdk-pixbuf2, is five waves before webkitgtk, gjs and gnome-shell have anywhere left to go. Declining the encoder removes the dependency instead: libheif no longer needs openjph at build or at run time, Fedora libopenjph is never excluded, Fedora libheif stays installable for glycin to link, and nothing has to move. libheif returns to stage 0. The cost is HTJ2K encoding. AVIF and HEIC decode through aom and dav1d, which is what this image actually shows, and JPEG 2000 keeps working through OpenJPEG -- a different library, still enabled. Counts drop to 344. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
…ed out Sixteen stage 1 packages failed on the openjph knot, and the reason ordering could not untie it was that five waves is not enough to express this dependency graph. openjph, libheif, glycin, gdk-pixbuf2 and then everything reaching gdk-pixbuf2 is already five, before webkitgtk, gjs, evolution-data-server, flatpak or gnome-shell have anywhere to go. fix/repeatable-local-builds solved that with sub-lanes -- stage0_late, stage0_late_b, stage0_late_c, stage1_heavy, stage2_late, stage3_late -- each its own wave with its own boundary. Rather than invent a second answer, take that lane order and flatten it into consecutive numbers here: 1 libheif (stage0_late) 2 webrtc-audio-processing (stage0_late_b) 3 ffmpeg, gstreamer1-plugins-good, xorg-x11-server-Xwayland (stage0_late_c) 5 webkitgtk (stage1_heavy) 7 gjs (stage2_late) 9 evolution-data-server, flatpak, gnome-shell (stage3_late) with the old numeric waves shifted into 4, 6, 8 and 10 around them. The reasoning behind each boundary is recorded in that file and holds unchanged: WebRTC before any consumer whose buildroot resolves PipeWire; libheif before its late consumers; Flatpak after the malcontent-bootstrap provider it needs and before the full malcontent build that needs Flatpak. rebuild-rpms.yml grows rebuild5 through rebuild10 on the same chunked reusable-workflow pattern, and KNOWN_STAGES widens to match so the inventory still refuses a stage no job can resolve. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
…accept
343 of 344 srpm jobs now pass. The one failure is color-filesystem, on
File "/repo/tools/packit_source0.py", line 42, in verified_source0
archive = candidates[0].parent / matches[0]["filename"]
KeyError: 'filename'
Its lock declares `no_upstream_source` -- the recipe is four directories and
an rpm macro file, with no Source line and no dist-git sources, so #51 gave
the inventory that field rather than inventing a URL. source_pipeline.py
already honours it ("result": "accepted" in the same log); packit_source0.py
had never been taught it. The pilot could not have caught this earlier: the
dead image pin was failing every srpm job before any of them reached a spec.
Packit offers no way to opt out. Reading its upstream: `prepare()` calls
create_archive unconditionally, and the action must print the path of a file
that exists or Packit raises "No output from create-archive action." So the
script synthesizes an empty archive for this case -- written into the spec
directory so Packit has nothing outside it to symlink, and emitted with a
zeroed gzip header so two runs produce identical bytes.
Nothing consumes those bytes: the workflow passes --preserve-spec, so Packit
never rewrites Source0 to point at it, and a spec with no Source line puts
nothing but itself in the SRPM.
Also closes a trigger gap of the same family as the FACTORY_REPO one.
tools/generated_sources.py generates the Source0 payload for gcc,
intel-media-driver-free and tailscale, yet neither the rebuild nor the pilot
listed it in `paths`, so a change to what gets built could land on main
without building it -- while tools/source_pipeline.py beside it did trigger
both. It now sits next to it in all four lists.
74 tests pass, the new one covering both the placeholder's emptiness and its
byte-reproducibility.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
[scanner] CI root cause for the red srpm jobs: pinned packit image digest was pruned from quay (exit 125, manifest unknown). One-line fix at .github/workflows/packit-srpm-pilot.yml:90 — details and verified replacement digest: #74. Agent cannot push workflow-file changes (App lacks workflows permission).🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 |
[scanner] CI red is systemic, two clusters: (1) all
|
|
[scanner] rebuild failures include the systemic ruby default-gems conflict (blocked on #83) plus package-specific gaps. Recommend: land #83 first, rebase, then triage the remaining per-package failures from a clean run. scanner agent (ACMM L5 — hold-gated mode)🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78 |
hanthor
left a comment
There was a problem hiding this comment.
Superseded by #70, and I think it should be closed in its favour rather than merged alongside.
#70 is not a descendant of this branch, despite its body saying it "Merges #51":
$ git merge-base --is-ancestor pr/51 pr/70
NO
$ git diff pr/51...pr/70 --stat | tail -1
119 files changed, 1582 insertions(+), 17982 deletions(-)
It is a parallel branch that reproduces this PR's contract and then removes ~18k lines from it — chiefly the firefox recipe (69 files deleted) and its source lock, plus the tmt/monitoring residue. So the two are alternatives, not a stack.
Both merge cleanly into main and both pass every gate, so this is a choice about content, not mechanics:
PR#51 fc=0 val=0 pytest=0 | validated 344 source RPMs | 73 passed in 0.66s
PR#70 fc=0 val=0 pytest=0 | validated 341 source RPMs | 98 passed in 0.76s
(baseline on unmodified main: 193 SRPMs, 72 passed.) Both also pass check_workflow_quoting, runtime_contract and unittest discover. They do not conflict with each other either.
Why #70 looks like the one to keep:
-
This PR's stated blocker is unresolved. The body says "Depends on #52 (shard rebuild stages past the 256-job matrix cap). Without it this PR's cold stage 0 — 266 packages — produces zero build jobs and every later stage builds against an empty buildroot." #52 was closed unmerged.
mainstill caps at five stages. #70's body says it carries #52's matrix-cap sharding and eleven stages inline, which removes that dependency. -
#70 has been through a real matrix run and this has not. #70's run 34528080916 produced 285 build jobs, 279 successes, and named the five failures precisely. Its current run (34658833276, in progress as I write) has rebuild0 fully green. This PR's body is candid that "none of these has been built under Mock", and its own run (34548412503) failed
firefox,gjs,gstreamer1-plugins-bad-free,samba,mozjs140,webkitgtk,pipewire-libs-extra,evolution-data-server,git,dracut,evolution-ews— the failures #70 was opened to fix. -
firefoxis the clearest single difference. It is a confirmed failure on every run I looked at, including unmodifiedmain(run 34571911239, job 103188402900), and #70 removes the recipe outright on the grounds that Utah shipsorg.mozilla.firefoxas a Flatpak andprojectbluefin/utahalready listsfirefoxas unavailable. I verified #70 does both halves — 69 files deleted,firefoxadded to[unavailable]inconfig/runtime-contract.toml, and the 12G swap step that existed only for it removed from the workflow. That drops a 2.5-hour PGO/LTO job that fails anyway. -
The
FACTORY_REPOfix. #70 defaults it to the Pages URL at both call sites (${{ vars.FACTORY_REPO || 'https://projectbluefin.github.io/utah-packages/' }}); onmainand on this branch it is${{ vars.FACTORY_REPO }}, unset onpull_request, soprepareskips packages as "already published" that the buildroot then cannot see. That is a correctness bug affecting 59 recipes in this contract and it is fixed only in #70.
Credit where due: the derivation method here is the most convincing thing in the queue — reading nothing provides ... needed by ... until the transaction resolves, rather than curating a list, is the right way to produce a contract, and #70 inherits it wholesale. The PACKAGE_KEY underscore bug (lm_sensors, volume_key parsing as no package at all and silently never building) is a genuinely good catch. The no_upstream_source field for color-filesystem is a clean solution to a real gap.
One thing to check before closing: this PR reports 345 in its body while validate.py reports 344 on the merged tree, and #70 reports 343 while measuring 341. Minor, but if the counts matter to anyone downstream they should be reconciled in whichever PR survives.
A coordination note for whoever picks this up: #81 ("close Bluefin multimedia override closure") overlaps heavily with both. Of its 47 package directories, 41 are also touched by #70 and 40 by #51 — ffmpeg, lame, fdk-aac-free, flac, libheif, jpegxl, libvorbis, gstreamer1-plugins-bad-free and the rest of the codec closure. Three large PRs re-adding substantially the same recipe set is worth resolving before any of them merges.
Generated by Claude Code
hanthor's review found 41 of this PR's 47 new package directories also appear in projectbluefin#70 and projectbluefin#51 (both further along). Rebase down to the 6 packages unique to this PR (PackageKit, alsa-utils, ffmpegthumbnailer, gstreamer1-plugin-libav, gstreamer1-plugins-ugly-free, rust-gst-plugin-dav1d), and: - Revert the gstreamer1-plugins-bad-free and libheif spec edits, since projectbluefin#70 addresses the same gstreamer1-plugins-bad-free build failure with a different fix (a chromaprint bcond). - Defer the [bluefin].sections multimedia_overrides contract-enforcement change in config/runtime-contract.toml, restoring the original comment explaining why — the 39 dropped recipes are unproven here. - Trim config/bluefin-packages.toml's [multimedia_overrides] list, .packit.yaml, and config/upstream-sources.json to only the 6 kept packages (plus the pre-existing Mesa/Intel/VA-API overrides). - Trim reports/bluefin-multimedia-closure.json to the 19 requirements this PR actually builds, and reframe docs/skills/multimedia-closure.md and docs/targeting-hummingbird.md as documenting the target 45-binary closure, with the remainder expected via projectbluefin#70. tools/validate_multimedia_closure.py, tools/import_bluefin_rawhide.py, and their tests are kept as-is — generic infrastructure, not tied to package count. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LNgJ8VMdoqzGequbxsP2Kc
|
[scanner] CI root cause: both failure classes here are systemic, not from this PR.
Once #83 and #87 merge and this branch is rebased, CI should validate this PRs actual changes. Note: the hive App token currently lacks the scanner agent (ACMM L5 — hold-gated mode)🐝 Hive Agent: — hive: agent=scanner backend=copilot model=kimi-k3 copilot=1.0.78 |
[scanner] The mass red here is environmental, not this PR: (1) every
|
|
Closing: superseded by #70, which merged as Generated by Claude Code |
…ures Merges the 151-recipe contract from projectbluefin#51 (which carries projectbluefin#52's matrix-cap sharding and eleven stages) and fixes every non-Firefox failure from run 34415980185. **The build root could not see the published repository.** `prepare` skips any package already published at the same version, but the [factory] repo block is guarded by `vars.FACTORY_REPO`, which is unset on pull_request runs -- so it never ran, and a skipped package was simply absent. That is why pipewire-libs-extra died on No match for argument: pkgconfig(libfreeaptx) while libfreeaptx-devel sat published and skipped. FACTORY_REPO now defaults to the same GitHub Pages URL `prepare` reads to decide what to skip, so the two halves of that decision cannot disagree. **Two recipes were staged before what they need.** - xorg-x11-server-Xwayland 3 -> 5. It needs wayland-client >= 1.26.0 and the buildroot had Fedora's 1.25.0; this factory builds wayland at 4. Its three stage-0 build consumers resolve Xwayland from Fedora, so moving it later changes nothing for them. - evolution-ews 6 -> 10. It needs libebook/libecal/libedata-* >= 3.61.3, and evolution-data-server builds at 9. **gstreamer1-plugins-bad-free declines chromaprint**, on exactly the reasoning ffmpeg.spec already records: Fedora's libchromaprint links libavutil.so.60, this factory's ffmpeg 9.0.1 provides so.61, and the factory excludes the Fedora libav by name, so libchromaprint-devel is uninstallable here. The spec disabled chromaprint only under `%if %{without extras}`; it is now its own bcond, off, with the BuildRequires and the plugin in %files following it. gcc was cancelled with the run, not failed, and needs only a re-run. Inventory 344 -> 343 with Firefox dropped; validate, the runtime contract, the quoting check and all 73 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
The factory builds 193 packages. A Utah image needs 345. This adds the missing
152, in this repository's inventory shape, on top of the Packit migration.
Where the list comes from
Not from a wishlist — from the resolver. Composing a Utah image against the
published repository and reading
nothing provides ... needed by ...until itstopped complaining, about a dozen rounds, each one revealing the next layer:
ffmpeg,bluez,SDL3,flatpak,appstream,gnome-keyring, Xwaylandand its five X11 helpers,
hunspelland its dictionaries,gcr3,openjph,setools,hidapi,desktop-file-utils,soxr, and the runtime closurebehind them. With these, the transaction resolves with 0 dependency
problems; without them it does not resolve at all.
Shape
Each recipe lands as one spec,
sources,changelog, patches and.hummingbird-upstream.json. The tmt plans,monitoring.toml, per-package.packit.yamland.gitignorethat5ca6634purged are stripped on the wayin, so nothing arrives that the purge would only have to remove again.
.packit.yamlis regenerated withtools/render_packit_config.py --write.Three recipes carried
rpm_definesin the old factory, which the inventoryhas no field for. Those move into the spec, where they hold whichever builder
runs —
mdadmwithout the ABRT hook (its only unresolved dependency waslibreport-filesystem, for a crash reporter this image does not ship),v4l-utilswithout the Qt viewers (Hummingbird offers bothlibicu-77and aqt6-qtbaseneedinglibicuuc.so.78, so Qt6 cannot resolve), andprotobufwithout Java.
color-filesystemhas no upstream archive at all — fourmkdirs and an rpmmacro file, with no
Sourceline and no dist-git sources. An entry may nowdeclare
no_upstream_sourcerather than inventing a URL to satisfy the shapeof a lock.
colordrequires it, and gtk3 hangs offcolord.webkit2gtk4.1is deliberately absent: it buildswebkitgtk's recipe under adifferent define and the inventory has no alias field.
webkitgtkitself ishere.
A latent bug this surfaced
PACKAGE_KEYintools/packit_workflow.pydid not accept_, so a packagewhose name contains one parses as no package at all — silently never built,
with nothing reporting it missing. No name in the current 193 has an
underscore;
lm_sensorsandvolume_keydo. Fixed in its own commit.Verification
tools/validate.pyreports 345, the inventory reports every recipesource-locked and Packit-configured, and all 42 tests pass. The counts those
tests assert are updated.
Not verified: none of these has been built under Mock. They were built and
installed under the previous podman-based factory, which is how the list was
derived and how the image was proven to resolve; Packit/Mock builds are what
this PR needs from CI. Expect some to need work.
Companion: projectbluefin/utah#41. Supersedes the portable half of the draft
in #45.
🤖 Generated with Claude Code
https://claude.ai/code/session_015VF8ttMH6WGQHeQ9hdMSY9
Depends on #52 (shard rebuild stages past the 256-job matrix cap). Without
it this PR's cold stage 0 — 266 packages — produces zero build jobs and every
later stage builds against an empty buildroot. Rebased onto #52; merge that
first. With it, the run spawns all 266 stage-0 jobs as expected.