Repository navigation
ci(validate): give check_workflow_quoting and runtime_contract a PR-wide trigger - #282
Conversation
…ide trigger Part B of projectbluefin#126. The factory gate catalog is now owned by the Justfile (Part A, projectbluefin#196), but two gates -- tools/check_workflow_quoting.py and tools/runtime_contract.py --check -- still ran only inside rebuild-rpms.yml's prepare job, which is filtered by paths: and skips 8 of the repository's 10 workflows. A pull request that only touched one of those 8 workflows ran the shell-quoting linter zero times. validate.yml has no paths: filter, so it already runs on every pull request. Add workflow-quoting and runtime-contract as jobs there, alongside the existing factory-contract and validate jobs. Nothing existing is removed or changed; this is additive coverage only. Both commands already pass on main, and tests/test_gate_catalog.py accepts the change as-is since both gates are already in the recognised gate set from rebuild-rpms.yml. Also updates docs/architecture.md's gate table to list validate.yml as an enforcement point for both gates. Not addressed here: the prepare job's own paths: filter is left as is, since rebuild-rpms.yml still needs to gate builds on config/ and packages/ changes specifically; only its blind spot for the other 8 workflows is closed here. Hive-Run: projectbluefin#126 Hive-Plan: Part B -- validate.yml PR-wide trigger for orphaned gates Hive-Spec: architecture-finding#126-part-b Signed-off-by: buggtb <tom@spicule.co.uk>
castrojo
left a comment
There was a problem hiding this comment.
Reviewed at ae57df4. The two new validate.yml jobs run exactly the Justfile recipes (workflow-quoting: python3 tools/check_workflow_quoting.py; runtime-contract: tools/runtime_contract.py config/bluefin-packages.toml config/runtime-contract.toml --check), use the same pinned checkout SHA and runs-on as the sibling jobs, need no third-party deps (both tools import stdlib only), and inherit the workflow's contents: read. validate.yml has no paths: filter, so this closes the blind spot for PRs touching the 8 workflows rebuild-rpms.yml's prepare job skips. docs/architecture.md gate table updated to match. Verified locally: check_workflow_quoting ('checked 15 workflows'), runtime_contract --check (78 packages), tests/test_gate_catalog.py 4 passed; on CI run 36272782559 both new jobs pass. The only red check is Canary (run 36272782908): the fork guard ('a fork pull request cannot publish the canary image; a maintainer must push this branch to the repository'), because the PR touches .github/workflows/. Landing needs a maintainer with workflow-scope push to carry this branch into the repository so Canary runs non-fork.
|
Merge record (approval only, not merged): R2, independent approver castrojo (no castrojo commits on this branch). Blocked on the Canary fork guard; needs a maintainer with workflow scope to carry the branch (castrojo's token lacks workflow scope). |
projectbluefin#278) Utah's image build against d5455dc1 (utah projectbluefin#282) found two runtime gaps: - libcupsfilters links libpdfio.so.1 and nothing in the factory or Hummingbird provides it. Import Fedora Rawhide pdfio 1.6.5; Source0 is the upstream GitHub release (michaelrsweet/pdfio), whose bytes match the SHA-512 in the imported sources file, the lookaside a fallback, and the detached .sig comes from the lookaside and is checked by the spec's gpgverify. No stage: waves are solved from BuildRequires, which put it before libcupsfilters. Only libcupsfilters needs it: its devel Requires pkgconfig(pdfio); libppd and cups-filters reach pdfio only through it. - libgphoto2-2.5.33-4 still required liblockdev.so.1. projectbluefin#269 dropped lockdev at the same Release, the run that would have built it was cancelled, and the first state label then recorded the new recipe as published. Release 5 so it rebuilds. Recipe count 399 -> 400 in tests and docs. Claude-Session: https://claude.ai/code/session_01QMTLsnqW2jtz5QsNC3W3qv Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Part B of #126 (Part A — Justfile as single owner of the gate catalog — already merged as #196).
tools/check_workflow_quoting.pyandtools/runtime_contract.py --checkran only insiderebuild-rpms.yml'spreparejob, which is filtered bypaths:and skips 8 of the repository's 10 workflows. A pull request touching only one of those 8 workflows ran the shell-quoting linter zero times.Change
validate.ymlhas nopaths:filter, so it already runs on every pull request. This addsworkflow-quotingandruntime-contractas jobs there, alongside the existingfactory-contractandvalidatejobs. Nothing existing is removed or changed — additive coverage only.Both commands already pass on
main:checked 15 workflows: no build script contains a quote that would close itvalidated runtime contract: 78 packages against quay.io/hummingbird-community/bootc-os:latest@sha256:c5539f9…tests/test_gate_catalog.py(added by #196) accepts this as-is: both gates are already in the recognised gate set fromrebuild-rpms.yml, and running them from a second workflow only adds to the set of workflows mapped to the same gate identity. Full suite passes: 654 passed, 2241 subtests passed.Also updates
docs/architecture.md's gate table to listvalidate.ymlas an additional enforcement point for both gates.Not addressed here
The
preparejob's ownpaths:filter is left as-is —rebuild-rpms.ymlstill needs to gate builds onconfig/andpackages/changes specifically; only its blind spot for the other 8 workflows is closed here.Closes #126.
— hive: backend=pi model=pi-claude-code-provider/sonnet
🐝 Hive Agent:
contributor| SHA:ae57df4