Repository navigation
Add cups-browsed and cups-filters for printing parity (issue #144) - #181
Closed
kylerankin wants to merge 1 commit into
Closed
kylerankin wants to merge 1 commit into
kylerankin wants to merge 1 commit into
Conversation
…luefin#144) Issue projectbluefin#144 reports printing parity is missing cups-filters and cups-browsed, neither of which any repository carries. Import them from Fedora Rawhide dist-git along with the split-out libcupsfilters and libppd source packages they BuildRequire (pkgconfig(libcupsfilters), pkgconfig(libppd)); that split landed in cups-filters 2.x, so the consumers cannot build without them. libcupsfilters and libppd are staged in stage 0 so they publish before the stage-1 consumers that need them. Each recipe carries its upstream source, patches, README, and SHA-512 lock. Co-authored-by: Hive <hive@anthropic.com> — hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
castrojo
reviewed
Sep 19, 2026
castrojo
left a comment
Contributor
There was a problem hiding this comment.
Substantive review:
- Recipe & Packaging: Adds cups-browsed (2.1.1), cups-filters (2.0.1), and their split-out build dependencies libcupsfilters (2.2.1) and libppd (2.1.1) from Fedora Rawhide dist-git with SHA-512 locks.
- Staging & Invariants: All 4 packages placed appropriately across stages; recipe set agreement verified (344 recipes).
- Validation: Factory contract, validate.py, and unittest suite pass without errors.
- Outstanding: CI checks are currently in progress; awaiting CI completion and independent peer review (+2).
Member
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144.
Issue #144 reports printing parity is missing
cups-filtersandcups-browsed,neither of which any repository carries. This imports both from Fedora Rawhide
dist-git along with the split-out
libcupsfiltersandlibppdsource packagesthey
BuildRequire(pkgconfig(libcupsfilters),pkgconfig(libppd)); thatsplit landed in cups-filters 2.x, so the consumers cannot build without them.
libcupsfiltersandlibppdare staged in stage 0 so they publish before thestage-1 consumers that need them.
.packit.yamlregenerated bytools/render_packit_config.py; test countsbumped to the new inventory.
Verified locally:
python3 tools/validate.py(344 RPMs),python3 tools/factory_contract.py, and theunittestinventory/render suite.— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K