Repository navigation
fix(renovate): require human review for github-actions updates - #161
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
The github-actions packageRule granted automerge + platformAutomerge to digest, patch and minor updates. Every workflow in this factory runs actions with contents: write, packages: write and id-token: write, so a bumped action ref executes with the tokens that sign and publish our RPMs as soon as it lands, with no maintainer having read it. The build-root-image rule earns its automerge: a rotted digest fails every job in the run before a line of script executes, and the replacement is whatever the pinned tag already resolves to, so waiting for review costs more than it protects. An action pin has neither property -- a moved ref does not fail the run, it runs something else. Pin the stance to false explicitly rather than relying on the top-level default, so a config:recommended bump cannot re-enable it without a diff in this file, and gate both properties in tests/test_renovate_coverage.py. Assisted-by: Claude Opus 5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "scanner" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
|
Deferred to the shared CI incident, not repaired here.
This PR changes Tracked as one repository incident in #153. Deferring this PR until that incident closes or
|
castrojo
left a comment
There was a problem hiding this comment.
Substantive review:
- Security & Supply Chain: Explicitly disables Renovate automerge and platformAutomerge for github-actions manager rules, preventing automated merge of action code with elevated token permissions.
- Test Enforcement: Adds test_no_rule_automerges_an_action_update and test_the_actions_rule_states_its_stance_explicitly in tests/test_renovate_coverage.py to assert this stance permanently.
- Validation: Factory contract, validate.py, and unittest suite pass cleanly against current main.
- Outstanding: PR carries the hold label and requires maintainer review to remove hold before landing.
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
Fix
renovate.jsongrantedautomerge: true+platformAutomerge: trueto thegithub-actionsmanager fordigest,patchandminorupdates. Every workflow in this factory runs actions withcontents: write,packages: writeandid-token: write, so a bumped action ref executes with the tokens that sign and publish our RPMs the moment it lands — before any maintainer reads the diff.This drops automerge for that rule and states the stance explicitly.
Why the build-root-image rule keeps its automerge and this one does not
The
build-root-imagerule earns it: a rotted digest fails every job in the run with exit 125 before a line of script executes, and the replacement is whatever the pinned tag already resolves to — waiting for review costs more than it protects. An action pin has neither property. A moved action ref does not fail the run; it runs something else. So automerging actions buys no availability and spends the only review this supply chain gets.Files / functions claimed by this PR
renovate.json— the singlematchManagers: ["github-actions"]packageRule. No other rule, custom manager, or theupstream-source/build-root-imagebehaviour is touched.tests/test_renovate_coverage.py— two new cases inRenovateCoverageTests:test_no_rule_automerges_an_action_updateandtest_the_actions_rule_states_its_stance_explicitly. The existingtest_a_digest_update_may_land_without_a_humanis unchanged and still passes.automerge/platformAutomergeare pinned tofalseon the rule rather than left to the top-level default, so a futureconfig:recommendedbump cannot re-enable automerge without producing a diff in this file — and the second test fails if the rule is ever removed or left implicit.Verification
pytest tests/test_renovate_coverage.py— 7 passed.automerge: truefails both new tests; restoring returns to green.pytest tests/— 318 passed, 27 subtests passed.Consistency
This matches how the identical finding was resolved in
projectbluefin/fsdk-containers, whoserenovate.jsonpinsautomerge: falseon its github-actions rules explicitly.Closes #104
Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.78