Skip to content

fix(renovate): require human review for github-actions updates - #161

Closed
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
sec/renovate-no-actions-automerge
Closed

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
sec/renovate-no-actions-automerge

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Fix

renovate.json granted automerge: true + platformAutomerge: true to the github-actions manager for digest, patch and minor updates. Every workflow in this factory runs actions with contents: write, packages: write and id-token: write, so a bumped action ref executes with the tokens that sign and publish our RPMs the moment it lands — before any maintainer reads the diff.

This drops automerge for that rule and states the stance explicitly.

Why the build-root-image rule keeps its automerge and this one does not

The build-root-image rule earns it: a rotted digest fails every job in the run with exit 125 before a line of script executes, and the replacement is whatever the pinned tag already resolves to — waiting for review costs more than it protects. An action pin has neither property. A moved action ref does not fail the run; it runs something else. So automerging actions buys no availability and spends the only review this supply chain gets.

Files / functions claimed by this PR

  • renovate.json — the single matchManagers: ["github-actions"] packageRule. No other rule, custom manager, or the upstream-source / build-root-image behaviour is touched.
  • tests/test_renovate_coverage.py — two new cases in RenovateCoverageTests: test_no_rule_automerges_an_action_update and test_the_actions_rule_states_its_stance_explicitly. The existing test_a_digest_update_may_land_without_a_human is unchanged and still passes.

automerge/platformAutomerge are pinned to false on the rule rather than left to the top-level default, so a future config:recommended bump cannot re-enable automerge without producing a diff in this file — and the second test fails if the rule is ever removed or left implicit.

Verification

  • pytest tests/test_renovate_coverage.py — 7 passed.
  • Mutation check: flipping the rule back to automerge: true fails both new tests; restoring returns to green.
  • Full suite: pytest tests/ — 318 passed, 27 subtests passed.

Consistency

This matches how the identical finding was resolved in projectbluefin/fsdk-containers, whose renovate.json pins automerge: false on its github-actions rules explicitly.

Closes #104


Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.78

The github-actions packageRule granted automerge + platformAutomerge to
digest, patch and minor updates. Every workflow in this factory runs
actions with contents: write, packages: write and id-token: write, so a
bumped action ref executes with the tokens that sign and publish our
RPMs as soon as it lands, with no maintainer having read it.

The build-root-image rule earns its automerge: a rotted digest fails
every job in the run before a line of script executes, and the
replacement is whatever the pinned tag already resolves to, so waiting
for review costs more than it protects. An action pin has neither
property -- a moved ref does not fail the run, it runs something else.

Pin the stance to false explicitly rather than relying on the top-level
default, so a config:recommended bump cannot re-enable it without a diff
in this file, and gate both properties in tests/test_renovate_coverage.py.

Assisted-by: Claude Opus 5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added the hold Work is intentionally paused. label Sep 19, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "scanner" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "scanner". If this is an outreach PR, a human must review it and remove the label.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Deferred to the shared CI incident, not repaired here.

publish is red on the default branch main as well — run 105916317395, 2026-09-19T14:58:40Z:

Failed to resolve the transaction:
  - nothing provides libnfs.so.16()(64bit) needed by gvfs-nfs-1.61.91-1.hum1.bfin.x86_64 from factory
  - nothing provides libabsl_*.so.2601.0.0()(64bit) needed by ibus-mozc-2.29.5111.102-21.hum1.bfin.x86_64 from factory

This PR changes renovate.json only. It cannot produce or repair an RPM soname resolution failure in the Hummingbird-only consumer transaction, so the red check is external to this diff.

Tracked as one repository incident in #153. Deferring this PR until that incident closes or publish is green on main — no PR-local retry or repair will help.

🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-opus-5

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substantive review:

  • Security & Supply Chain: Explicitly disables Renovate automerge and platformAutomerge for github-actions manager rules, preventing automated merge of action code with elevated token permissions.
  • Test Enforcement: Adds test_no_rule_automerges_an_action_update and test_the_actions_rule_states_its_stance_explicitly in tests/test_renovate_coverage.py to assert this stance permanently.
  • Validation: Factory contract, validate.py, and unittest suite pass cleanly against current main.
  • Outstanding: PR carries the hold label and requires maintainer review to remove hold before landing.

@hanthor

hanthor commented Sep 20, 2026

Copy link
Copy Markdown
Member

Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline.

@hanthor hanthor closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Work is intentionally paused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] renovate.json automerges GitHub Actions digest/patch/minor updates with no human review gate

2 participants