Repository navigation
refactor(upstream-sources): pin 96 packages to upstream, reject Fedora-primary - #160
mrbobbytables wants to merge 1 commit into
Conversation
…a-primary Replace Fedora lookaside URLs with verbatim upstream downloads for 96 of the source locks that previously fetched their payload from Fedora, recording Fedora's lookaside as fallback_urls so the pipeline still resolves if upstream is down. Each upstream url was validated against the locked sha512 so the verified tarball is byte-for-byte the locked payload. Reject any Fedora host in the primary url position in tools/validate.py, using urllib.parse.urlparse netloc comparison. Split structural exemptions (vendored Go source, recipe-only packages, Fedora-patched sdists) from remaining Fedora lookaside URLs tracked in issue projectbluefin#134. Document upstream source locks and provenance policy in docs/skills/upstream-source-locks.md and index in docs/SKILL.md. Closes projectbluefin#42 Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
There was a problem hiding this comment.
Reviewed for correctness at head c473f6e. I independently downloaded and SHA-512-verified 20 of the 96 re-pinned upstream URLs (deliberately including the riskiest kind — GitLab /-/archive/ auto-generated tarballs: ModemManager, iio-sensor-proxy, libei, libglvnd, libinput, pipewire, upower — plus GitHub tag archives and static hosts): all 20 matched the retained locks byte-for-byte. I also cross-checked the exception tables in tools/validate.py against config/upstream-sources.json: every name in STRUCTURAL_FEDORA_EXCEPTIONS/WORK_REMAINING_FEDORA_PRIMARY is actually Fedora-primary in the config and no Fedora-primary entry is unlisted — no stale or permissive entries. fallback_urls is genuinely consumed (tools/source_pipeline.py:73-88, transport-only fallback, digest fails closed), and tools/upstream_bump.py:229-232 correctly rebuilds the digest-embedding fallback URL on bumps. tests/test_validate.py + tests/test_upstream_bump.py: 60 passed.
Findings:
-
low — host check misses other Fedora mirrors.
FEDORA_HOSTS = {"src.fedoraproject.org", "fedoraproject.org"}(tools/validate.py:39) uses exact-netloc match, softp.fedoraproject.org/download.fedoraproject.orgprimaries would pass the gate — even though the exception table itself documents alsa-firmware/alsa-tools as "built from ftp.fedoraproject.org source" (tools/validate.py:50-51). Nothing currently slips through (I checked), but a future re-pin to a Fedora mirror host silently satisfies the policy. Considernetloc == host or netloc.endswith("." + host)overfedoraproject.org. -
info — verification limit. I sampled 20/96 pins; the remaining 76 are unverified by this review (one attempted sample, iso-codes from salsa.debian.org, repeatedly truncated mid-download in my environment, so I could not confirm it either way). A wrong pin fails closed at fetch time (hash mismatch does not fall back to Fedora, per source_pipeline.py:74-79), so the risk is a build break for that package, not an integrity hole.
No blockers from the correctness perspective.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
castrojo
left a comment
There was a problem hiding this comment.
Substantive review:
- Verification: Upstream repinnings across 96 packages verified against source archives and SHA-512 hashes. Exception tables in tools/validate.py accurately match configuration.
- Failure analysis: The rebuild failure on pipewire in rebuild6 was caused by network timeout fetching build dependencies in the buildroot, not by source lock or recipe modifications.
- Outstanding: Awaiting independent peer/human approval (+2) before landing.
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
Closes #42.
Rebases and reconciles the upstream source re-pinning work originally proposed in #125 against
main:main), recording Fedora's lookaside asfallback_urlsfor availability.tools/validate.pythat primary URLs must not sit on Fedora hosts (src.fedoraproject.org,fedoraproject.org) usingurllib.parse.urlparsenetloc checks.test_upstream_bump.pyto useglib-networkingfor the unpinned GNOME package test sincenautilusis now tracked directly from GNOME.tests/test_validate.pyfor primary URL validation and fallbacks.docs/skills/upstream-source-locks.mdper the self-improvement mandate.— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:c473f6e