Skip to content

feat: build the complete Bluefin multimedia override closure - #157

Closed
mrbobbytables wants to merge 2 commits into
projectbluefin:mainfrom
mrbobbytables:feat/bluefin-multimedia-override-closure
Closed

mrbobbytables wants to merge 2 commits into
projectbluefin:mainfrom
mrbobbytables:feat/bluefin-multimedia-override-closure

Conversation

@mrbobbytables

Copy link
Copy Markdown
Contributor

Closes #24.

Builds the complete Bluefin multimedia override and codec closure for Hummingbird targeting.

Summary of changes

  1. Add missing closure recipes (6 packages):

    • PackageKit (supplying PackageKit-gstreamer-plugin)
    • alsa-utils (supplying alsa-utils)
    • ffmpegthumbnailer (supplying ffmpegthumbnailer and ffmpegthumbnailer-libs)
    • gstreamer1-plugin-libav (supplying gstreamer1-plugin-libav)
    • gstreamer1-plugins-ugly-free (supplying gstreamer1-plugins-ugly-free)
    • rust-gst-plugin-dav1d (supplying gstreamer1-plugin-dav1d)
  2. Versioned compatibility Provides:

    • packages/ffmpeg/ffmpeg.spec: added versioned Provides: for ffmpeg, ffmpeg-libs, libavcodec, libavdevice, libavfilter, libavformat, libavutil, libswresample, and libswscale so Bluefin and @multimedia transaction names resolve to factory free-codec builds.
    • packages/fdk-aac-free/fdk-aac-free.spec: added versioned Provides: libfdk-aac = %{?epoch:%{epoch}:}%{version}-%{release}.
  3. Manifest and closure inventory:

    • config/bluefin-packages.toml: expanded [multimedia_overrides] to list all 45 binaries of the mandatory multimedia closure, recorded alsa-ucm in [hummingbird_provided], and populated [multimedia_sources.source_by_binary].
    • config/upstream-sources.json and .packit.yaml: added source locks and rendered Packit configs for all 6 packages (total 346 source RPMs).
    • reports/bluefin-multimedia-closure.json: machine-readable report mapping all 45 multimedia requirements to factory source, binary, and expected NEVRA, documenting alsa-ucm as Hummingbird-provided and gstreamer-plugins-espeak as conditional exception.
  4. Validation and tooling:

    • Added tools/validate_multimedia_closure.py and tests/test_multimedia_closure.py to enforce the closure contract.
    • Updated tools/import_bluefin_rawhide.py and tests/test_rawhide_sources.py to honor explicit_sources mapping.
    • Updated test package count assertions from 340 to 346.
  5. Documentation and skills:

    • Added docs/skills/multimedia-closure.md procedure skill and indexed it in docs/SKILL.md.
    • Documented the closure, -free naming, and buildroot exception handling in docs/targeting-hummingbird.md.

Validation

  • just check: passed (factory-check 2513 files, validate 346 source RPMs)
  • just test: passed (322 passed, 27 subtests passed)
  • python3 tools/validate_multimedia_closure.py: passed (45 built, 1 Hummingbird-provided)
  • python3 tools/runtime_contract.py config/bluefin-packages.toml config/runtime-contract.toml --check: passed

— hive: backend=copilot model=gemini-3.8-flash

🐝 Hive Agent: contributor | SHA: 94332f1

Close the remaining Bluefin multimedia override and codec closure for
Hummingbird targeting:
- Add recipes for the 6 missing closure packages: PackageKit, alsa-utils,
  ffmpegthumbnailer, gstreamer1-plugin-libav, gstreamer1-plugins-ugly-free,
  and rust-gst-plugin-dav1d.
- Add versioned compatibility Provides to ffmpeg.spec and fdk-aac-free.spec
  for unsuffixed Bluefin transaction names (ffmpeg, ffmpeg-libs, libav*,
  and libfdk-aac).
- Update config/bluefin-packages.toml [multimedia_overrides] with the full
  45-binary transaction, [hummingbird_provided] with alsa-ucm, and
  [multimedia_sources.source_by_binary] mappings.
- Add machine-readable NEVRA closure report reports/bluefin-multimedia-closure.json,
  tools/validate_multimedia_closure.py validator, and unit tests.
- Support explicit source overrides in tools/import_bluefin_rawhide.py.
- Document closure and workflow in docs/skills/multimedia-closure.md,
  docs/SKILL.md, and docs/targeting-hummingbird.md.

Assisted-by: Gemini 3.8 Flash via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (head 94332f1)

GStreamer version skew makes the two new plugin recipes unbuildable against the factory's own core (medium-high).
The closure pins GStreamer core/base/good/bad at 1.28.6 (config/upstream-sources.json: gstreamer-1.28.6.tar.xz, gst-plugins-base-1.28.6.tar.xz; report NEVRA gstreamer1-1.28.6-2.hum1.bfin in reports/bluefin-multimedia-closure.json), but both new plugin recipes are 1.28.7 and hard-require a matching core:

  • packages/gstreamer1-plugin-libav/gstreamer1-plugin-libav.spec:2,11-12 — Version: 1.28.7 with BuildRequires: gstreamer1-devel >= %{version} and gstreamer1-plugins-base-devel >= %{version}
  • packages/gstreamer1-plugins-ugly-free/gstreamer1-plugins-ugly-free.spec:8,25-26 — same pattern

>= 1.28.7 cannot be satisfied by the factory's 1.28.6 gstreamer1/plugins-base. Either the build fails outright, or (if the buildroot mixes Fedora Rawhide repos) it silently links against Fedora's newer core instead of the factory's — exactly the fallback docs/targeting-hummingbird.md:171-177 says the Provides work exists to prevent. just check/just test only validate source locks and report consistency, so this would not have surfaced. Fix: align the whole GStreamer set on one micro version (bump core/base/good/bad to 1.28.7, or import the 1.28.6 gst-libav/ugly specs).

Validator does not check NEVRA/version consistency (low, test adequacy).
tools/validate_multimedia_closure.py:92-94 only requires binary_nevra to be a non-empty string; it never cross-checks the version embedded in the NEVRA against the lock's version in config/upstream-sources.json. The committed report will silently drift stale on every version bump — worth tightening since the report is billed as the machine-readable contract.

The rest checks out: I re-ran tools/validate_multimedia_closure.py against the head files (45 built, 1 provided, 0 errors); all source_by_binary targets and report factory_source names have locks; the ffmpeg/fdk-aac-free versioned Provides (packages/ffmpeg/ffmpeg.spec:332-334 etc., packages/fdk-aac-free/fdk-aac-free.spec:7) match the report's compat-name claims.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78

… version cross-checks

- Align gstreamer1-plugin-libav and gstreamer1-plugins-ugly-free to 1.28.6
  matching core/base/good/bad to eliminate buildroot version skew.
- Update Fedora dist-git commit/tree pins for 1.28.6 in .hummingbird-upstream.json.
- Update config/upstream-sources.json and reports/bluefin-multimedia-closure.json
  to 1.28.6.
- Enforce in tools/validate_multimedia_closure.py that each requirement binary_nevra
  matches the locked source version from config/upstream-sources.json.
- Add test coverage in tests/test_multimedia_closure.py for NEVRA version mismatch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mrbobbytables

Copy link
Copy Markdown
Contributor Author

Addressed review feedback in 16dff16:

  1. GStreamer version skew aligned: Re-aligned gstreamer1-plugin-libav and gstreamer1-plugins-ugly-free on version 1.28.6 to match core, base, good, and bad-free plugins. Updated their specs, dist-git commit/tree pins (d7b2d4d and 207f329), config/upstream-sources.json checksums, and reports/bluefin-multimedia-closure.json NEVRAs.
  2. NEVRA version cross-check in validator: tools/validate_multimedia_closure.py now verifies that each requirement's binary_nevra contains the exact locked source version from config/upstream-sources.json (f'-{expected_version}-' in nevra), preventing report drift on version bumps. Added unit test in tests/test_multimedia_closure.py.

🐝 Hive Agent: contributor | SHA: unknown

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substantive review:

  • Blocker: GStreamer version skew. The two new plugin recipes (gstreamer1-plugin-libav and gstreamer1-plugins-ugly) import 1.28.7 while the factory's core GStreamer packages (gstreamer1, gst-plugins-base, etc.) are pinned at 1.28.6. The specs require matching core versions (>= %{version}), making them unbuildable against factory outputs.
  • Outstanding: Author needs to align the plugin versions to 1.28.6 (or bump core GStreamer in lockstep), followed by CI verification and independent review (+2).

@mrbobbytables

Copy link
Copy Markdown
Contributor Author

@castrojo Just following up on your review note: commit 16dff16 already aligned gstreamer1-plugin-libav and gstreamer1-plugins-ugly-free to 1.28.6 (along with the dist-git commit pins, lock file checksums, NEVRA reports, and closure validation tests). All CI checks are green on 16dff16.

🐝 Hive Agent: contributor | SHA: unknown

@hanthor

hanthor commented Sep 20, 2026

Copy link
Copy Markdown
Member

Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline.

1 similar comment
@hanthor

hanthor commented Sep 20, 2026

Copy link
Copy Markdown
Member

Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline.

@hanthor hanthor closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parity: build the complete Bluefin multimedia override closure

3 participants