Repository navigation
feat: build the complete Bluefin multimedia override closure - #157
mrbobbytables wants to merge 2 commits into
Conversation
Close the remaining Bluefin multimedia override and codec closure for Hummingbird targeting: - Add recipes for the 6 missing closure packages: PackageKit, alsa-utils, ffmpegthumbnailer, gstreamer1-plugin-libav, gstreamer1-plugins-ugly-free, and rust-gst-plugin-dav1d. - Add versioned compatibility Provides to ffmpeg.spec and fdk-aac-free.spec for unsuffixed Bluefin transaction names (ffmpeg, ffmpeg-libs, libav*, and libfdk-aac). - Update config/bluefin-packages.toml [multimedia_overrides] with the full 45-binary transaction, [hummingbird_provided] with alsa-ucm, and [multimedia_sources.source_by_binary] mappings. - Add machine-readable NEVRA closure report reports/bluefin-multimedia-closure.json, tools/validate_multimedia_closure.py validator, and unit tests. - Support explicit source overrides in tools/import_bluefin_rawhide.py. - Document closure and workflow in docs/skills/multimedia-closure.md, docs/SKILL.md, and docs/targeting-hummingbird.md. Assisted-by: Gemini 3.8 Flash via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
There was a problem hiding this comment.
Correctness review (head 94332f1)
GStreamer version skew makes the two new plugin recipes unbuildable against the factory's own core (medium-high).
The closure pins GStreamer core/base/good/bad at 1.28.6 (config/upstream-sources.json: gstreamer-1.28.6.tar.xz, gst-plugins-base-1.28.6.tar.xz; report NEVRA gstreamer1-1.28.6-2.hum1.bfin in reports/bluefin-multimedia-closure.json), but both new plugin recipes are 1.28.7 and hard-require a matching core:
packages/gstreamer1-plugin-libav/gstreamer1-plugin-libav.spec:2,11-12—Version: 1.28.7withBuildRequires: gstreamer1-devel >= %{version}andgstreamer1-plugins-base-devel >= %{version}packages/gstreamer1-plugins-ugly-free/gstreamer1-plugins-ugly-free.spec:8,25-26— same pattern
>= 1.28.7 cannot be satisfied by the factory's 1.28.6 gstreamer1/plugins-base. Either the build fails outright, or (if the buildroot mixes Fedora Rawhide repos) it silently links against Fedora's newer core instead of the factory's — exactly the fallback docs/targeting-hummingbird.md:171-177 says the Provides work exists to prevent. just check/just test only validate source locks and report consistency, so this would not have surfaced. Fix: align the whole GStreamer set on one micro version (bump core/base/good/bad to 1.28.7, or import the 1.28.6 gst-libav/ugly specs).
Validator does not check NEVRA/version consistency (low, test adequacy).
tools/validate_multimedia_closure.py:92-94 only requires binary_nevra to be a non-empty string; it never cross-checks the version embedded in the NEVRA against the lock's version in config/upstream-sources.json. The committed report will silently drift stale on every version bump — worth tightening since the report is billed as the machine-readable contract.
The rest checks out: I re-ran tools/validate_multimedia_closure.py against the head files (45 built, 1 provided, 0 errors); all source_by_binary targets and report factory_source names have locks; the ffmpeg/fdk-aac-free versioned Provides (packages/ffmpeg/ffmpeg.spec:332-334 etc., packages/fdk-aac-free/fdk-aac-free.spec:7) match the report's compat-name claims.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
… version cross-checks - Align gstreamer1-plugin-libav and gstreamer1-plugins-ugly-free to 1.28.6 matching core/base/good/bad to eliminate buildroot version skew. - Update Fedora dist-git commit/tree pins for 1.28.6 in .hummingbird-upstream.json. - Update config/upstream-sources.json and reports/bluefin-multimedia-closure.json to 1.28.6. - Enforce in tools/validate_multimedia_closure.py that each requirement binary_nevra matches the locked source version from config/upstream-sources.json. - Add test coverage in tests/test_multimedia_closure.py for NEVRA version mismatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Addressed review feedback in 16dff16:
🐝 Hive Agent: |
castrojo
left a comment
There was a problem hiding this comment.
Substantive review:
- Blocker: GStreamer version skew. The two new plugin recipes (gstreamer1-plugin-libav and gstreamer1-plugins-ugly) import 1.28.7 while the factory's core GStreamer packages (gstreamer1, gst-plugins-base, etc.) are pinned at 1.28.6. The specs require matching core versions (>= %{version}), making them unbuildable against factory outputs.
- Outstanding: Author needs to align the plugin versions to 1.28.6 (or bump core GStreamer in lockstep), followed by CI verification and independent review (+2).
@castrojo Just following up on your review note: commit 16dff16 already aligned
|
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
1 similar comment
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
Closes #24.
Builds the complete Bluefin multimedia override and codec closure for Hummingbird targeting.
Summary of changes
Add missing closure recipes (6 packages):
PackageKit(supplyingPackageKit-gstreamer-plugin)alsa-utils(supplyingalsa-utils)ffmpegthumbnailer(supplyingffmpegthumbnailerandffmpegthumbnailer-libs)gstreamer1-plugin-libav(supplyinggstreamer1-plugin-libav)gstreamer1-plugins-ugly-free(supplyinggstreamer1-plugins-ugly-free)rust-gst-plugin-dav1d(supplyinggstreamer1-plugin-dav1d)Versioned compatibility Provides:
packages/ffmpeg/ffmpeg.spec: added versionedProvides:forffmpeg,ffmpeg-libs,libavcodec,libavdevice,libavfilter,libavformat,libavutil,libswresample, andlibswscaleso Bluefin and@multimediatransaction names resolve to factory free-codec builds.packages/fdk-aac-free/fdk-aac-free.spec: added versionedProvides: libfdk-aac = %{?epoch:%{epoch}:}%{version}-%{release}.Manifest and closure inventory:
config/bluefin-packages.toml: expanded[multimedia_overrides]to list all 45 binaries of the mandatory multimedia closure, recordedalsa-ucmin[hummingbird_provided], and populated[multimedia_sources.source_by_binary].config/upstream-sources.jsonand.packit.yaml: added source locks and rendered Packit configs for all 6 packages (total 346 source RPMs).reports/bluefin-multimedia-closure.json: machine-readable report mapping all 45 multimedia requirements to factory source, binary, and expected NEVRA, documentingalsa-ucmas Hummingbird-provided andgstreamer-plugins-espeakas conditional exception.Validation and tooling:
tools/validate_multimedia_closure.pyandtests/test_multimedia_closure.pyto enforce the closure contract.tools/import_bluefin_rawhide.pyandtests/test_rawhide_sources.pyto honorexplicit_sourcesmapping.Documentation and skills:
docs/skills/multimedia-closure.mdprocedure skill and indexed it indocs/SKILL.md.-freenaming, and buildroot exception handling indocs/targeting-hummingbird.md.Validation
just check: passed (factory-check2513 files,validate346 source RPMs)just test: passed (322 passed, 27 subtests passed)python3 tools/validate_multimedia_closure.py: passed (45 built, 1 Hummingbird-provided)python3 tools/runtime_contract.py config/bluefin-packages.toml config/runtime-contract.toml --check: passed— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:94332f1