Repository navigation
Conversation
Document source precedence, digest-pinned OCI layout, provenance, publication authorization, retention, and fail-closed verification requirements. Strengthen the unavailable-upstream regression to verify unchanged bytes and checksum evidence. Assisted-by: openai-codex/gpt-5.6-luna via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Douglas Baggett <doug.baggett@gmail.com>
There was a problem hiding this comment.
Correctness review (read at head 2850d8e)
One low-severity inaccuracy, no blockers:
docs/rfcs/oras-source-lookaside.md:289attributestest_rejects_source_overwritten_after_stagingtoStagedVerificationTests, but that test lives inSourcePipelineTests(tests/test_source_pipeline.py:167);StagedVerificationTests(line 553) contains different tests. Worth fixing so the RFC's fail-closed test citations stay greppable.
Verified: the rewritten test_uses_fallback_only_after_upstream_transport_failure (tests/test_source_pipeline.py:54-113) is consistent with tools/source_pipeline.py (sha256_url at line 331, resolved_url at line 340) and is a strict coverage improvement over the old mock-count assertion — it now checks delivered bytes, SHA-512, report contents, and exact fetch order. Full suite (35 tests) passes at the head SHA.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
castrojo
left a comment
There was a problem hiding this comment.
Substantive review:
- Specification & Design: The RFC defines clear provenance requirements, content-addressed OCI layout, fail-closed fallback invariants, and strict publication guardrails for future ORAS source lookaside.
- Test quality: The updated test in tests/test_source_pipeline.py cleanly exercises the end-to-end fallback path with deterministic fixtures.
- Validation: Factory contract, recipe set agreement, and all 317 unit tests pass cleanly against current main.
- Outstanding: Awaiting independent human/peer approval (+2) before landing.
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
1 similar comment
|
Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline. |
Summary
Closes #26
Verification
just checkpassespython3 -m unittest discover -s tests -p 'test_source_pipeline.py'passes (35 tests)PYTHONPATH=. uv run --with pytest --with pyyaml pytest tests -qpasses (316 tests, 27 subtests)uvx pre-commit run --all-filespasses all hooks except the existing actionlint error at.github/workflows/build-stage.yml:55just testcannot run in the base interpreter because it lacks pytest; the equivalent isolated-dependency suite passes— hive: backend=omp