Skip to content

docs: define ORAS source lookaside policy - #156

Closed
Danathar wants to merge 1 commit into
projectbluefin:mainfrom
Danathar:docs/oras-source-lookaside-rfc
Closed

Danathar wants to merge 1 commit into
projectbluefin:mainfrom
Danathar:docs/oras-source-lookaside-rfc

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary

  • define upstream, Fedora lookaside, and digest-pinned ORAS precedence
  • specify OCI source layout, signed provenance schema, publication authorization, and retention
  • strengthen fallback regression coverage for unchanged bytes and checksum evidence

Closes #26

Verification

  • just check passes
  • python3 -m unittest discover -s tests -p 'test_source_pipeline.py' passes (35 tests)
  • PYTHONPATH=. uv run --with pytest --with pyyaml pytest tests -q passes (316 tests, 27 subtests)
  • uvx pre-commit run --all-files passes all hooks except the existing actionlint error at .github/workflows/build-stage.yml:55
  • just test cannot run in the base interpreter because it lacks pytest; the equivalent isolated-dependency suite passes

— hive: backend=omp

Document source precedence, digest-pinned OCI layout, provenance, publication authorization, retention, and fail-closed verification requirements. Strengthen the unavailable-upstream regression to verify unchanged bytes and checksum evidence.

Assisted-by: openai-codex/gpt-5.6-luna via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Douglas Baggett <doug.baggett@gmail.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (read at head 2850d8e)

One low-severity inaccuracy, no blockers:

  • docs/rfcs/oras-source-lookaside.md:289 attributes test_rejects_source_overwritten_after_staging to StagedVerificationTests, but that test lives in SourcePipelineTests (tests/test_source_pipeline.py:167); StagedVerificationTests (line 553) contains different tests. Worth fixing so the RFC's fail-closed test citations stay greppable.

Verified: the rewritten test_uses_fallback_only_after_upstream_transport_failure (tests/test_source_pipeline.py:54-113) is consistent with tools/source_pipeline.py (sha256_url at line 331, resolved_url at line 340) and is a strict coverage improvement over the old mock-count assertion — it now checks delivered bytes, SHA-512, report contents, and exact fetch order. Full suite (35 tests) passes at the head SHA.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substantive review:

  • Specification & Design: The RFC defines clear provenance requirements, content-addressed OCI layout, fail-closed fallback invariants, and strict publication guardrails for future ORAS source lookaside.
  • Test quality: The updated test in tests/test_source_pipeline.py cleanly exercises the end-to-end fallback path with deterministic fixtures.
  • Validation: Factory contract, recipe set agreement, and all 317 unit tests pass cleanly against current main.
  • Outstanding: Awaiting independent human/peer approval (+2) before landing.

@hanthor

hanthor commented Sep 20, 2026

Copy link
Copy Markdown
Member

Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline.

1 similar comment
@hanthor

hanthor commented Sep 20, 2026

Copy link
Copy Markdown
Member

Closing to consolidate the queue on the merged #178 full-factory candidate. The branch is retained; please re-open or submit a fresh, rebased PR after that build establishes the current baseline.

@hanthor hanthor closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: content-addressed ORAS source lookaside fallback

3 participants