Skip to content

build: pin every lane to the digest-pinned Packit container (closes #43) - #120

Closed
kylerankin wants to merge 1 commit into
projectbluefin:mainfrom
kylerankin:fix/build-container-rule
Closed

kylerankin wants to merge 1 commit into
projectbluefin:mainfrom
kylerankin:fix/build-container-rule

Conversation

@kylerankin

Copy link
Copy Markdown
Contributor

#43 — build container: the AGENTS.md rule and every real build disagree

AGENTS.md already required the digest-pinned quay.io/packit/packit container
and forbade a mutable tag, but the real build lanes disagreed:

This PR makes reality match the rule:

  • build-stage.yml, rebuild-rpms.yml: swap quay.io/fedora/fedora@sha256:a58a82…
    for quay.io/packit/packit@sha256:fb449261… (live packit:latest, 2026-09-16).
  • packit-srpm-pilot.yml: replace the garbage-collected 8a178425… with the
    live fb449261…; update the pin-date comment.
  • docs/architecture.md and the approved design spec: reflect the now-pinned
    lanes and the live digest.
  • tests/test_packit_srpm.py: assert the live pin.

Digest fb449261… is verified alive against the manifest list. The upstream
Packit image is rebuilt daily, so it is re-pinned when upstream republishes.

Still open (not this PR)

— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K

…rojectbluefin#43)

AGENTS.md already required the digest-pinned quay.io/packit/packit image
and forbade a mutable tag, but the binary lane (build-stage.yml) and both
rebuild-rpms.yml jobs (preflight, precedence) built in
quay.io/fedora/fedora@sha256:a58a82… instead. Every real build disagreed
with the rule — the exact regression projectbluefin#43 reports.

- build-stage.yml, rebuild-rpms.yml: swap fedora:44 for
  quay.io/packit/packit@sha256:fb449261… (live packit:latest, 2026-09-16)
- packit-srpm-pilot.yml: replace the garbage-collected pin 8a178425… with
  the live fb449261… and update the pin-date comment
- docs/architecture.md, specs: reflect the now-pinned lanes and the live
  digest
- tests/test_packit_srpm.py: assert the live pin

The build engine is still hand-rolled rpmbuild, not Mock — that half of projectbluefin#43
remains open. The tag-mutation guard is PR projectbluefin#110.

Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

Closing as superseded: #110 merged the guard for #43 — tools/check_build_container_pinning.py fails any workflow that names a quay.io build image without a digest, runs in just check and pre-commit, and passes on main today ("every quay.io build image is digest-pinned"). The lanes this would have re-pinned were rewritten by #70 and #133, which is why it conflicts. If there's a lane the guard doesn't cover, say which and I'll widen it.


Generated by Claude Code

@hanthor hanthor closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants