Repository navigation
fix(gdm): accept gnome-keyring-pam until oo7 publishes - #1194
Conversation
projectbluefin#1156 made gdm require pam_oo7, but oo7 has never built here: its Rawhide snapshot needs formatx 0.4, gettext-rs 0.8 and zgvariant 1, and Fedora 44 provides none of them. The scheduled run 44010051148 rebuilt gdm 1:51.0-2, and the publish job's Hummingbird-only transaction then refused the whole candidate on "nothing provides pam_oo7 needed by gdm". gupnp-av, kmscon, sudo-rs, uutils-coreutils, nerd-fonts-symbols, google-noto-serif-cjk-vf-fonts and gnome-shell-extension-blur-my-shell all built in that run and are still unpublished because of it. gdm 51's PAM files load both pam_oo7.so and pam_gnome_keyring.so as optional modules, so either provider works. Require either one, so gdm installs with the published gnome-keyring-pam now and with pam_oo7 once oo7 builds. The triage skill gets the failure signature. Assisted-by: Claude Opus 5.5 via Claude Code Signed-off-by: Juan Resendiz <juanresendiz813@gmail.com>
a45262b to
72947bd
Compare
|
Ready for a human merge: verdict approved @72947bd, 23/23 checks green, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
hanthor
left a comment
There was a problem hiding this comment.
The change is right, and it unblocks publish: no repository provides pam_oo7 today, so every full run that rebuilds gdm is refused. gdm 51's gdm-password and gdm-autologin load both pam_gnome_keyring.so and pam_oo7.so as optional, so either provider works. Keeping Release 2 is fine because 1:51.0-2 never published.
How this fits with projectbluefin/utah#1304 (oo7 replaces gnome-keyring):
- With this PR, utah#1304 no longer needs a gdm that requires
pam_oo7. It only needs oo7 to publish. Its body says the published gdm conflicts withpam_oo7throughObsoletes: gnome-keyring-pam < 51, but, as you noted, that Obsoletes is not emitted on the F44 build root. The two can be installed together. - So utah#1304 must keep
gnome-keyring-pam(andgnome-keyring) in[excluded]. If it doesn't, the image could end up with both PAM modules and two keyring daemons unlocking at login. - Follow-up: once oo7 publishes and utah#1304 lands, go back to
Requires: pam_oo7to match Rawhide, or keep the rich dependency on purpose and say so in the spec comment.
This touches a PAM dependency, so I'm leaving the merge to the maintainer and not approving here.
Reviewed on behalf of @hanthor with Claude Code
|
Post-merge security check: this is fine. In gdm 51's One thing to watch: if an image ever ships both, both keyring daemons auto-start at login. Utah should pick one. Reviewed on behalf of @hanthor with Claude Code |
Summary
Every full factory run is currently refused at publish, and the cause is gdm, not the mirror timeouts in the same run.
#1156 changed gdm to
Requires: pam_oo7, but oo7 has never built here, so nothing providespam_oo7. The scheduled run 44010051148 rebuilt gdm 1:51.0-2, and the publish job's Hummingbird-only transaction then refused the whole candidate:That run built gupnp-av, kmscon, sudo-rs, uutils-coreutils, nerd-fonts-symbols, google-noto-serif-cjk-vf-fonts and gnome-shell-extension-blur-my-shell. None of them published, because the gate failed. The intermediate gate (
publish0) failed on the samepam_oo7line. #1192's triage comment blames the mirror outage for the whole run. The outage did cause the baobab, rygel and glog failures, but re-running cannot fix the gate: every full run that rebuilds gdm will fail it the same way untilpam_oo7exists.oo7 itself fails at lock resolution:
nothing provides requested (crate(formatx/default) >= 0.4.0 ...), and the same for gettext-rs 0.8 and zgvariant 1. Fedora 44 has formatx 0.2.4 and gettext-rs 0.7.7, and no zgvariant at all. A separate PR vendors those crates.Change
packages/gdm/gdm.spec:Requires: (pam_oo7 or gnome-keyring-pam). gdm 51'sdata/pam-redhat/gdm-password.pamandgdm-autologin.pamload bothpam_gnome_keyring.soandpam_oo7.soas-auth/-password/-session optional, so either provider works. The published gnome-keyring-pam 50.0-1 satisfies it today, and pam_oo7 satisfies it once oo7 builds. Release stays 2, because 1:51.0-2 never published (the published gdm is 1:51.0-1)..agents/skills/build-failure-triage/SKILL.md: a classification row for this signature (aRequireson a factory subpackage that has never published blocks the whole candidate).One side note for whoever lands utah's oo7 switch: oo7's
Obsoletes: gnome-keyring(-pam) < 51sits behind%if ! (0%{?fedora} && 0%{?fedora} < 45). The build root has fedora-release 44, so that Obsoletes is not emitted here, and pam_oo7 and gnome-keyring-pam can be installed together.Validation
just check: green (1650 passed).rpmspec -q --requiresin fedora:44 prints(pam_oo7 or gnome-keyring-pam).Refs #1192, #1156, projectbluefin/utah#1313
Assisted-by: Claude Opus 5.5 via Claude Code