Skip to content

fix(utah-install-set): fetch Utah's base.toml, falling back to bluefin.toml - #1052

Merged
hanthor merged 21 commits into
mainfrom
fix/install-set-base-manifest
Nov 16, 2026
Merged

hanthor merged 21 commits into
mainfrom
fix/install-set-base-manifest

Conversation

@hanthor

@hanthor hanthor commented Nov 16, 2026

Copy link
Copy Markdown
Member

projectbluefin/utah#1253 renames Utah's base manifest packages/bluefin.toml → packages/base.toml (sections unchanged). tools/utah_install_set.py fetched the old path from Utah's main, so the publish workflow's advisory step Fetch what Utah installs, and its base image would 404 once the rename lands (it is continue-on-error, so the check would quietly fall back instead of running).

  • FILES["manifest"] is now packages/base.toml; a new FALLBACKS map retries packages/bluefin.toml only on an HTTP 404 for the manifest. Any other error, or a 404 on another file, still raises.
  • The fetched file keeps its own name (base.toml or bluefin.toml); main() already uses the returned path.
  • Tests: fixtures renamed to base.toml; new cases for old ref → bluefin.toml, both present → base.toml, missing under both names → error, non-404 / non-manifest 404 → no fallback.
  • Docs: docs/architecture.md install-set paragraph and the publish-repository.yml step comment name both paths.

Once utah#1253 is on Utah's main, the fallback can be dropped.

Verification:

  • python3 tools/utah_install_set.py fetch --dir … against Utah main (old name, falls back → bluefin.toml, 319 packages) and against feat/dakota-parity-target (utah#1253 head → base.toml, 319 packages).
  • just check: green (1571 passed).

…n.toml

projectbluefin/utah#1253 renames Utah's base manifest from
packages/bluefin.toml to packages/base.toml with unchanged sections. The
advisory install-set check fetched the old name from Utah's main, so the
rename would 404 the fetch and silently drop the check. Fetch base.toml
first and fall back to bluefin.toml only on a 404, so the check works on
both sides of the rename.

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hanthor
hanthor enabled auto-merge (squash) November 16, 2026 04:04
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stand-in review (the hive's reviewers are out of quota). Approving. This fixes the cross-repo break I raised on projectbluefin/utah#1253.

Checked:

  • fetch() now asks for packages/base.toml first and falls back to packages/bluefin.toml only on a 404 for the manifest key. Any other status, or a 404 on another file, still raises.
  • install_set is computed at fetch time from the paths fetch() returns, and resolve only reads the packages.txt written from them, so no hard-coded bluefin.toml remains in the code path. The remaining mentions are the fallback constant and its comments.
  • The four new tests cover a ref from before the rename, both names existing (base.toml wins), both missing, and the 404-only rule.

Landing this before or with utah#1253 keeps "Fetch what Utah installs" working through the rename.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head ecdf7ebe52c1, which edits CI workflow / action files. That explicit owner approval releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. A new push re-arms the fence until the new head is approved again; the hive's own merge of the base branch, which leaves the diff unchanged, does not.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head 0afd286fea3c, which edits CI workflow / action files. Head 0afd286fea3c is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
0afd286

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head 0afd286fea3c) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/publish-repository.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head 9d2db42ea041, which edits CI workflow / action files. Head 9d2db42ea041 is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head 0b4b6a1cb14c, which edits CI workflow / action files. Head 0b4b6a1cb14c is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head e2b5425a1c4d, which edits CI workflow / action files. Head e2b5425a1c4d is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head 84c259ed4bc8, which edits CI workflow / action files. Head 84c259ed4bc8 is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar approved head 84c259ed4bc8, which edits CI workflow / action files. Head 507f35dcdeb1 is only the hive's own merge of the base branch into it — the PR's diff is unchanged — so that approval still releases the contributor lane's workflow-path fence: the hive merges this PR itself once the usual gates (CI, soak, holds, review verdict) are clear. Any other push re-arms the fence until the new head is approved again.

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 16, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

@hanthor this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • "vulkan-headers"]) / build (libical)
  • "vulkan-headers"]) / build (vulkan-headers)
  • pass1 / rebuild0 (["libical"
  • pass1 / rebuild0 (["libical", "vulkan-headers"]) / build (libical)
  • pass6 / preflight
  • pass6 / rebuild0 (["libical"
  • pass6 / rebuild1 (["vulkan-loader"]) / build (vulkan-loader)
  • Canary
  • pass1 / publish / publish
  • pass1 / rebuild1 (["vulkan-loader"]) / build (vulkan-loader)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants