Repository navigation
test(smoke): drop the rehhouari Syncthing toggle check; cover bling's toggle on Utah - #1280
Merged
Merged
Conversation
… toggle on Utah No image ships syncthing-toggle@rehhouari.github.com once projectbluefin/utah#1378 lands: Utah was its only carrier, and Bluefin classic enables no Syncthing toggle. Its @bluefin_classic scenario already skipped on Utah, so it covered nothing. Remove the scenario, its four Syncthing-only steps, the now-unused _systemd_unit_start_stop helper and their unit tests. Utah ships bling's syncthing-toggle@projectbluefin.io with Common's start-stop-only=true default, the same as Dakota, so the installed and dconf check moves from @dakota_only to @dakota_family. The suite-map skill records that rule and the regenerated coverage snapshot. Refs projectbluefin/utah#1357 Assisted-by: Claude Opus via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. ℹ️ Sentinel: informational, author is trusted (owner), merge is not blocked. Head
No |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
projectbluefin/utah#1378 removes
syncthing-toggle@rehhouari.github.com, matching Dakota (projectbluefin/utah#1357). Utah was the only image that shipped it. Bluefin classic doesn't enable any Syncthing toggle (Common'szz0-bluefin-modifications.gschema.override). The@bluefin_classicscenario that checked it already skipped on Utah because Utah is in the Dakota family, so it covered no image.What
bluefin_new_extensions.feature: removes the rehhouari Syncthing Toggle scenario.SYNCTHING_TOGGLE_UUIDand the_systemd_unit_start_stophelper, which nothing else used. Their unit tests go too, and the Quick Settings text-scan tests now use "Tailscale".dakota_extensions.feature: the bling toggle check (syncthing-toggle@projectbluefin.ioinstalled, plusstart-stop-only=true) changes from@dakota_onlyto@dakota_family. Utah already ships bling's toggle, and Common's08-bluefin-syncthing-togglegives it the samestart-stop-only=truedefault as Dakota. Utah's contract asserts the extension and its schema (feat(extensions): drop the rehhouari Syncthing toggle, as Dakota utah#1378).@dakota_family. The coverage snapshot has been regenerated.Verification
ruff check tests/ --select E,F,W --ignore E501: passedpython3 scripts/update_coverage_snapshot.py: regeneratedpython3 scripts/validate_docs.py: passedpython3 scripts/generate_skill_index.py --check: passedpytest tests/unit/test_bluefin_new_extensions_steps.py tests/unit/test_smoke_environment.py: 53 passedRefs projectbluefin/utah#1357
Assisted-by: Claude Opus via GitHub Copilot