Skip to content

test(smoke): drop the rehhouari Syncthing toggle check; cover bling's toggle on Utah - #1280

Merged
hanthor merged 1 commit into
mainfrom
test/drop-rehhouari-syncthing-toggle
Nov 20, 2026
Merged

hanthor merged 1 commit into
mainfrom
test/drop-rehhouari-syncthing-toggle

Conversation

@hanthor

@hanthor hanthor commented Nov 20, 2026

Copy link
Copy Markdown
Member

Why

projectbluefin/utah#1378 removes syncthing-toggle@rehhouari.github.com, matching Dakota (projectbluefin/utah#1357). Utah was the only image that shipped it. Bluefin classic doesn't enable any Syncthing toggle (Common's zz0-bluefin-modifications.gschema.override). The @bluefin_classic scenario that checked it already skipped on Utah because Utah is in the Dakota family, so it covered no image.

What

  • bluefin_new_extensions.feature: removes the rehhouari Syncthing Toggle scenario.
  • The steps file loses that scenario's four steps, SYNCTHING_TOGGLE_UUID and the _systemd_unit_start_stop helper, which nothing else used. Their unit tests go too, and the Quick Settings text-scan tests now use "Tailscale".
  • dakota_extensions.feature: the bling toggle check (syncthing-toggle@projectbluefin.io installed, plus start-stop-only = true) changes from @dakota_only to @dakota_family. Utah already ships bling's toggle, and Common's 08-bluefin-syncthing-toggle gives it the same start-stop-only=true default as Dakota. Utah's contract asserts the extension and its schema (feat(extensions): drop the rehhouari Syncthing toggle, as Dakota utah#1378).
  • The suite-map skill records the rule: content Utah ships too belongs under @dakota_family. The coverage snapshot has been regenerated.

Verification

  • ruff check tests/ --select E,F,W --ignore E501: passed
  • python3 scripts/update_coverage_snapshot.py: regenerated
  • python3 scripts/validate_docs.py: passed
  • python3 scripts/generate_skill_index.py --check: passed
  • pytest tests/unit/test_bluefin_new_extensions_steps.py tests/unit/test_smoke_environment.py: 53 passed
  • Behave dry-run is left to CI, which needs AT-SPI.

Refs projectbluefin/utah#1357

Assisted-by: Claude Opus via GitHub Copilot

… toggle on Utah

No image ships syncthing-toggle@rehhouari.github.com once
projectbluefin/utah#1378 lands: Utah was its only carrier, and Bluefin
classic enables no Syncthing toggle. Its @bluefin_classic scenario already
skipped on Utah, so it covered nothing. Remove the scenario, its four
Syncthing-only steps, the now-unused _systemd_unit_start_stop helper and
their unit tests.

Utah ships bling's syncthing-toggle@projectbluefin.io with Common's
start-stop-only=true default, the same as Dakota, so the installed and
dconf check moves from @dakota_only to @dakota_family. The suite-map
skill records that rule and the regenerated coverage snapshot.

Refs projectbluefin/utah#1357

Assisted-by: Claude Opus via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 20, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

ℹ️ Sentinel: informational, author is trusted (owner), merge is not blocked. Head a7eba9f1329a matched:

  • test_removal: removes 162 test lines while adding 9 (tests/smoke/features/bluefin_new_extensions.feature, tests/smoke/features/dakota_extensions.feature, tests/smoke/features/steps/bluefin_new_extensions_steps.py, tests/unit/test_bluefin_new_extensions_steps.py)

No sentinel-alert label was added. The finding is recorded in the dashboard Security tab and /api/sentinel; set sentinel.trusted_authors_block: true to block trusted authors too.

@hanthor
hanthor merged commit 171ae3d into main Nov 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login no-dco A commit is missing Signed-off-by — run `git rebase --signoff` role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants