Skip to content

test(smoke): log which GNOME 50 workaround branch the Files steps take (GNOME 51 audit rows 4-6) - #1208

Merged
Danathar merged 3 commits into
mainfrom
scanner/gnome51-audit-rows-4-5-6-10
Nov 14, 2026
Merged

Danathar merged 3 commits into
mainfrom
scanner/gnome51-audit-rows-4-5-6-10

Conversation

@Danathar

@Danathar Danathar commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary: We're checking which old test workarounds, written for the previous GNOME desktop release, are still needed on the new one (GNOME 51). #1209 has since recorded the verdicts. This change makes three Files tests write one line to the test log saying which path through the workaround ran, so every later GNOME 51 run re-checks those verdicts. Nothing older desktops rely on is removed.


Why

#1209 (merged) measured rows 4, 5, 6 and 10 of the GNOME 51 audit (#827) with a one-off probe. These log lines let any later smoke run confirm the row 4–6 verdicts without a probe, for example before a GNOME 50 path is dropped once no tested image runs GNOME 50. Behave runs with --no-capture, so every smoke run prints them, once per run.

Row Workaround Reading printed
4 frame/filler toplevel fallback (Files window) gnome-51-audit row 4: Files toplevel role='…'
5 Sidebar item role list item vs button gnome-51-audit row 5: Files sidebar Home item roles=[…]
6 Files AT-SPI app name aliases gnome-51-audit row 6: Files AT-SPI app name='…'

Scope change after the base moved

This PR also logged row 10 (notification dismissal) and reclassified it in the audit. #1209 rewrote that check and recorded row 10's verdict, so the base merge takes main's gnome_notifications_steps.py, its unit tests and gnome-51-audit.md unchanged, and the row 10 part is gone.

Images affected

Every image that runs the smoke Files scenarios. The only change is the extra log lines; no assertion changes.

Checks

  • tests/unit/test_gnome_files_steps.py and test_gnome_notifications_steps.py: 61 passed locally.
  • scripts/validate_docs.py passes, and the GNOME SKILL.md is at its 500-line cap. generate_skill_index.py --check passes.

Refs #827

— hive: agent=scanner backend=claude model=claude-opus-5-5

🤖 Generated with Claude Code

…s 4, 5, 6 and 10

The GNOME 51 audit could not tell "still required" from "obsolete" for
these four rows: their scenarios pass, but nothing recorded which branch
of each workaround matched. Each step now prints one
`gnome-51-audit row N: <reading>` line, so every smoke run on a GNOME 51
image (the PR VM check boots dakota:testing, GNOME 51.1) carries the
evidence without removing a path GNOME 50 images still use.

Row 10 is reclassified LIKELY-KEEP: its banner step ends on a warning
instead of an assertion, so a pass never proved anything.

Refs #827

Hive-Run: #827
Hive-Plan: gnome-51-audit remaining rows 4, 5, 6, 10
Hive-Spec: issue-827#tasks-validate-each-row
Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@Danathar

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: contributor | SHA: unknown

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 14, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

Danathar and others added 2 commits November 14, 2026 05:30
main's #1209 measured the verdicts for rows 4, 5, 6 and 10 and rewrote
the notification dismissal check, so this merge takes main's
gnome-51-audit.md, gnome_notifications_steps.py and its unit tests.
The row 10 log lines are dropped because the branches they reported no
longer exist. The rows 4, 5 and 6 readings in gnome_files_steps.py stay,
and the SKILL.md note now says what they re-check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@Danathar Danathar changed the title test(smoke): record which old-desktop test workaround runs on GNOME 51 for four audit rows test(smoke): log which GNOME 50 workaround branch the Files steps take (GNOME 51 audit rows 4-6) Nov 14, 2026
@Danathar

Copy link
Copy Markdown
Contributor Author

hive-base-moved: merged main at 51a3941 into this branch and resolved the conflicts with #1209. #1209 already recorded the row 10 verdict and rewrote the notification check, so I took main's gnome-51-audit.md, gnome_notifications_steps.py and their tests, and dropped this PR's row 10 changes. The row 4–6 log lines in the Files steps remain. be83d38 also trims the SKILL.md note to keep it at the 500-line cap. Unit tests pass (61), and so do validate_docs.py and the skill-index check. I updated the title and description to match.


🐝 Hive Agent: contributor | SHA: be83d38c


🐝 Hive Agent: contributor | SHA: be83d38c

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Nov 14, 2026

@Danathar Danathar left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: no findings. The change only adds log lines: no assertions change, and the reads happen after nodes the filters already touched (roleName on the sidebar items), so it can't turn a passing step into a failing one. Deduplicating on the full line means different readings within one run all get printed. The claim that the lines show up in every run holds: the gnome-e2e action and e2e.yml both run behave with --no-capture.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn

@Danathar
Danathar merged commit 8514806 into main Nov 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants