Repository navigation
test(smoke): log which GNOME 50 workaround branch the Files steps take (GNOME 51 audit rows 4-6) - #1208
Conversation
…s 4, 5, 6 and 10 The GNOME 51 audit could not tell "still required" from "obsolete" for these four rows: their scenarios pass, but nothing recorded which branch of each workaround matched. Each step now prints one `gnome-51-audit row N: <reading>` line, so every smoke run on a GNOME 51 image (the PR VM check boots dakota:testing, GNOME 51.1) carries the evidence without removing a path GNOME 50 images still use. Row 10 is reclassified LIKELY-KEEP: its banner step ends on a warning instead of an assertion, so a pass never proved anything. Refs #827 Hive-Run: #827 Hive-Plan: gnome-51-audit remaining rows 4, 5, 6, 10 Hive-Spec: issue-827#tasks-validate-each-row Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@Danathar this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
main's #1209 measured the verdicts for rows 4, 5, 6 and 10 and rewrote the notification dismissal check, so this merge takes main's gnome-51-audit.md, gnome_notifications_steps.py and its unit tests. The row 10 log lines are dropped because the branches they reported no longer exist. The rows 4, 5 and 6 readings in gnome_files_steps.py stay, and the SKILL.md note now says what they re-check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
hive-base-moved: merged 🐝 Hive Agent: 🐝 Hive Agent: |
Danathar
left a comment
There was a problem hiding this comment.
Reviewed: no findings. The change only adds log lines: no assertions change, and the reads happen after nodes the filters already touched (roleName on the sidebar items), so it can't turn a passing step into a failing one. Deduplicating on the full line means different readings within one run all get printed. The claim that the lines show up in every run holds: the gnome-e2e action and e2e.yml both run behave with --no-capture.
🤖 Generated with Claude Code
Summary: We're checking which old test workarounds, written for the previous GNOME desktop release, are still needed on the new one (GNOME 51). #1209 has since recorded the verdicts. This change makes three Files tests write one line to the test log saying which path through the workaround ran, so every later GNOME 51 run re-checks those verdicts. Nothing older desktops rely on is removed.
Why
#1209 (merged) measured rows 4, 5, 6 and 10 of the GNOME 51 audit (#827) with a one-off probe. These log lines let any later smoke run confirm the row 4–6 verdicts without a probe, for example before a GNOME 50 path is dropped once no tested image runs GNOME 50. Behave runs with
--no-capture, so every smoke run prints them, once per run.frame/fillertoplevel fallback (Files window)gnome-51-audit row 4: Files toplevel role='…'list itemvsbuttongnome-51-audit row 5: Files sidebar Home item roles=[…]gnome-51-audit row 6: Files AT-SPI app name='…'Scope change after the base moved
This PR also logged row 10 (notification dismissal) and reclassified it in the audit. #1209 rewrote that check and recorded row 10's verdict, so the base merge takes main's
gnome_notifications_steps.py, its unit tests andgnome-51-audit.mdunchanged, and the row 10 part is gone.Images affected
Every image that runs the smoke Files scenarios. The only change is the extra log lines; no assertion changes.
Checks
tests/unit/test_gnome_files_steps.pyandtest_gnome_notifications_steps.py: 61 passed locally.scripts/validate_docs.pypasses, and the GNOMESKILL.mdis at its 500-line cap.generate_skill_index.py --checkpasses.Refs #827
— hive: agent=scanner backend=claude model=claude-opus-5-5
🤖 Generated with Claude Code