Repository navigation
fix(e2e): drop the recursive tmpfiles relabel of the test home - #1207
Merged
Merged
Conversation
The harness's /etc/tmpfiles.d/ci-user.conf began with a recursive `Z /var/home/bluefin-test` rule. Once the runner container is loaded, the home holds Podman storage, and every later boot made systemd-tmpfiles walk its hardlinks, producing systemd_tmpfiles_t -> proc_security_t denials on /proc/sys/fs/protected_hardlinks on every boot after the first (44 in lifecycle run 43510394355). The non-recursive `d` entries already create the home and .ssh and set their mode, owner and label. Found by castrojo in #1205 (whose utah lifecycle run 43535082068 has none of these denials once the rule is gone); redone here with a sign-off and a regression test, since #1205's commit has none. Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
4ee5d81
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @Danathar, head
Hive did not add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Drops the recursive
Z /var/home/bluefin-testrule from the tmpfiles config that the test harness writes into the guest. That rule madesystemd-tmpfileswalk the test container's Podman storage on every boot after the first, which caused thesystemd_tmpfiles_t→proc_security_tSELinux denials in the lifecycle runs. The non-recursivedentries already create the home and.sshand set their mode, owner and label.This is castrojo's fix from #1205, redone with a sign-off and a regression test: #1205's commit has no
Signed-off-by, so the hive can't merge it.Evidence
systemd-tmpfilesdenials, on every boot after the first.chconmac_adminones (utah#1198).Changes
.github/workflows/e2e.yml:ci-user.confkeeps only the twodentries, with a comment explaining why.selinux-enforcing.md: a short note on why the harness must not relabel the home recursively.tests/unit/test_e2e_workflow.py: a regression test. It fails on main and passes here.Tests
The local unit suite passes except the 9
test_quarantine_age_git.pyfailures that also fail on main, and the docs check passes.Supersedes #1205.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn