Skip to content

fix(e2e): drop the recursive tmpfiles relabel of the test home - #1207

Merged
Danathar merged 1 commit into
mainfrom
fix/e2e-home-tmpfiles-no-recursive-relabel
Nov 14, 2026
Merged

Danathar merged 1 commit into
mainfrom
fix/e2e-home-tmpfiles-no-recursive-relabel

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary: Drops the recursive Z /var/home/bluefin-test rule from the tmpfiles config that the test harness writes into the guest. That rule made systemd-tmpfiles walk the test container's Podman storage on every boot after the first, which caused the systemd_tmpfiles_t → proc_security_t SELinux denials in the lifecycle runs. The non-recursive d entries already create the home and .ssh and set their mode, owner and label.

This is castrojo's fix from #1205, redone with a sign-off and a regression test: #1205's commit has no Signed-off-by, so the hive can't merge it.

Evidence

Changes

  • .github/workflows/e2e.yml: ci-user.conf keeps only the two d entries, with a comment explaining why.
  • selinux-enforcing.md: a short note on why the harness must not relabel the home recursively.
  • tests/unit/test_e2e_workflow.py: a regression test. It fails on main and passes here.

Tests

The local unit suite passes except the 9 test_quarantine_age_git.py failures that also fail on main, and the docs check passes.

Supersedes #1205.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn

The harness's /etc/tmpfiles.d/ci-user.conf began with a recursive
`Z /var/home/bluefin-test` rule. Once the runner container is loaded, the
home holds Podman storage, and every later boot made systemd-tmpfiles walk
its hardlinks, producing systemd_tmpfiles_t -> proc_security_t denials on
/proc/sys/fs/protected_hardlinks on every boot after the first (44 in
lifecycle run 43510394355). The non-recursive `d` entries already create
the home and .ssh and set their mode, owner and label.

Found by castrojo in #1205 (whose utah lifecycle run 43535082068 has none
of these denials once the rule is gone); redone here with a sign-off and a
regression test, since #1205's commit has none.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 14, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hivecommons-hive

Copy link
Copy Markdown
Contributor
4ee5d81

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @Danathar, head 4ee5d8198fbb) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/e2e.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@Danathar
Danathar merged commit c62b999 into main Nov 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants