Skip to content

ci(v1-gate): let gnome-e2e pin bumps through and flag hand-check holds - #1151

Merged
hivecommons-hive[bot] merged 2 commits into
mainfrom
ci/v1-gate-pin-bumps
Nov 11, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
mainfrom
ci/v1-gate-pin-bumps

Conversation

@Danathar

@Danathar Danathar commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary: two changes to the v1 gate, so it stops waiting on a person when it doesn't need one, and says so clearly when it does.

  1. Pin bumps in the gnome-e2e action no longer hold v1. Renovate's projectbluefin/actions digest bumps change one uses: line in .github/actions/gnome-e2e/action.yml. The gate can't boot that action, so every bump held v1 until someone forced it (chore(deps): update projectbluefin/actions digest to 4199208 #1127, v1 tag held by the post-merge VM gate #1140). Five of the last eight changes to that file were these bumps.
  2. A hold only a person can release is flagged straight away. v1 tag held by the post-merge VM gate #1149 (held by a security-suite change) re-fired on every push overnight without needs-human, because the flag only covered infrastructure failures and holds older than a day.

What I need from you: update-v1-tag.yml is a human-merge path, so a maintainer merges this.


How the pin filter works

Replayed on real history, the last five Renovate bumps (#1127, #1104, #1102, #1095, #1088) drop the action file and boot the other workflow files they touched, instead of holding. #1139 and #1089, real action changes, still hold.

The hold flag

  • hold action: the comment starts with Needs a maintainer, and the issue gets needs-human (and loses good first issue / help wanted).
  • Infrastructure failure, or any hold (including a hand-check one) open for over 24 hours: as before, plus priority/critical-urgent. The hive's review caught that the first version dropped the 24-hour urgency for hand-check holds; fixed in the second commit.

Files

  • scripts/v1_gate_pins.py: the filter (new).
  • .github/workflows/update-v1-tag.yml: calls it in the plan step, and adds the hold flag.
  • scripts/vm_validation_plan.py: the filter never reaches a VM.
  • tests/unit/test_v1_gate_pins.py: new tests.
  • tests/unit/test_update_v1_tag_escalation.py: runs the real "Move or hold v1" step with a stubbed gh and checks the labels (new).
  • docs/skills/ci-ops/ops/references/candidate-vm-validation.md: documents both changes.

Tests

  • tests/unit/test_v1_gate_pins.py: diff cases, plus end-to-end through a scratch git repo. With the escalation tests, test_v1_gate.py and test_vm_validation_plan.py, 60 passed locally. PyYAML isn't on my machine, so the escalation test ran with a local stand-in for yaml.safe_load; CI installs the real one.
  • ruff check and actionlint are clean.
  • test_update_v1_tag_escalation.py covers fresh and day-old hand-check holds, fresh and day-old failed gates, an infrastructure failure, and a move. Against the first commit, only the day-old hand-check case fails, which is the bug the review found.
  • Not run locally: the rest of the unit suite and validate_docs.py, which need PyYAML and behave. CI covers them.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn

Renovate's projectbluefin/actions digest bumps change one `uses:` line in
.github/actions/gnome-e2e/action.yml, which the planner maps to the
gnome-e2e-action lane the gate cannot boot, so every bump held v1 for a
person (#1127, #1140). scripts/v1_gate_pins.py now drops a file under that
action from the plan when its whole diff in the range only swaps one full
commit SHA for another on the same action. Anything else keeps it in.

A `hold` action can only be released by a hand check and a forced run, and
it repeats on every push until then (#1149 sat unflagged). It now gets
"Needs a maintainer" and needs-human straight away. priority/critical-urgent
stays for the infrastructure and 24-hour cases.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026
@codecov-commenter

codecov-commenter commented Nov 11, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 98.18182% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
scripts/v1_gate_pins.py 92.10% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hivecommons-hive

hivecommons-hive Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor
15c9691

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @Danathar, head 15c9691cb353) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/update-v1-tag.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change lets routine dependency updates pass the release checks and immediately flags changes that need manual validation. One regression remains: a change waiting for manual validation no longer receives the urgent label after a day, making a stalled release easier to overlook.

What I need from you: Keep the age-based urgency check independent of the manual-validation check.


correctness

Medium — Preserve urgency for manual holds older than 24 hours. In .github/workflows/update-v1-tag.yml:302-308, ACTION=hold takes the new branch before the existing issue-age branch. Every subsequent manual hold therefore skips the age check, leaving URGENT empty indefinitely; the urgent label is only added when that variable is set at lines 327-329. Executing this shell step with stubbed GitHub calls reproduced the difference: a 48-hour manual hold gets only needs-human, while a 48-hour failed VM check gets both labels.

Run the age check independently, preserving the more specific manual-validation explanation:

--- a/.github/workflows/update-v1-tag.yml
+++ b/.github/workflows/update-v1-tag.yml
@@
           elif [ "${ACTION}" = "hold" ]; then
             ESCALATE="the change needs a lane the gate cannot boot, so only a maintainer's hand check and a forced run can release it. No contributor change clears this hold."
-          elif [ -n "${HELD}" ]; then
+          fi
+          if [ -z "${URGENT}" ] && [ -n "${HELD}" ]; then
             OPENED=$(gh issue view "${HELD}" --json createdAt --jq .createdAt)
             if [ $(( $(date +%s) - $(date -d "${OPENED}" +%s) )) -gt 86400 ]; then
-              ESCALATE="v1 has been held for more than 24 hours."
+              ESCALATE="${ESCALATE:-v1 has been held for more than 24 hours.}"
               URGENT=yes
             fi

Add a regression case for ACTION=hold with an issue older than 24 hours. The proposed patch preserved fresh holds, infrastructure escalation, failed checks, and successful moves in the same shell simulation; no live workflow or VM execution was performed.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=gpt-6.1-sol copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

Review on #1151: the new hand-check branch came before the issue-age check,
so a hold that needs a forced run never turned priority/critical-urgent, even
after days. The age check now runs on its own and keeps the more specific
explanation. tests/unit/test_update_v1_tag_escalation.py runs the real step
with a stubbed gh and covers fresh and day-old hand-check holds, failed
gates, infrastructure failures and a move.

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit e15ef1a into main Nov 11, 2026
7 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#115115c9691` sha256:01801474630f7d24f5a81d6ccaa69ac17269b40529bd5be84a823e1bb7d0fb34 — download from the dashboard or `hivectl review evidence #1151`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @Danathar was auto-promoted after 5 clean merged PRs in this hive's repositories.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants