Skip to content

ci(v1-gate): flag holds that need a maintainer - #1132

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
ci/v1-gate-loud-infra
Nov 10, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
ci/v1-gate-loud-infra

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary: from 2026-11-09 the v1 gate held v1 for about 36 hours because no test VM could boot on ubuntu-26.04 (#1123, fixed by #1131). The gate did open its hold issue, but it read like a test failure ("failed with no failing scenario recorded"). The hive offered it to contributors as a "good first issue", and it never reached a maintainer. This PR makes two kinds of hold say plainly that they need a maintainer and park them for a person. Ordinary holds don't change.

When a hold is flagged for a maintainer

  1. The test machines never booted: no failed suite produced test results (results.json) on either side, the merged tests or the v1 baseline. scripts/v1_gate_compare.py now prints infrastructure=true for this case. If even one suite produced results, it's an ordinary hold.
  2. The hold is old: the hold issue has been open for more than 24 hours.

What happens then

  • The hold comment (or the new issue) starts with Needs a maintainer: and the reason.
  • The issue gets needs-human and priority/critical-urgent, and good first issue / help wanted are removed. In the hive, needs-human on an issue parks it for a person, so it shows in the maintainers' queue instead of being offered to contributors.
  • If labelling fails, the run logs a warning and the hold continues as before.

Files

  • scripts/v1_gate_compare.py: nothing_ran(), the infrastructure output, and a summary line.
  • tests/unit/test_v1_gate_compare.py: 5 new tests (both sides empty, one side has results, failed scenarios, one of two suites has results, no artifacts at all). The CLI test now expects both output lines.
  • .github/workflows/update-v1-tag.yml: the escalation in "Move or hold v1".
  • docs/skills/ci-ops/ops/references/candidate-vm-validation.md: describes it.

Checks run locally

  • The 14 tests in test_v1_gate_compare.py pass (run directly; pytest runs in CI).

  • ruff check tests/ scripts/v1_gate_compare.py --select E,F,W --ignore E501: clean.

  • actionlint: no findings, same as main.

  • The "Move or hold v1" script, run with a stubbed gh in three cases:

    • infrastructure hold, no open issue: creates the issue with the headline, then labels it;
    • hold open for 2 days: comments with the headline and labels it;
    • fresh ordinary hold: comments with no headline and no labels.

    All three exit 1 as before.

Refs #1123

🤖 Generated with Claude Code

From 2026-11-09 the gate held v1 for about 36 hours because no VM could
boot on ubuntu-26.04 (#1123). The hold issue looked like a test failure
("failed with no failing scenario recorded"), was offered to
contributors as a good first issue, and never reached a maintainer.

Two holds now say so and are parked for a person:
- v1_gate_compare.py reports infrastructure=true when no failed suite
  produced test results on either side (the machines never booted);
- the hold issue has been open for more than 24 hours.
In both cases the comment starts with "Needs a maintainer", and the
issue gets needs-human and priority/critical-urgent and loses
good first issue / help wanted. Ordinary holds are unchanged.

Refs #1123

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hivecommons-hive

Copy link
Copy Markdown
Contributor
1c6e9bd

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @Danathar, head 1c6e9bde4e33) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/update-v1-tag.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/update-v1-tag.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUMAN DECISION NEEDED — @Danathar: confirm workflow correctness and trust-boundary safety before relying on this incomplete review.

Summary: This change directs stalled release checks to maintainers instead of contributors. I found no verified defect in the changes I could read, but could not complete checks of the surrounding automation after GitHub access reached its hourly limit.

What I need from you: Have a maintainer complete the integration and security review.


Reviewed revision 1c6e9bde4e33923c22b2c15d3ce2f13cd4734b2b: PR body, complete diff, and existing comments/reviews. Correctness remains unverified around the new classification (scripts/v1_gate_compare.py:125-140) and its workflow consumer (.github/workflows/update-v1-tag.yml:241-245). Security remains unverified around the new issue-editing operations (.github/workflows/update-v1-tag.yml:311-318): surrounding triggers, permissions, and input sources were unavailable. No local checkout was located; tests were not independently run. These are review limits, not confirmed defects.

No findings from: intent-alignment, style, docs-currency.

Confidence: 3/5 (needs attention) — 2 perspectives requires a human decision

— hive: agent=reviewer backend=copilot model=gpt-6.1-sol copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 8642d8c into main Nov 10, 2026
7 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#11321c6e9bd` sha256:5264a8271194c12fc73723b24790ac88f72f4880b7a6ce134bf583cd5eaf78e2 — download from the dashboard or `hivectl review evidence #1132`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants