Skip to content

ci(v1-gate): boot a pinned Dakota digest that Renovate bumps by PR - #1130

Closed
Danathar wants to merge 1 commit into
mainfrom
ci/pin-test-image
Closed

Danathar wants to merge 1 commit into
mainfrom
ci/pin-test-image

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary: testsuite's v1 gate and its startup PR checks booted the moving dakota:testing tag. When Dakota published a build that can't be installed (2026-11-09, sha256:dc3f6aee…), every gate run failed on both sides and v1 has been held since 2026-11-09 09:41Z (#1123). The startup checks also went red on unrelated PRs (#1127), and nothing showed a single cause. This PR pins the image by digest and lets Renovate bump it through a pull request. A Dakota build that can't be installed then fails that one bump PR, and v1 and everything else keep working.

What changes

File Change
image-versions.yml (new) Dakota :testing pinned to sha256:c10a8b18… (2026-11-08), the newest digest the gate installed and booted (run 42479593163, which moved v1). The org's inherited Renovate config already has a manager for this file (org-inherited-config.json, customManagers), so Renovate opens a digest-bump PR when :testing moves.
update-v1-tag.yml The gate boots the pin. The V1_GATE_IMAGE repo variable still overrides it in an emergency. A digest it's given is kept instead of being resolved again (before, NAME="${GATE_IMAGE%@*}" dropped it).
startup-qualification.yml Pull request runs boot the pin; manual runs boot the image input. image-versions.yml is added to the pull_request paths, so a pin bump runs the startup lane, which is what proves the new image installs and boots.
scripts/vm_validation_plan.py + unit test A pin bump changes no test, so it needs no gate boot. Without the rule it would fall back to the full lane set.
Two skill docs Describe the pin.

e2e.yml (a human-merge release workflow) isn't touched; callers still pass their own image.

How it plays out

  1. This PR's own startup checks boot the pinned 11-08 image, so they prove the pinned path works.
  2. After merge, the next gate run boots c10a8b18 instead of the broken 11-09 build, which should let v1 move again.
  3. Renovate's first bump of image-versions.yml (to the 11-09 build) is expected to go red in its startup checks. That's the intended signal: the bump stays open, no automerge, and it tracks v1 tag held by the post-merge VM gate #1123 until a Dakota build installs again.

The V1_GATE_IMAGE variable (dakota:testing) has already been deleted, so the pin takes effect on merge. Before that, the gate's built-in default was the same tag.

Checks run locally

  • actionlint and zizmor on both workflows: same findings as main (nothing new).
  • The gate's image step, run in a shell for three cases (pin file, variable with a digest, variable with a tag only): each gives the expected image and baseline_image.
  • Renovate's regex against image-versions.yml: matches (packageName, currentValue=testing, currentDigest).
  • suites_for_path("image-versions.yml") == ().

pytest isn't available on the machine I worked from; CI runs it.

Refs #1123

🤖 Generated with Claude Code

The v1 gate and the startup lane's PR checks booted the moving
dakota:testing tag. When Dakota published a build that bootc cannot
install (2026-11-09, sha256:dc3f6aee), every gate run failed on both
sides, v1 stayed held for over a day, and the startup checks went red on
unrelated PRs, with no single place showing the cause (#1123).

Pin the image in image-versions.yml, which the org's inherited Renovate
config already parses. Renovate opens a PR when :testing moves; that PR
runs the startup checks, so an image that cannot be installed fails
there instead of holding v1. The pin starts at sha256:c10a8b18
(2026-11-08), the newest digest the gate installed and booted
(run 42479593163).

- update-v1-tag.yml: use image-versions.yml unless V1_GATE_IMAGE is set
  (emergency override); keep a digest it is given instead of resolving
  the tag again.
- startup-qualification.yml: PR runs boot the pin; manual runs boot the
  image input; image-versions.yml triggers the lane.
- vm_validation_plan.py: a pin bump changes no test, so it needs no gate
  boot (the bump PR's startup checks cover the image).
- Skill docs updated.

Refs #1123

Assisted-by: Claude Opus 5.5 via Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 10, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • startup (broken)
  • startup (candidate)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
feeb4d8

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @Danathar, head feeb4d8301a6) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 2 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/startup-qualification.yml
    • .github/workflows/update-v1-tag.yml
  • ci_gate_weakening — CI configuration is deleted, softened or has gate checks removed (Disables or softens CI gates (continue-on-error, || true, removed checks))
    • .github/workflows/update-v1-tag.yml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@Danathar

Copy link
Copy Markdown
Contributor Author

Closing: the image was never the cause. The 11-08 digest this pins failed on ubuntu-26.04 in this PR's own startup checks, but it installed on ubuntu-24.04 on 11-08. The cause is the runner OS; fixed in #1131.

@Danathar Danathar closed this Nov 10, 2026
@Danathar
Danathar deleted the ci/pin-test-image branch November 10, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant