Skip to content

fix(smoke): make Files, printing, sudoedit and screen reader checks work on Dakota - #1117

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-1059
Nov 7, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-1059

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary: Several Dakota desktop checks still fail because the tests assume things that are only true on the Fedora-based images. This change makes the Files, printing, sudoedit, screen-reader and boot-menu checks work the way Dakota is built. The remaining failures are real Dakota image problems, so they are listed below and still fail on purpose.


Evidence

Failures come from the latest Dakota smoke runs on dakota@sha256:e9918fd7:

Scenario Cause Change
gnome_apps.feature:10 Files launches VM journal: gio launch /usr/share/applications/org.gnome.Nautilus.desktop D-Bus-activates org.gnome.Nautilus, but no window maps (Visible frames: []). In the same run, gnome_files.feature starts Files with the nautilus command and passes. Files now uses the same launch targets as gnome_files_steps.py: the nautilus command first, then the desktop file.
printing.feature:23 raw socket queue nohup python3 listener & disown runs in the SSH session scope. Dakota's logind uses KillUserProcesses=yes, so it kills the listener when SSH disconnects. This is the same mechanism fixed for app launches and ponytail. The listener starts through detached_launch_command (systemd-run --user, with nohup as the fallback).
sudo_rs.feature:23 sudoedit stat reports mode 777 because sudoedit is a symlink. stat -L checks the binary the symlink resolves to, which matches the scenario title.
orca.feature:7 binaries installed rpm: command not found. Dakota has no rpm. The check uses command -v orca && command -v speech-dispatcher.
system_health.feature:7, partial ublue-boot-timeout.service: bootctl: Not booted with UEFI. The CI VM boots without UEFI, so this unit cannot run there. Added it to IGNORED_FAILED_UNITS_IN_VM, next to bootloader-update.service. The unit is still reported outside a VM.

Still failing: Dakota image issues, not masked

  • Power status color (dakota_extensions.feature:78, power_status_color.feature:10/18/28/42): power-status-color@projectbluefin.io is not installed in the image (Extension ... is not installed in the system, and gnome-extensions enable fails). This needs Dakota's Bling pin bumped to a release that ships the extension.
  • NFS units (system_health.feature:7): nfs-idmapd.service fails (libnfsidmap: requested translation method, 'nsswitch', is not available). rpc-statd.service and nfs-mountd.service fail because /var/lib/nfs/sm and /var/lib/nfs/etab are missing. The image appears to be missing its /var/lib/nfs tmpfiles setup.
  • apparmor.service (system_health.feature:7): at boot it was skipped (ConditionSecurity=apparmor not met), but later it is listed as failed. AppArmor is not enabled in the Dakota kernel, so something in the image starts the unit anyway. snapd logs apparmor not enabled.

Validation

  • Added unit tests:
    • Files launches through the nautilus command.
    • The print listener starts outside the SSH session.
    • The sudoedit check follows the symlink.
  • CI runs the unit tests and lint. To confirm on a real Dakota VM, a maintainer needs to run the manual Dakota smoke workflow at this branch.
  • This PR does not touch the files in open PR test: prepare system checks for a fresh image #1116.

Fixes #1059: the power-status-color, NFS and AppArmor failures listed above are Dakota image fixes and remain open.

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 requested_by=@Danathar

…-timeout checks

- Launch Files through the nautilus command; gio launch D-Bus-activates
  Nautilus on Dakota without mapping a window.
- Start the print socket listener with detached_launch_command so logind
  KillUserProcesses=yes does not kill it when the SSH session closes.
- stat -L sudoedit: it is a symlink to the setuid sudo binary on Dakota.
- Check Orca and speech-dispatcher with command -v instead of rpm, which
  Dakota does not ship.
- Ignore ublue-boot-timeout.service in the VM: bootctl refuses to run
  when not booted with UEFI.

Refs #1059

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: 729baa93b43efa947af63be7f1ea2b58e6f39be9

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

Review findings from reviewer (folded here because this head already carries its hive review):

Summary: This change makes five desktop smoke checks (file manager launch, raw-socket printing, the sudoedit permission check, the screen-reader install check, and one boot-menu service) pass on the Dakota image by matching how Dakota is actually built, instead of assuming Fedora conventions. I read the full change and the code around it at this revision; each change does what the description says and is covered by a unit test. One advisory note below about the linked issue being closed while three Dakota image failures stay open.


Reviewed at head ac55c8cf. All five perspectives in one pass.

intent-alignment

style

  • tests/smoke/features/steps/gnome_apps_steps.py:42-45: FILES_LAUNCH_TARGETS is a verbatim copy of tests/smoke/features/steps/gnome_files_steps.py:30-33. Both step modules already import from app_support; one shared constant keeps the two Files launch paths from drifting. Nit, non-blocking.

No findings from: correctness, security, docs-currency.

Evidence bundle `#1117ac55c8c` sha256:4893e0f3dfb8d1fb77ee5d3e72023b87c762d4e571f7d3566851b132c9edfd07 — download from the dashboard or `hivectl review evidence #1117`.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 7, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change makes five desktop smoke checks pass on the Dakota image by launching the file manager the way the other Files tests already do, starting the print-capture helper so it survives the remote login ending, following a shortcut link before checking the sudo editor's permissions, dropping a package-manager command Dakota does not have, and excusing a boot-menu service that cannot run in the test VM. The code is sound and the unit tests cover each change. One bookkeeping gap: the description says it closes the tracking issue while also saying three Dakota image failures from that issue stay open with nowhere else to live.

What I need from you: Change Fixes #1059 to Refs #1059, or open tracking issues for the three remaining image failures and link them in the body.


intent-alignment

  • low — PR body says Fixes #1059 while the same body ("Still failing: Dakota image issues, not masked") and the maintainer's last status comment on #1059 list power-status-color (dakota_extensions.feature:78, power_status_color.feature:10/18/28/42), NFS units and apparmor.service as still failing. Merging auto-closes #1059 and those three failures lose their tracker. Concrete fix: use Refs #1059 (maintainer closes after the manual Dakota run the body itself asks for), or file one issue per remaining image failure and cite them in the body.

style

  • low — FILES_APP_NAMES and FILES_LAUNCH_TARGETS in tests/smoke/features/steps/gnome_apps_steps.py:39-44 now duplicate tests/smoke/features/steps/gnome_files_steps.py:29-31 verbatim. The body says Files "uses the same launch targets as gnome_files_steps.py"; importing them (or moving both to tests/shared/app_support.py) would keep the two from drifting. Advisory only.

Verified: detached_launch_command (tests/shared/app_support.py:90-109) is the same systemd-run --user path already used for app launches, and _run_host (system_health_steps.py:96-99) rewrites its source /tmp/session.env prefix for the local path, so the printing change (printing_steps.py:151) follows an established pattern; stat -L keeps the 4755 root:root assertions (sudo_rs_steps.py:63-72); docs (docs/skills/ci-ops/ops/SKILL.md:116-120) defer to the step file for the exact ignored-unit list, so no doc update is needed. CI at ac55c8c: all 7 checks green.

No findings from: correctness, security, docs-currency.

Confidence: 3/5 (needs attention) — 1 perspective requested changes

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 7, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 0e87d9c into main Nov 7, 2026
7 checks passed
@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(smoke): 16 Dakota smoke scenarios fail on current dakota:testing

1 participant