Repository navigation
fix(smoke): make Files, printing, sudoedit and screen reader checks work on Dakota - #1117
Conversation
…-timeout checks - Launch Files through the nautilus command; gio launch D-Bus-activates Nautilus on Dakota without mapping a window. - Start the print socket listener with detached_launch_command so logind KillUserProcesses=yes does not kill it when the SSH session closes. - stat -L sudoedit: it is a symlink to the setuid sudo binary on Dakota. - Check Orca and speech-dispatcher with command -v instead of rpm, which Dakota does not ship. - Ignore ublue-boot-timeout.service in the VM: bootctl refuses to run when not booted with UEFI. Refs #1059 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 Review findings from Summary: This change makes five desktop smoke checks (file manager launch, raw-socket printing, the Reviewed at head intent-alignment
style
No findings from: correctness, security, docs-currency. Evidence bundle `#1117ac55c8c` sha256:4893e0f3dfb8d1fb77ee5d3e72023b87c762d4e571f7d3566851b132c9edfd07 — download from the dashboard or `hivectl review evidence #1117`. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Summary: This change makes five desktop smoke checks pass on the Dakota image by launching the file manager the way the other Files tests already do, starting the print-capture helper so it survives the remote login ending, following a shortcut link before checking the sudo editor's permissions, dropping a package-manager command Dakota does not have, and excusing a boot-menu service that cannot run in the test VM. The code is sound and the unit tests cover each change. One bookkeeping gap: the description says it closes the tracking issue while also saying three Dakota image failures from that issue stay open with nowhere else to live.
What I need from you: Change Fixes #1059 to Refs #1059, or open tracking issues for the three remaining image failures and link them in the body.
intent-alignment
- low — PR body says
Fixes #1059while the same body ("Still failing: Dakota image issues, not masked") and the maintainer's last status comment on #1059 list power-status-color (dakota_extensions.feature:78,power_status_color.feature:10/18/28/42), NFS units andapparmor.serviceas still failing. Merging auto-closes #1059 and those three failures lose their tracker. Concrete fix: useRefs #1059(maintainer closes after the manual Dakota run the body itself asks for), or file one issue per remaining image failure and cite them in the body.
style
- low —
FILES_APP_NAMESandFILES_LAUNCH_TARGETSintests/smoke/features/steps/gnome_apps_steps.py:39-44now duplicatetests/smoke/features/steps/gnome_files_steps.py:29-31verbatim. The body says Files "uses the same launch targets asgnome_files_steps.py"; importing them (or moving both totests/shared/app_support.py) would keep the two from drifting. Advisory only.
Verified: detached_launch_command (tests/shared/app_support.py:90-109) is the same systemd-run --user path already used for app launches, and _run_host (system_health_steps.py:96-99) rewrites its source /tmp/session.env prefix for the local path, so the printing change (printing_steps.py:151) follows an established pattern; stat -L keeps the 4755 root:root assertions (sudo_rs_steps.py:63-72); docs (docs/skills/ci-ops/ops/SKILL.md:116-120) defer to the step file for the exact ignored-unit list, so no doc update is needed. CI at ac55c8c: all 7 checks green.
No findings from: correctness, security, docs-currency.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Summary: Several Dakota desktop checks still fail because the tests assume things that are only true on the Fedora-based images. This change makes the Files, printing, sudoedit, screen-reader and boot-menu checks work the way Dakota is built. The remaining failures are real Dakota image problems, so they are listed below and still fail on purpose.
Evidence
Failures come from the latest Dakota smoke runs on
dakota@sha256:e9918fd7:main)gnome_apps.feature:10Files launchesgio launch /usr/share/applications/org.gnome.Nautilus.desktopD-Bus-activatesorg.gnome.Nautilus, but no window maps (Visible frames: []). In the same run,gnome_files.featurestarts Files with thenautiluscommand and passes.gnome_files_steps.py: thenautiluscommand first, then the desktop file.printing.feature:23raw socket queuenohup python3 listener & disownruns in the SSH session scope. Dakota's logind usesKillUserProcesses=yes, so it kills the listener when SSH disconnects. This is the same mechanism fixed for app launches and ponytail.detached_launch_command(systemd-run --user, withnohupas the fallback).sudo_rs.feature:23sudoeditstatreports mode777becausesudoeditis a symlink.stat -Lchecks the binary the symlink resolves to, which matches the scenario title.orca.feature:7binaries installedrpm: command not found. Dakota has no rpm.command -v orca && command -v speech-dispatcher.system_health.feature:7, partialublue-boot-timeout.service:bootctl: Not booted with UEFI.The CI VM boots without UEFI, so this unit cannot run there.IGNORED_FAILED_UNITS_IN_VM, next tobootloader-update.service. The unit is still reported outside a VM.Still failing: Dakota image issues, not masked
dakota_extensions.feature:78,power_status_color.feature:10/18/28/42):power-status-color@projectbluefin.iois not installed in the image (Extension ... is not installed in the system, andgnome-extensions enablefails). This needs Dakota's Bling pin bumped to a release that ships the extension.system_health.feature:7):nfs-idmapd.servicefails (libnfsidmap: requested translation method, 'nsswitch', is not available).rpc-statd.serviceandnfs-mountd.servicefail because/var/lib/nfs/smand/var/lib/nfs/etabare missing. The image appears to be missing its/var/lib/nfstmpfiles setup.apparmor.service(system_health.feature:7): at boot it was skipped (ConditionSecurity=apparmornot met), but later it is listed as failed. AppArmor is not enabled in the Dakota kernel, so something in the image starts the unit anyway. snapd logsapparmor not enabled.Validation
nautiluscommand.Fixes #1059: the power-status-color, NFS and AppArmor failures listed above are Dakota image fixes and remain open.
— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 requested_by=@Danathar