Skip to content

[scanner] e2e: let callers run the security test group #1096

Closed

Description

@hivecommons-hive

Summary: The shared desktop-test workflow that other Bluefin projects call can only be asked to run some of the test groups that exist in this repository. The group that checks security settings and where the system image came from is already written but no caller can request it on purpose. This makes it an official, documented choice so the security checks actually run instead of sitting unused.


Part of #704 (expose the unreachable suites via e2e.yml). First of three children; the others build on the same e2e.yml lines, so they are ordered after this one.

Evidence (main, 2026-11-02)

Scope

  1. Add security to the suites input description and to docs/skills/ci-ops/e2e-workflow/references/inputs-outputs.md and the suite map in docs/skills/ci-ops/e2e-workflow/SKILL.md.
  2. Make the SELinux scenarios report an explicit linked blocker (existing @hardware_blocked/@quarantine style tag pointing at feat(e2e): qualify the GHA VM with SELinux enforcing instead of selinux=0 #1024) while the VM boots with selinux=0, so a green security run never means "SELinux checked".
  3. Extend tests/unit/test_e2e_suite_shards.py / tests/unit/test_e2e_workflow.py so security resolves to tests/security/features/ and the documented input values equal the accepted ones.
  4. Existing callers (default smoke) must behave exactly as before.

Acceptance

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

Activity

  1. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    Folded finding. This was filed as a separate issue, but 1 open agent-filed issue (plus 3 closed as completed in the last 14 days) already cite github/workflows/e2e.yml, so it was folded into the oldest of them instead of opening another. Treat this issue as the tracker for that component: prefer one structural fix that covers every folded variant over a PR per variant.

    [scanner] e2e: let callers pick the hardware and NVIDIA test groups and report them as blocked when no hardware exists

    Summary: Two groups of desktop tests check hardware: one for general devices like USB and input, one for NVIDIA graphics cards. Our test machines are virtual and have no real graphics card, so these tests cannot really run there. Today nobody can ask for them at all; this makes them selectable, but when the hardware is missing the result must clearly say "blocked: no hardware" instead of showing a misleading green pass with zero tests run.


    Part of #704 (expose the unreachable suites via e2e.yml). Second of three children; ordered after #1096 because both edit the same e2e.yml suite resolver and docs.

    Evidence (main, 2026-11-02)

    • tests/hardware/features/ — peripherals.feature (10 scenarios), udev_rules.feature (3).
    • tests/nvidia/features/gpu.feature — 12 scenarios, all needing a GPU (lab prerequisite tracked in Lab-repo infrastructure prerequisites blocking test coverage lab#1182).
    • .github/workflows/e2e.yml:1353 filters --tags ~hardware_blocked, so a hardware-tagged suite would execute zero scenarios and the job could still pass.
    • Neither suite is listed in the suites input description (e2e.yml:29).

    Scope

    1. Accept hardware and nvidia as documented suites values (input description, references/inputs-outputs.md, suite map).
    2. When a selected suite executes zero scenarios because every scenario is @hardware_blocked, emit an explicit skipped/blocked result with the reason and the Lab-repo infrastructure prerequisites blocking test coverage lab#1182 link (follow the existing KDE "suite skipped" pattern at e2e.yml:1359), never a silent green.
    3. Unit tests in tests/unit/ covering: both names resolve to their directories; an all-blocked suite yields a blocked result, not a pass.
    4. Default smoke callers unchanged.

    Acceptance

    — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerFiled or owned by the scanner agent.triage/acceptedScope accepted; ready for work. Use `/triage accepted`.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions