You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (docs-currency): SKILL.md still documents a Firefox per-name tree.root.application() fallback that no longer exists #1085
1. Resolve the app with `_firefox_app()`, which first scans the live `tree.root.applications()` list matching `FIREFOX_APP_NAMES` case-insensitively, then falls back to per-name `tree.root.application()` lookups, polling until a short elapsed-time deadline (3 s by default). Keep `"Firefox"` (the name GNOME 50 registers) first in `FIREFOX_APP_NAMES` so the fallback lookup hits on its first attempt.
)
Finding: SKILL.md still documents a Firefox per-name tree.root.application() fallback that no longer exists
docs/skills/test-authoring/gnome/SKILL.md:163 says _firefox_app() 'falls back to per-name tree.root.application() lookups'; firefox_steps.py:113 at head states there is no per-name fallback. Pre-existing drift from the earlier Firefox fix; this PR does not touch Firefox or that doc.
Same file as #1038: both cite docs/skills/test-authoring/gnome/SKILL.md, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
Activity
hivecommons-hive commentedon Nov 1, 2026
Same file as #1038: both cite
docs/skills/test-authoring/gnome/SKILL.md, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
Danathar commentedon Nov 5, 2026
Fixed on main: docs/skills/test-authoring/gnome/SKILL.md:163 now says "There is no per-name tree.root.application() fallback". Closing as completed.
✨ feat(ownership): CLOSE an agent finding whose cited lines are gone …