Skip to content

[reviewer] Review backlog (docs-currency): SKILL.md still documents a Firefox per-name tree.root.application() fallback that no longer exists #1085

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #1081.

PR: #1081 (#1081)
Perspective: docs-currency
Severity: low (P3)
Evidence: docs/skills/test-authoring/gnome/SKILL.md:163 (

1. Resolve the app with `_firefox_app()`, which first scans the live `tree.root.applications()` list matching `FIREFOX_APP_NAMES` case-insensitively, then falls back to per-name `tree.root.application()` lookups, polling until a short elapsed-time deadline (3 s by default). Keep `"Firefox"` (the name GNOME 50 registers) first in `FIREFOX_APP_NAMES` so the fallback lookup hits on its first attempt.
)
Finding: SKILL.md still documents a Firefox per-name tree.root.application() fallback that no longer exists

docs/skills/test-authoring/gnome/SKILL.md:163 says _firefox_app() 'falls back to per-name tree.root.application() lookups'; firefox_steps.py:113 at head states there is no per-name fallback. Pre-existing drift from the earlier Firefox fix; this PR does not touch Firefox or that doc.

Fingerprint: 60211a856d9bd17cc2c1da88b5a4f83119718a3b0d8ab78b80f27602ba852776

filed by Hive review backlog

Activity

  1. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #1038: both cite docs/skills/test-authoring/gnome/SKILL.md, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  2. Danathar commented on Nov 5, 2026

    @Danathar
    Contributor

    Fixed on main: docs/skills/test-authoring/gnome/SKILL.md:163 now says "There is no per-name tree.root.application() fallback". Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions